[FIR] Prevent missing diagnostics on free lambdas

The change in `FirPsiDiagnosticTestGenerated.Resolve#testCast`
only highlights the existing
problem that we don't assign a
valid type to `_`.

^KT-58906 Fixed

compiler/testData/diagnostics/tests/FunctionParameterWithoutType.fir.kt

@@ -5,7 +5,7 @@ fun test(<!VALUE_PARAMETER_WITH_NO_TYPE_ANNOTATION!>a<!>, <!VALUE_PARAMETER_WITH
 
 class A(a<!SYNTAX!><!>)
 
-val bar = fun(a){}
+val bar = fun(<!VALUE_PARAMETER_WITH_NO_TYPE_ANNOTATION!>a<!>){}
 
-val la = { a -> }
+val la = { <!VALUE_PARAMETER_WITH_NO_TYPE_ANNOTATION!>a<!> -> }
 val las = { a: Int -> }

compiler/testData/diagnostics/tests/compilerCrashParameterType.fir.kt

@@ -0,0 +1,8 @@
+// ISSUE: KT-58906
+
+fun someFun(i: Int) = 42
+fun someSad(i: () -> String) = 42
+
+fun main(args: Array<String>) {
+    { <!VALUE_PARAMETER_WITH_NO_TYPE_ANNOTATION!>x<!> -> someFun(x) } //here should be CANNOT_INFER_PARAMETER_TYPE
+}

compiler/testData/diagnostics/tests/compilerCrashParameterType.kt

@@ -0,0 +1,8 @@
+// ISSUE: KT-58906
+
+fun someFun(i: Int) = 42
+fun someSad(i: () -> String) = 42
+
+fun main(args: Array<String>) {
+    { <!CANNOT_INFER_PARAMETER_TYPE!>x<!> -> someFun(<!DEBUG_INFO_ELEMENT_WITH_ERROR_TYPE!>x<!>) } //here should be CANNOT_INFER_PARAMETER_TYPE
+}

compiler/testData/diagnostics/tests/functionAsExpression/MissingParameterTypes.fir.kt

@@ -1,7 +1,7 @@
 // !CHECK_TYPE
 // !DIAGNOSTICS: -UNUSED_PARAMETER -UNUSED_ANONYMOUS_PARAMETER -UNUSED_VARIABLE
 
-val a = fun (x) = x
+val a = fun (<!VALUE_PARAMETER_WITH_NO_TYPE_ANNOTATION!>x<!>) = x
 
 val b: (Int) -> Int = fun (x) = x + 3
 

compiler/testData/diagnostics/tests/functionLiterals/DeprecatedSyntax.fir.kt

@@ -9,8 +9,8 @@ val returnTypeWithParameter = { <!COMPONENT_FUNCTION_MISSING!>(b: Int): Int<!> -
 
 val receiverWithFunctionType = { ((Int)<!SYNTAX!><!> <!SYNTAX!>-> Int).() -><!> }
 
-val parenthesizedParameters = { <!COMPONENT_FUNCTION_MISSING!>(a: Int)<!> -> }
-val parenthesizedParameters2 = { <!COMPONENT_FUNCTION_MISSING!>(b)<!> -> }
+val parenthesizedParameters = { <!COMPONENT_FUNCTION_MISSING, VALUE_PARAMETER_WITH_NO_TYPE_ANNOTATION!>(a: Int)<!> -> }
+val parenthesizedParameters2 = { <!COMPONENT_FUNCTION_MISSING, VALUE_PARAMETER_WITH_NO_TYPE_ANNOTATION!>(b)<!> -> }
 
 val none = { -> }
 
@@ -18,7 +18,7 @@ val none = { -> }
 val parameterWithFunctionType = { a: ((Int) -> Int) -> <!SYNTAX!><!>} // todo fix parser
 
 val newSyntax = { a: Int -> }
-val newSyntax1 = { a, b -> }
+val newSyntax1 = { <!VALUE_PARAMETER_WITH_NO_TYPE_ANNOTATION!>a<!>, <!VALUE_PARAMETER_WITH_NO_TYPE_ANNOTATION!>b<!> -> }
 val newSyntax2 = { a: Int, b: Int -> }
-val newSyntax3 = { a, b: Int -> }
-val newSyntax4 = { a: Int, b -> }
+val newSyntax3 = { <!VALUE_PARAMETER_WITH_NO_TYPE_ANNOTATION!>a<!>, b: Int -> }
+val newSyntax4 = { a: Int, <!VALUE_PARAMETER_WITH_NO_TYPE_ANNOTATION!>b<!> -> }

compiler/testData/diagnostics/tests/functionLiterals/destructuringInLambdas/noExpectedType.fir.kt

@@ -24,7 +24,7 @@ fun bar() {
 
     y2 checkType { _<(A) -> Unit>() }
 
-    val z = { <!COMPONENT_FUNCTION_MISSING, COMPONENT_FUNCTION_MISSING!>(a: Int, b: String)<!> ->
+    val z = { <!COMPONENT_FUNCTION_MISSING, COMPONENT_FUNCTION_MISSING, VALUE_PARAMETER_WITH_NO_TYPE_ANNOTATION!>(a: Int, b: String)<!> ->
         a checkType { _<Int>() }
         b checkType { _<String>() }
     }

compiler/testData/diagnostics/tests/functionLiterals/kt16016.fir.kt

@@ -1,6 +1,6 @@
 // !DIAGNOSTICS: -UNUSED_PARAMETER -UNUSED_VARIABLE
-val la = { a -> }
+val la = { <!VALUE_PARAMETER_WITH_NO_TYPE_ANNOTATION!>a<!> -> }
 val las = { a: Int -> }
 
-val larg = { a -> }(123)
-val twoarg = { a, b: String, c -> }(123, "asdf", 123)
+val larg = { <!VALUE_PARAMETER_WITH_NO_TYPE_ANNOTATION!>a<!> -> }(123)
+val twoarg = { <!VALUE_PARAMETER_WITH_NO_TYPE_ANNOTATION!>a<!>, b: String, <!VALUE_PARAMETER_WITH_NO_TYPE_ANNOTATION!>c<!> -> }(123, "asdf", 123)

compiler/testData/diagnostics/tests/inference/invokeLambdaAsFunction.fir.kt

@@ -1,7 +1,7 @@
-fun test1(i: Int) = { i ->
+fun test1(i: Int) = { <!VALUE_PARAMETER_WITH_NO_TYPE_ANNOTATION!>i<!> ->
     i
 }(i)
 
-fun test2() = { i -> i }<!NO_VALUE_FOR_PARAMETER!>()<!>
+fun test2() = { <!VALUE_PARAMETER_WITH_NO_TYPE_ANNOTATION!>i<!> -> i }<!NO_VALUE_FOR_PARAMETER!>()<!>
 
-fun test3() = { i -> i }(1)
+fun test3() = { <!VALUE_PARAMETER_WITH_NO_TYPE_ANNOTATION!>i<!> -> i }(1)

compiler/testData/diagnostics/tests/inference/kt12399.fir.kt

@@ -1,3 +1,3 @@
 fun foo(a: Any) {
-    foo({ index -> } {  })
+    foo({ <!VALUE_PARAMETER_WITH_NO_TYPE_ANNOTATION!>index<!> -> } {  })
 }

compiler/testData/diagnostics/tests/inference/nonFunctionalExpectedTypeForLambdaArgument.fir.kt

@@ -32,5 +32,5 @@ fun testParamCall() {
 }
 
 fun testNoContext() {
-    { it -> it }
+    { <!VALUE_PARAMETER_WITH_NO_TYPE_ANNOTATION!>it<!> -> it }
 }