azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Generate only final fields for injectors - make the access thread-safe

Browse Source
This commit is contained in:
Nikolay Krasko
2013-07-29 14:53:43 +04:00
parent 14247ea2ab
commit 70ae9e589c
11 changed files with 186 additions and 187 deletions
Download Patch File Download Diff File Expand all files Collapse all files
injector-generator/src/org/jetbrains/jet/di/DependencyInjectorGenerator.java
+2 -3
View File
@@ -235,8 +235,7 @@ public class DependencyInjectorGenerator {
private void generateFields(Printer out) {
for (Field field : fields) {
String _final = backsParameter.contains(field) ? "final " : "";
out.println("private " + _final + type(InjectorGeneratorUtil.getEffectiveFieldType(field)) + " " + field.getName() + ";");
out.println("private final " + type(InjectorGeneratorUtil.getEffectiveFieldType(field)) + " " + field.getName() + ";");
}
}
@@ -299,7 +298,7 @@ public class DependencyInjectorGenerator {
private void generateGetters(Printer out) {
for (Field field : fields) {
if (!field.isPublic()) continue;
String visibility = field.isPublic() ? "public" : "private";
String visibility = "public";
out.println(visibility + " " + type(field.getType()) + " " + field.getGetterName() + "() {");
out.pushIndent();