Formatter, NJ2K: fix indent for comments inside function literals

#KT-4194 Fixed
#KT-31881 Fixed
#KT-34673 Fixed
#KT-35152 Fixed
This commit is contained in:
Dmitry Gridin
2019-11-26 17:31:50 +07:00
parent bfa6bd1396
commit 70185ba2a6
24 changed files with 273 additions and 36 deletions
+2 -1
View File
@@ -4,7 +4,8 @@ package test
class Test(str: String) {
var myStr = "String2"
fun sout(str: String) { // UNNECESSARY_NOT_NULL_ASSERTION heuristic does not work any more, instead we can skip generating !! altogether
fun sout(str: String) {
// UNNECESSARY_NOT_NULL_ASSERTION heuristic does not work any more, instead we can skip generating !! altogether
println(str)
}
+1 -1
View File
@@ -5,7 +5,7 @@ object Test {
fun main(args: Array<String>) {
println() // Comment
foo() // Comment1
// Comment2
// Comment2
.indexOf("s")
}
+5 -2
View File
@@ -6,16 +6,19 @@ package foo
// we need ArrayList
// let's declare a class:
internal class A /* just a sample name*/ : Runnable /* let's implement Runnable */ {
fun foo /* again a sample name */(p: Int /* parameter p */, c: Char /* parameter c */) { // let's print something:
fun foo /* again a sample name */(p: Int /* parameter p */, c: Char /* parameter c */) {
// let's print something:
println("1") // print 1
println("2") // print 2
println("3") // print 3
// end of printing
if (p > 0) { // do this only when p > 0
// we print 4 and return
// we print 4 and return
println("3")
return // do not continue
}
// some code to be added
}
} // end of class A
+3 -2
View File
@@ -3,8 +3,9 @@
package foo
internal class A {
fun /* nothing to return */foo( /* no parameters at all */) { // let declare a variable
// with 2 comments before
fun /* nothing to return */foo( /* no parameters at all */) {
// let declare a variable
// with 2 comments before
val /*int*/a /* it's a */ = 2 /* it's 2 */ + 1 /* it's 1 */ // variable a declared
} // end of foo
+21
View File
@@ -0,0 +1,21 @@
public class Foo {
public void foo() {
System.out.println();
// comment
// comment 2
// comment 3
}
public void setState(Integer state) {
/*some comment 1/*/
/*some comment 2/*/
/*some comment 3/*/
/*some comment 4/*/
}
public void setState2(Integer state) { /*some comment 1/*/
/*some comment 2/*/
/*some comment 3/*/
/*some comment 4/*/
}
}
+21
View File
@@ -0,0 +1,21 @@
class Foo {
fun foo() {
println()
// comment
// comment 2
// comment 3
}
fun setState(state: Int?) {
/*some comment 1/ */
/*some comment 2/ */
/*some comment 3/ */
/*some comment 4/ */
}
fun setState2(state: Int?) { /*some comment 1/ */
/*some comment 2/ */
/*some comment 3/ */
/*some comment 4/ */
}
}
@@ -0,0 +1,13 @@
public class Foo {
private Integer someInt;
public void setState(Integer state) {
//some comment 1
someInt = state;
//some comment 2
if (state == 2)
System.out.println("2");
}
public Integer getState() {
return someInt;
}
}
@@ -0,0 +1,12 @@
class Foo {
var state: Int? = null
private set
fun setState(state: Int) {
//some comment 1
this.state = state
//some comment 2
if (state == 2) println("2")
}
}
@@ -1,10 +1,10 @@
internal class F {
//c1
/*c2*/
/*c2*/
fun f1() {}
//c3
//c4
//c4
fun f2() {}
var i = 0
fun f3() {} //c5
@@ -1,13 +1,13 @@
internal class F {
//c3
//c4
//c4
fun f2() {}
fun f3() {}
fun f4() {}
companion object {
//c1
/*c2*/
/*c2*/
fun f1() {}
var i = 0
@@ -1,10 +1,10 @@
internal object F {
//c1
/*c2*/
/*c2*/
fun f1() {}
//c3
//c4
//c4
fun f2() {}
var i = 0
fun f3() {} //c5
@@ -8,7 +8,8 @@ internal class Test {
return x.toDouble()
}
fun nya(): Double { //TODO explicitlly call apply here
fun nya(): Double {
//TODO explicitlly call apply here
return foo(1, FunctionalI<Int, Double> { x: Int -> this.toDouble(x) })
}
}
+8 -7
View File
@@ -15,7 +15,8 @@ internal class C {
/**
* This is a function doc comment.
*/
fun foo() { /* This is a function comment */
fun foo() {
/* This is a function comment */
}
//simple one line comment for function
@@ -25,29 +26,29 @@ internal class C {
var j = 0
//double c style
//comment before function
//comment before function
fun f2() {}
//double c style
//comment before field
//comment before field
var k = 0
//combination
/** of
*/
//
//
/**
* different
*/
//comments
//comments
fun f3() {}
//combination
/** of
*/
//
//
/**
* different
*/
//comments
//comments
var l = 0
/*two*/ /*comments*/ /*line*/
+2 -2
View File
@@ -14,6 +14,6 @@ class TestMutltipleCtorsWithJavadoc
this.y = y
}
// ---
// Constructors
//
// Constructors
//
}
+2 -1
View File
@@ -10,7 +10,8 @@ class C {
val c = stream.read()
println(c)
}
} finally { // dispose something else
} finally {
// dispose something else
}
}
}