From 6fbf5a8904a2d02efb972bbef50dc3369294c5c5 Mon Sep 17 00:00:00 2001 From: Mikhail Glukhikh Date: Tue, 30 Jan 2018 18:41:46 +0300 Subject: [PATCH] Reverts commit 2472966 (Remove unused function parameter: minor improvement) Transformation was not equivalent due to change signature in between This revert fixes broken quick-fix tests (remove parameter based) --- .../kotlin/idea/quickfix/RemoveUnusedFunctionParameterFix.kt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/idea/src/org/jetbrains/kotlin/idea/quickfix/RemoveUnusedFunctionParameterFix.kt b/idea/src/org/jetbrains/kotlin/idea/quickfix/RemoveUnusedFunctionParameterFix.kt index f839fffe9a2..d6f4c4a12c3 100644 --- a/idea/src/org/jetbrains/kotlin/idea/quickfix/RemoveUnusedFunctionParameterFix.kt +++ b/idea/src/org/jetbrains/kotlin/idea/quickfix/RemoveUnusedFunctionParameterFix.kt @@ -38,15 +38,15 @@ class RemoveUnusedFunctionParameterFix(parameter: KtParameter) : KotlinQuickFixA override fun invoke(project: Project, editor: Editor?, file: KtFile) { val element = element ?: return + val primaryConstructor = element.parent?.parent as? KtPrimaryConstructor + val parameterList = element.parent as? KtParameterList val context = element.analyze() val parameterDescriptor = context[BindingContext.VALUE_PARAMETER, element] as? ValueParameterDescriptor ?: return ChangeFunctionSignatureFix.runRemoveParameter(parameterDescriptor, element) - val parameterList = element.parent as? KtParameterList val nextParameter = parameterList?.parameters?.getOrNull(parameterDescriptor.index) if (nextParameter != null) { editor?.caretModel?.moveToOffset(nextParameter.startOffset) } - val primaryConstructor = element.parent?.parent as? KtPrimaryConstructor if (primaryConstructor != null) { val removeConstructorIntention = RemoveEmptyPrimaryConstructorIntention() if (removeConstructorIntention.isApplicableTo(primaryConstructor)) {