azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Optimize MutableDiagnosticsWithSuppression

Browse Source 
avoid modificationTracker and own diagnostics list initialization if
possible
This commit is contained in:
Ilya Chernikov
2020-03-06 18:19:06 +01:00
parent a28c25b805
commit 6f97745de2
1 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/frontend/src/org/jetbrains/kotlin/resolve/diagnostics/MutableDiagnosticsWithSuppression.kt
+9 -4
View File
@@ -39,11 +39,16 @@ class MutableDiagnosticsWithSuppression @JvmOverloads constructor(
private fun readonlyView(): DiagnosticsWithSuppression = cache.value!! private fun readonlyView(): DiagnosticsWithSuppression = cache.value!!
override val modificationTracker = CompositeModificationTracker(delegateDiagnostics.modificationTracker) override val modificationTracker by lazy(LazyThreadSafetyMode.PUBLICATION) {
CompositeModificationTracker(delegateDiagnostics.modificationTracker)
}
override fun all(): Collection<Diagnostic> = readonlyView().all() override fun all(): Collection<Diagnostic> =
override fun forElement(psiElement: PsiElement) = readonlyView().forElement(psiElement) if (diagnosticList.isEmpty()) delegateDiagnostics.all() else readonlyView().all()
override fun noSuppression() = readonlyView().noSuppression() override fun forElement(psiElement: PsiElement) =
if (diagnosticList.isEmpty()) delegateDiagnostics.forElement(psiElement) else readonlyView().forElement(psiElement)
override fun noSuppression() =
if (diagnosticList.isEmpty()) delegateDiagnostics.noSuppression() else readonlyView().noSuppression()
//essential that this list is readonly //essential that this list is readonly
fun getOwnDiagnostics(): List<Diagnostic> { fun getOwnDiagnostics(): List<Diagnostic> {