J2K: no explicit type required for public declarations

This commit is contained in:
Valentin Kipyatkov
2015-09-15 12:00:31 +03:00
parent c3ddd5d32b
commit 6f12db9cde
41 changed files with 52 additions and 55 deletions
@@ -317,7 +317,7 @@ class Converter private constructor(
else { else {
val isVal = field.isVal(referenceSearcher) val isVal = field.isVal(referenceSearcher)
val typeToDeclare = variableTypeToDeclare(field, val typeToDeclare = variableTypeToDeclare(field,
settings.specifyFieldTypeByDefault || modifiers.isPublic || modifiers.isProtected, settings.specifyFieldTypeByDefault,
isVal && modifiers.isPrivate) isVal && modifiers.isPrivate)
val propertyType = typeToDeclare ?: typeConverter.convertVariableType(field) val propertyType = typeToDeclare ?: typeConverter.convertVariableType(field)
@@ -57,10 +57,7 @@ class Modifiers(modifiers: Collection<Modifier>) : Element() {
fun contains(modifier: Modifier): Boolean = modifiers.contains(modifier) fun contains(modifier: Modifier): Boolean = modifiers.contains(modifier)
val isPublic: Boolean get() = contains(Modifier.PUBLIC)
val isPrivate: Boolean get() = contains(Modifier.PRIVATE) val isPrivate: Boolean get() = contains(Modifier.PRIVATE)
val isProtected: Boolean get() = contains(Modifier.PROTECTED)
val isInternal: Boolean get() = contains(Modifier.INTERNAL)
fun accessModifier(): Modifier? = modifiers.firstOrNull { it in ACCESS_MODIFIERS } fun accessModifier(): Modifier? = modifiers.firstOrNull { it in ACCESS_MODIFIERS }
@@ -8,7 +8,7 @@ annotation internal class Anon(val value: String) {
companion object { companion object {
val field: E = E.A val field = E.A
} }
} }
+1 -1
View File
@@ -1,6 +1,6 @@
internal open class Base { internal open class Base {
companion object { companion object {
val CONSTANT: Int = 10 val CONSTANT = 10
} }
} }
+1 -1
View File
@@ -5,5 +5,5 @@ internal object Util {
fun util2() { fun util2() {
} }
val CONSTANT: Int = 10 val CONSTANT = 10
} }
+1 -1
View File
@@ -6,5 +6,5 @@ internal object Util {
fun util2() { fun util2() {
} }
val CONSTANT: Int = 10 val CONSTANT = 10
} }
+1 -1
View File
@@ -5,5 +5,5 @@ internal object Util {
fun util2() { fun util2() {
} }
val CONSTANT: Int = 10 val CONSTANT = 10
} }
+1 -1
View File
@@ -23,6 +23,6 @@ internal class A {
companion object { companion object {
/*it's public*//*and static*//*and final*/ val C: Int = 1 /*it's public*//*and static*//*and final*/ val C = 1
} }
} }
+2 -2
View File
@@ -15,8 +15,8 @@ internal class Customer internal constructor(val firstName: String, val lastName
} }
internal class CustomerBuilder { internal class CustomerBuilder {
var _firstName: String = "Homer" var _firstName = "Homer"
var _lastName: String = "Simpson" var _lastName = "Simpson"
fun WithFirstName(firstName: String): CustomerBuilder { fun WithFirstName(firstName: String): CustomerBuilder {
_firstName = firstName _firstName = firstName
@@ -3,7 +3,7 @@ internal class A JvmOverloads internal constructor(nested: A.Nested = A.Nested(A
internal class Nested internal constructor(p: Int) { internal class Nested internal constructor(p: Int) {
companion object { companion object {
val FIELD: Int = 0 val FIELD = 0
} }
} }
} }
@@ -6,7 +6,7 @@ internal class A JvmOverloads internal constructor(nested: Nested = Nested(Neste
internal class Nested internal constructor(p: Int) { internal class Nested internal constructor(p: Int) {
companion object { companion object {
val FIELD: Int = 0 val FIELD = 0
} }
} }
} }
@@ -8,7 +8,7 @@ internal class A JvmOverloads internal constructor(nested: Nested = Nested(Neste
internal class Nested internal constructor(p: Int) { internal class Nested internal constructor(p: Int) {
companion object { companion object {
val FIELD: Int = 0 val FIELD = 0
} }
} }
} }
@@ -8,7 +8,7 @@ internal class A JvmOverloads internal constructor(nested: Nested = Nested(Neste
internal class Nested internal constructor(p: Int) { internal class Nested internal constructor(p: Int) {
companion object { companion object {
val FIELD: Int = 0 val FIELD = 0
} }
} }
} }
@@ -3,7 +3,7 @@ internal open class Base internal constructor(nested: Base.Nested) {
internal class Nested internal constructor(p: Int) { internal class Nested internal constructor(p: Int) {
companion object { companion object {
val FIELD: Int = 0 val FIELD = 0
} }
} }
} }
@@ -1,3 +1,3 @@
class AAA { class AAA {
val x: Int = 42 val x = 42
} }
@@ -1,5 +1,5 @@
class AAA { class AAA {
var x: Int = 42 var x = 42
private set private set
fun foo(other: AAA) { fun foo(other: AAA) {
@@ -1,5 +1,5 @@
open class Base internal constructor(x: Int) { open class Base internal constructor(x: Int) {
var x: Int = 42 var x = 42
protected set protected set
init { init {
@@ -1,5 +1,5 @@
open class AAA { open class AAA {
var x: Int = 42 var x = 42
protected set protected set
fun foo(other: AAA) { fun foo(other: AAA) {
+1 -1
View File
@@ -1,3 +1,3 @@
class AAA { class AAA {
val x: Int = 42 val x = 42
} }
@@ -1,3 +1,3 @@
class AAA { class AAA {
var x: Int = 42 var x = 42
} }
@@ -1,5 +1,5 @@
class AAA { class AAA {
var x: Int = 42 var x = 42
private set private set
fun foo() { fun foo() {
+1 -1
View File
@@ -1,5 +1,5 @@
class AAA { class AAA {
var x: Int = 42 var x = 42
private set private set
fun setX(x: Int) { fun setX(x: Int) {
@@ -1,5 +1,5 @@
class AAA { class AAA {
var x: Int = 42 var x = 42
private set private set
fun setY(x: Int) { fun setY(x: Int) {
@@ -1,5 +1,5 @@
class AAA { class AAA {
var x: Int = 42 var x = 42
fun foo() { fun foo() {
x = x + 1 x = x + 1
@@ -5,6 +5,6 @@ class AAA {
companion object { companion object {
var x: Int = 42 var x = 42
} }
} }
+4 -4
View File
@@ -1,7 +1,7 @@
object AAA { object AAA {
var x: Int = 42 var x = 42
var y: Int = 0 var y = 0
val z: Int = 0 val z = 0
fun setZ(z: Int) { fun setZ(z: Int) {
Other.z = z Other.z = z
@@ -9,5 +9,5 @@ object AAA {
} }
internal object Other { internal object Other {
var z: Int = 0 var z = 0
} }
@@ -1,5 +1,5 @@
internal class C { internal class C {
val default: Int = 0 val default = 0
internal fun foo() { internal fun foo() {
println(default) println(default)
@@ -1,5 +1,5 @@
internal class C { internal class C {
val `this`: Int = 0 val `this` = 0
internal fun foo() { internal fun foo() {
println(`this`) println(`this`)
+2 -2
View File
@@ -3,8 +3,8 @@ import java.util.*
internal class A { internal class A {
private val field1 = ArrayList<String>() private val field1 = ArrayList<String>()
internal val field2: List<String> = ArrayList() internal val field2: List<String> = ArrayList()
val field3: Int = 0 val field3 = 0
protected val field4: Int = 0 protected val field4 = 0
private var field5: List<String> = ArrayList() private var field5: List<String> = ArrayList()
internal var field6: List<String> = ArrayList() internal var field6: List<String> = ArrayList()
@@ -1,5 +1,5 @@
internal class X { internal class X {
var length: Int = 5 var length = 5
} }
internal class C { internal class C {
@@ -9,7 +9,7 @@ internal class Test {
} }
companion object { companion object {
var field: Java8Class = Java8Class() var field = Java8Class()
fun staticFun(): Java8Class { fun staticFun(): Java8Class {
return Java8Class() return Java8Class()
} }
@@ -15,7 +15,7 @@ internal class Test {
} }
companion object { companion object {
var field: Java8Class = Java8Class() var field = Java8Class()
fun staticFun(): Java8Class { fun staticFun(): Java8Class {
return Java8Class() return Java8Class()
} }
+2 -2
View File
@@ -9,8 +9,8 @@ class Language(protected var code: String) : Serializable {
} }
companion object { companion object {
var ENGLISH: Language = Language("en") var ENGLISH = Language("en")
var SWEDISH: Language = Language("sv") var SWEDISH = Language("sv")
private val serialVersionUID = -2442762969929206780L private val serialVersionUID = -2442762969929206780L
} }
} }
+1 -1
View File
@@ -1,5 +1,5 @@
internal class A { internal class A {
var field: Int = 0 var field = 0
fun setField() { fun setField() {
field = 0 field = 0
+3 -3
View File
@@ -1,7 +1,7 @@
internal interface INode { internal interface INode {
companion object { companion object {
val IN: String = "in" val IN = "in"
val AT: String = "@" val AT = "@"
val COMMA_WITH_SPACE: String = COMMA + SPACE val COMMA_WITH_SPACE = COMMA + SPACE
} }
} }
@@ -1,7 +1,7 @@
interface INode { interface INode {
companion object { companion object {
val IN: String = "in" val IN = "in"
val AT: String = "@" val AT = "@"
val COMMA_WITH_SPACE: String = COMMA + SPACE val COMMA_WITH_SPACE = COMMA + SPACE
} }
} }
+2 -2
View File
@@ -1,8 +1,8 @@
package test package test
internal open class JavaClass { internal open class JavaClass {
var field: Int = 0 var field = 0
var property: Int = 0 var property = 0
protected set protected set
} }
+1 -1
View File
@@ -1,5 +1,5 @@
class AAA { class AAA {
var x: Int = 42 var x = 42
fun foo() { fun foo() {
x = x + 1 x = x + 1
+1 -1
View File
@@ -4,6 +4,6 @@ internal class B {
YY += "a" YY += "a"
} }
var YY: String = "" var YY = ""
private set private set
} }
@@ -9,8 +9,8 @@ internal open class ClassWithStatics {
fun staticMethod(p: Int) { fun staticMethod(p: Int) {
} }
val staticField: Int = 1 val staticField = 1
var value: Int = 0 var value = 0
} }
} }
+1 -1
View File
@@ -8,5 +8,5 @@ internal object Utils {
return 1 return 1
} }
val staticField: Int = 1 val staticField = 1
} }