[FIR] Convert REDUNDANT_MODIFIER, DEPRECATED_MODIFIER_PAIR to warnings ^KT-49073 Fixed

compiler/fir/checkers/checkers-component-generator/src/org/jetbrains/kotlin/fir/checkers/generator/diagnostics/FirDiagnosticsList.kt

@@ -332,7 +332,7 @@ object DIAGNOSTICS_LIST : DiagnosticList("FirErrors") {
         val REPEATED_MODIFIER by error<PsiElement> {
             parameter<KtModifierKeywordToken>("modifier")
         }
-        val REDUNDANT_MODIFIER by error<PsiElement> {
+        val REDUNDANT_MODIFIER by warning<PsiElement> {
             parameter<KtModifierKeywordToken>("redundantModifier")
             parameter<KtModifierKeywordToken>("conflictingModifier")
         }
@@ -340,7 +340,7 @@ object DIAGNOSTICS_LIST : DiagnosticList("FirErrors") {
             parameter<KtModifierKeywordToken>("deprecatedModifier")
             parameter<KtModifierKeywordToken>("actualModifier")
         }
-        val DEPRECATED_MODIFIER_PAIR by error<PsiElement> {
+        val DEPRECATED_MODIFIER_PAIR by warning<PsiElement> {
             parameter<KtModifierKeywordToken>("deprecatedModifier")
             parameter<KtModifierKeywordToken>("conflictingModifier")
         }

compiler/fir/checkers/gen/org/jetbrains/kotlin/fir/analysis/diagnostics/FirErrors.kt

@@ -271,9 +271,9 @@ object FirErrors {
     // Modifiers
     val INAPPLICABLE_INFIX_MODIFIER by error0<PsiElement>()
     val REPEATED_MODIFIER by error1<PsiElement, KtModifierKeywordToken>()
-    val REDUNDANT_MODIFIER by error2<PsiElement, KtModifierKeywordToken, KtModifierKeywordToken>()
+    val REDUNDANT_MODIFIER by warning2<PsiElement, KtModifierKeywordToken, KtModifierKeywordToken>()
     val DEPRECATED_MODIFIER by warning2<PsiElement, KtModifierKeywordToken, KtModifierKeywordToken>()
-    val DEPRECATED_MODIFIER_PAIR by error2<PsiElement, KtModifierKeywordToken, KtModifierKeywordToken>()
+    val DEPRECATED_MODIFIER_PAIR by warning2<PsiElement, KtModifierKeywordToken, KtModifierKeywordToken>()
     val DEPRECATED_MODIFIER_FOR_TARGET by warning2<PsiElement, KtModifierKeywordToken, String>()
     val REDUNDANT_MODIFIER_FOR_TARGET by warning2<PsiElement, KtModifierKeywordToken, String>()
     val INCOMPATIBLE_MODIFIERS by error2<PsiElement, KtModifierKeywordToken, KtModifierKeywordToken>()

compiler/testData/codegen/box/functions/defaultargs.kt

@@ -1,4 +1,3 @@
-// IGNORE_FIR_DIAGNOSTICS
 open abstract class B {
     fun foo(arg: Int = 239 + 1) : Int = arg
 }

compiler/testData/codegen/box/functions/defaultargs4.kt

@@ -1,4 +1,3 @@
-// IGNORE_FIR_DIAGNOSTICS
 interface A {
     fun bar2(arg: Int = 239) : Int
 

compiler/testData/codegen/box/functions/defaultargs5.kt

@@ -1,4 +1,3 @@
-// IGNORE_FIR_DIAGNOSTICS
 open abstract class B {
     abstract fun foo2(arg: Int = 239) : Int
 }

compiler/testData/codegen/box/super/innerClassLabeledSuper2.kt

@@ -1,4 +1,3 @@
-// IGNORE_FIR_DIAGNOSTICS
 //inspired by kt3492
 interface BK {
     fun foo(): String