Code simplifications

idea/src/org/jetbrains/kotlin/idea/presentation/KtFunctionPresenter.kt

@@ -16,11 +16,8 @@
 
 package org.jetbrains.kotlin.idea.presentation
 
-import com.google.common.base.Function
-import com.google.common.collect.Collections2
 import com.intellij.navigation.ItemPresentation
 import com.intellij.navigation.ItemPresentationProvider
-import org.apache.commons.lang.StringUtils
 import org.jetbrains.kotlin.psi.KtConstructor
 import org.jetbrains.kotlin.psi.KtFunction
 import org.jetbrains.kotlin.psi.KtFunctionLiteral
@@ -34,34 +31,22 @@ class KtFunctionPresenter : ItemPresentationProvider<KtFunction> {
                 return buildString {
                     function.name?.let { append(it) }
 
-                    val paramsStrings = Collections2.transform(function.valueParameters, Function<org.jetbrains.kotlin.psi.KtParameter, kotlin.String> { parameter ->
+                    append("(")
-                        if (parameter != null) {
+                    append(function.valueParameters.joinToString { it.typeReference?.text ?: "" })
-                            val reference = parameter.typeReference
+                    append(")")
-                            if (reference != null) {
-                                val text = reference.text
-                                if (text != null) {
-                                    return@Function text
-                                }
-                            }
-                        }
-
-                        "?"
-                    })
-
-                    append("(").append(StringUtils.join(paramsStrings, ",")).append(")")
                 }
             }
 
-            override fun getLocationString(): String {
+            override fun getLocationString(): String? {
                 if (function is KtConstructor<*>) {
-                    val name = function.getContainingClassOrObject().fqName ?: return ""
+                    val name = function.getContainingClassOrObject().fqName ?: return null
                     return "(in $name)"
                 }
 
-                val name = function.fqName ?: return ""
+                val name = function.fqName ?: return null
                 val receiverTypeRef = function.receiverTypeReference
                 val extensionLocation = if (receiverTypeRef != null) "for " + receiverTypeRef.text + " " else ""
-                return "(%sin %s)".format(extensionLocation, name.parent())
+                return "(${extensionLocation}in ${name.parent()})"
             }
         }
     }

idea/src/org/jetbrains/kotlin/idea/presentation/KtLightClassListCellRenderer.kt

@@ -21,22 +21,9 @@ import com.intellij.psi.presentation.java.ClassPresentationUtil
 import org.jetbrains.kotlin.asJava.KtLightClass
 
 class KtLightClassListCellRenderer : PsiElementListCellRenderer<KtLightClass>() {
-    override fun getElementText(element: KtLightClass): String {
+    override fun getElementText(element: KtLightClass) = ClassPresentationUtil.getNameForClass(element, false)
-        return ClassPresentationUtil.getNameForClass(element, false)
-    }
 
-    override fun getContainerText(element: KtLightClass, name: String): String? {
+    override fun getContainerText(element: KtLightClass, name: String) = "(" + element.getFqName().parent() + ")"
-        return getContainerTextStatic(element)
-    }
 
-    override fun getIconFlags(): Int {
+    override fun getIconFlags() = 0
-        return 0
-    }
-
-    companion object {
-
-        fun getContainerTextStatic(element: KtLightClass): String? {
-            return "(" + element.getFqName().parent() + ")"
-        }
-    }
 }

idea/src/org/jetbrains/kotlin/idea/presentation/KtObjectPresenter.kt

@@ -16,12 +16,9 @@
 
 package org.jetbrains.kotlin.idea.presentation
 
-import com.intellij.navigation.ItemPresentation
 import com.intellij.navigation.ItemPresentationProvider
 import org.jetbrains.kotlin.psi.KtObjectDeclaration
 
 class KtObjectPresenter : ItemPresentationProvider<KtObjectDeclaration> {
-    override fun getPresentation(item: KtObjectDeclaration): ItemPresentation {
+    override fun getPresentation(item: KtObjectDeclaration) = KotlinDefaultNamedDeclarationPresentation(item)
-        return KotlinDefaultNamedDeclarationPresentation(item)
-    }
 }

idea/src/org/jetbrains/kotlin/idea/presentation/KtParameterPresenter.kt

@@ -16,12 +16,9 @@
 
 package org.jetbrains.kotlin.idea.presentation
 
-import com.intellij.navigation.ItemPresentation
 import com.intellij.navigation.ItemPresentationProvider
 import org.jetbrains.kotlin.psi.KtParameter
 
 class KtParameterPresenter : ItemPresentationProvider<KtParameter> {
-    override fun getPresentation(item: KtParameter): ItemPresentation {
+    override fun getPresentation(item: KtParameter) = KotlinDefaultNamedDeclarationPresentation(item)
-        return KotlinDefaultNamedDeclarationPresentation(item)
-    }
 }

idea/src/org/jetbrains/kotlin/idea/presentation/KtPropertyPresenter.kt

@@ -16,12 +16,9 @@
 
 package org.jetbrains.kotlin.idea.presentation
 
-import com.intellij.navigation.ItemPresentation
 import com.intellij.navigation.ItemPresentationProvider
 import org.jetbrains.kotlin.psi.KtProperty
 
 class KtPropertyPresenter : ItemPresentationProvider<KtProperty> {
-    override fun getPresentation(item: KtProperty): ItemPresentation {
+    override fun getPresentation(item: KtProperty) = KotlinDefaultNamedDeclarationPresentation(item)
-        return KotlinDefaultNamedDeclarationPresentation(item)
-    }
 }