azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIR] Initialize public visibility for class-like declarations at FIR building phase if no modifier is presented

Browse Source 
Java resolving subsystem requires calculated visibility for correct disambiguation of supertypes.
But visibility remains `Unknown` for Kotlin class-like declarations during supertypes resolving because `STATUS` resolve phase is performed after `SUPER_TYPES` phase.
To fix the problem, the visibility should be initialized to public at the FIR building phase if no modifier is presented.

^KT-64127 Fixed
This commit is contained in:
Ivan Kochurkin
2023-12-13 23:57:19 +01:00
committed by Space Team
parent ee8d42532b
commit 69b9bfc3e0
915 changed files with 12362 additions and 12164 deletions
Download Patch File Download Diff File Expand all files Collapse all files
analysis/low-level-api-fir/testData/lazyResolve/properties/hierarchyWithOverride.txt
Vendored
+18 -18
View File
@@ -1,6 +1,6 @@
RAW_FIR:
FILE: [ResolvedTo(RAW_FIR)] hierarchyWithOverride.kt
public? final? [ResolvedTo(RAW_FIR)] interface Foo1 : R|kotlin/Any| {
public final? [ResolvedTo(RAW_FIR)] interface Foo1 : R|kotlin/Any| {
public? final? [ResolvedTo(RAW_FIR)] fun foo(): R|kotlin/Unit|
public? final? [ResolvedTo(RAW_FIR)] fun bar(): R|kotlin/Unit|
@@ -9,7 +9,7 @@ FILE: [ResolvedTo(RAW_FIR)] hierarchyWithOverride.kt
public? [ResolvedTo(RAW_FIR)] [ContainingClassKey=Foo1] get(): String
}
public? final? [ResolvedTo(RAW_FIR)] interface Foo2 : Foo1 {
public final? [ResolvedTo(RAW_FIR)] interface Foo2 : Foo1 {
public? final? [ResolvedTo(RAW_FIR)] fun foo([ResolvedTo(RAW_FIR)] i: Int): R|kotlin/Unit|
public? final? [ResolvedTo(RAW_FIR)] fun bar([ResolvedTo(RAW_FIR)] s: String): R|kotlin/Unit|
@@ -18,7 +18,7 @@ FILE: [ResolvedTo(RAW_FIR)] hierarchyWithOverride.kt
public? [ResolvedTo(RAW_FIR)] [ContainingClassKey=Foo2] get(): Boolean
}
public? abstract [ResolvedTo(RAW_FIR)] class Usage : Foo2 {
public abstract [ResolvedTo(RAW_FIR)] class Usage : Foo2 {
public? [ResolvedTo(RAW_FIR)] [ContainingClassKey=Usage] constructor(): R|Usage| {
LAZY_super<<implicit>>
}
@@ -32,7 +32,7 @@ FILE: [ResolvedTo(RAW_FIR)] hierarchyWithOverride.kt
IMPORTS:
FILE: [ResolvedTo(IMPORTS)] hierarchyWithOverride.kt
public? final? [ResolvedTo(RAW_FIR)] interface Foo1 : R|kotlin/Any| {
public final? [ResolvedTo(RAW_FIR)] interface Foo1 : R|kotlin/Any| {
public? final? [ResolvedTo(RAW_FIR)] fun foo(): R|kotlin/Unit|
public? final? [ResolvedTo(RAW_FIR)] fun bar(): R|kotlin/Unit|
@@ -41,7 +41,7 @@ FILE: [ResolvedTo(IMPORTS)] hierarchyWithOverride.kt
public? [ResolvedTo(RAW_FIR)] [ContainingClassKey=Foo1] get(): String
}
public? final? [ResolvedTo(RAW_FIR)] interface Foo2 : Foo1 {
public final? [ResolvedTo(RAW_FIR)] interface Foo2 : Foo1 {
public? final? [ResolvedTo(RAW_FIR)] fun foo([ResolvedTo(RAW_FIR)] i: Int): R|kotlin/Unit|
public? final? [ResolvedTo(RAW_FIR)] fun bar([ResolvedTo(RAW_FIR)] s: String): R|kotlin/Unit|
@@ -50,7 +50,7 @@ FILE: [ResolvedTo(IMPORTS)] hierarchyWithOverride.kt
public? [ResolvedTo(RAW_FIR)] [ContainingClassKey=Foo2] get(): Boolean
}
public? abstract [ResolvedTo(RAW_FIR)] class Usage : Foo2 {
public abstract [ResolvedTo(RAW_FIR)] class Usage : Foo2 {
public? [ResolvedTo(RAW_FIR)] [ContainingClassKey=Usage] constructor(): R|Usage| {
LAZY_super<<implicit>>
}
@@ -64,7 +64,7 @@ FILE: [ResolvedTo(IMPORTS)] hierarchyWithOverride.kt
COMPILER_REQUIRED_ANNOTATIONS:
FILE: [ResolvedTo(IMPORTS)] hierarchyWithOverride.kt
public? final? [ResolvedTo(RAW_FIR)] interface Foo1 : R|kotlin/Any| {
public final? [ResolvedTo(RAW_FIR)] interface Foo1 : R|kotlin/Any| {
public? final? [ResolvedTo(RAW_FIR)] fun foo(): R|kotlin/Unit|
public? final? [ResolvedTo(RAW_FIR)] fun bar(): R|kotlin/Unit|
@@ -73,7 +73,7 @@ FILE: [ResolvedTo(IMPORTS)] hierarchyWithOverride.kt
public? [ResolvedTo(RAW_FIR)] [ContainingClassKey=Foo1] get(): String
}
public? final? [ResolvedTo(RAW_FIR)] interface Foo2 : Foo1 {
public final? [ResolvedTo(RAW_FIR)] interface Foo2 : Foo1 {
public? final? [ResolvedTo(RAW_FIR)] fun foo([ResolvedTo(RAW_FIR)] i: Int): R|kotlin/Unit|
public? final? [ResolvedTo(RAW_FIR)] fun bar([ResolvedTo(RAW_FIR)] s: String): R|kotlin/Unit|
@@ -82,7 +82,7 @@ FILE: [ResolvedTo(IMPORTS)] hierarchyWithOverride.kt
public? [ResolvedTo(RAW_FIR)] [ContainingClassKey=Foo2] get(): Boolean
}
public? abstract [ResolvedTo(RAW_FIR)] class Usage : Foo2 {
public abstract [ResolvedTo(RAW_FIR)] class Usage : Foo2 {
public? [ResolvedTo(RAW_FIR)] [ContainingClassKey=Usage] constructor(): R|Usage| {
LAZY_super<<implicit>>
}
@@ -96,7 +96,7 @@ FILE: [ResolvedTo(IMPORTS)] hierarchyWithOverride.kt
COMPANION_GENERATION:
FILE: [ResolvedTo(IMPORTS)] hierarchyWithOverride.kt
public? final? [ResolvedTo(RAW_FIR)] interface Foo1 : R|kotlin/Any| {
public final? [ResolvedTo(RAW_FIR)] interface Foo1 : R|kotlin/Any| {
public? final? [ResolvedTo(RAW_FIR)] fun foo(): R|kotlin/Unit|
public? final? [ResolvedTo(RAW_FIR)] fun bar(): R|kotlin/Unit|
@@ -105,7 +105,7 @@ FILE: [ResolvedTo(IMPORTS)] hierarchyWithOverride.kt
public? [ResolvedTo(RAW_FIR)] [ContainingClassKey=Foo1] get(): String
}
public? final? [ResolvedTo(RAW_FIR)] interface Foo2 : Foo1 {
public final? [ResolvedTo(RAW_FIR)] interface Foo2 : Foo1 {
public? final? [ResolvedTo(RAW_FIR)] fun foo([ResolvedTo(RAW_FIR)] i: Int): R|kotlin/Unit|
public? final? [ResolvedTo(RAW_FIR)] fun bar([ResolvedTo(RAW_FIR)] s: String): R|kotlin/Unit|
@@ -114,7 +114,7 @@ FILE: [ResolvedTo(IMPORTS)] hierarchyWithOverride.kt
public? [ResolvedTo(RAW_FIR)] [ContainingClassKey=Foo2] get(): Boolean
}
public? abstract [ResolvedTo(RAW_FIR)] class Usage : Foo2 {
public abstract [ResolvedTo(RAW_FIR)] class Usage : Foo2 {
public? [ResolvedTo(RAW_FIR)] [ContainingClassKey=Usage] constructor(): R|Usage| {
LAZY_super<<implicit>>
}
@@ -128,7 +128,7 @@ FILE: [ResolvedTo(IMPORTS)] hierarchyWithOverride.kt
SUPER_TYPES:
FILE: [ResolvedTo(IMPORTS)] hierarchyWithOverride.kt
public? final? [ResolvedTo(SUPER_TYPES)] interface Foo1 : R|kotlin/Any| {
public final? [ResolvedTo(SUPER_TYPES)] interface Foo1 : R|kotlin/Any| {
public? final? [ResolvedTo(RAW_FIR)] fun foo(): R|kotlin/Unit|
public? final? [ResolvedTo(RAW_FIR)] fun bar(): R|kotlin/Unit|
@@ -137,7 +137,7 @@ FILE: [ResolvedTo(IMPORTS)] hierarchyWithOverride.kt
public? [ResolvedTo(RAW_FIR)] [ContainingClassKey=Foo1] get(): String
}
public? final? [ResolvedTo(SUPER_TYPES)] interface Foo2 : R|Foo1| {
public final? [ResolvedTo(SUPER_TYPES)] interface Foo2 : R|Foo1| {
public? final? [ResolvedTo(RAW_FIR)] fun foo([ResolvedTo(RAW_FIR)] i: Int): R|kotlin/Unit|
public? final? [ResolvedTo(RAW_FIR)] fun bar([ResolvedTo(RAW_FIR)] s: String): R|kotlin/Unit|
@@ -146,7 +146,7 @@ FILE: [ResolvedTo(IMPORTS)] hierarchyWithOverride.kt
public? [ResolvedTo(RAW_FIR)] [ContainingClassKey=Foo2] get(): Boolean
}
public? abstract [ResolvedTo(SUPER_TYPES)] class Usage : R|Foo2| {
public abstract [ResolvedTo(SUPER_TYPES)] class Usage : R|Foo2| {
public? [ResolvedTo(RAW_FIR)] [ContainingClassKey=Usage] constructor(): R|Usage| {
LAZY_super<<implicit>>
}
@@ -160,7 +160,7 @@ FILE: [ResolvedTo(IMPORTS)] hierarchyWithOverride.kt
TYPES:
FILE: [ResolvedTo(IMPORTS)] hierarchyWithOverride.kt
public? final? [ResolvedTo(SUPER_TYPES)] interface Foo1 : R|kotlin/Any| {
public final? [ResolvedTo(SUPER_TYPES)] interface Foo1 : R|kotlin/Any| {
public? final? [ResolvedTo(RAW_FIR)] fun foo(): R|kotlin/Unit|
public? final? [ResolvedTo(RAW_FIR)] fun bar(): R|kotlin/Unit|
@@ -169,7 +169,7 @@ FILE: [ResolvedTo(IMPORTS)] hierarchyWithOverride.kt
public? [ResolvedTo(RAW_FIR)] [ContainingClassKey=Foo1] get(): String
}
public? final? [ResolvedTo(SUPER_TYPES)] interface Foo2 : R|Foo1| {
public final? [ResolvedTo(SUPER_TYPES)] interface Foo2 : R|Foo1| {
public? final? [ResolvedTo(RAW_FIR)] fun foo([ResolvedTo(RAW_FIR)] i: Int): R|kotlin/Unit|
public? final? [ResolvedTo(RAW_FIR)] fun bar([ResolvedTo(RAW_FIR)] s: String): R|kotlin/Unit|
@@ -178,7 +178,7 @@ FILE: [ResolvedTo(IMPORTS)] hierarchyWithOverride.kt
public? [ResolvedTo(RAW_FIR)] [ContainingClassKey=Foo2] get(): Boolean
}
public? abstract [ResolvedTo(TYPES)] class Usage : R|Foo2| {
public abstract [ResolvedTo(TYPES)] class Usage : R|Foo2| {
public? [ResolvedTo(RAW_FIR)] [ContainingClassKey=Usage] constructor(): R|Usage| {
LAZY_super<<implicit>>
}