azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIR] Initialize public visibility for class-like declarations at FIR building phase if no modifier is presented

Browse Source 
Java resolving subsystem requires calculated visibility for correct disambiguation of supertypes.
But visibility remains `Unknown` for Kotlin class-like declarations during supertypes resolving because `STATUS` resolve phase is performed after `SUPER_TYPES` phase.
To fix the problem, the visibility should be initialized to public at the FIR building phase if no modifier is presented.

^KT-64127 Fixed
This commit is contained in:
Ivan Kochurkin
2023-12-13 23:57:19 +01:00
committed by Space Team
parent ee8d42532b
commit 69b9bfc3e0
915 changed files with 12362 additions and 12164 deletions
Download Patch File Download Diff File Expand all files Collapse all files
analysis/low-level-api-fir/testData/lazyResolve/functionWithParameter.txt
Vendored
+12 -12
View File
@@ -1,60 +1,60 @@
RAW_FIR:
FILE: [ResolvedTo(RAW_FIR)] functionWithParameter.kt
public? final? [ResolvedTo(RAW_FIR)] interface I : R|kotlin/Any| {
public final? [ResolvedTo(RAW_FIR)] interface I : R|kotlin/Any| {
}
public? final? [ResolvedTo(RAW_FIR)] fun resolveMe([ResolvedTo(RAW_FIR)] param: I): <implicit> { LAZY_BLOCK }
IMPORTS:
FILE: [ResolvedTo(IMPORTS)] functionWithParameter.kt
public? final? [ResolvedTo(RAW_FIR)] interface I : R|kotlin/Any| {
public final? [ResolvedTo(RAW_FIR)] interface I : R|kotlin/Any| {
}
public? final? [ResolvedTo(RAW_FIR)] fun resolveMe([ResolvedTo(RAW_FIR)] param: I): <implicit> { LAZY_BLOCK }
COMPILER_REQUIRED_ANNOTATIONS:
FILE: [ResolvedTo(IMPORTS)] functionWithParameter.kt
public? final? [ResolvedTo(RAW_FIR)] interface I : R|kotlin/Any| {
public final? [ResolvedTo(RAW_FIR)] interface I : R|kotlin/Any| {
}
public? final? [ResolvedTo(COMPILER_REQUIRED_ANNOTATIONS)] fun resolveMe([ResolvedTo(COMPILER_REQUIRED_ANNOTATIONS)] param: I): <implicit> { LAZY_BLOCK }
COMPANION_GENERATION:
FILE: [ResolvedTo(IMPORTS)] functionWithParameter.kt
public? final? [ResolvedTo(RAW_FIR)] interface I : R|kotlin/Any| {
public final? [ResolvedTo(RAW_FIR)] interface I : R|kotlin/Any| {
}
public? final? [ResolvedTo(COMPANION_GENERATION)] fun resolveMe([ResolvedTo(COMPANION_GENERATION)] param: I): <implicit> { LAZY_BLOCK }
SUPER_TYPES:
FILE: [ResolvedTo(IMPORTS)] functionWithParameter.kt
public? final? [ResolvedTo(RAW_FIR)] interface I : R|kotlin/Any| {
public final? [ResolvedTo(RAW_FIR)] interface I : R|kotlin/Any| {
}
public? final? [ResolvedTo(SUPER_TYPES)] fun resolveMe([ResolvedTo(SUPER_TYPES)] param: I): <implicit> { LAZY_BLOCK }
TYPES:
FILE: [ResolvedTo(IMPORTS)] functionWithParameter.kt
public? final? [ResolvedTo(RAW_FIR)] interface I : R|kotlin/Any| {
public final? [ResolvedTo(RAW_FIR)] interface I : R|kotlin/Any| {
}
public? final? [ResolvedTo(TYPES)] fun resolveMe([ResolvedTo(TYPES)] param: R|I|): <implicit> { LAZY_BLOCK }
STATUS:
FILE: [ResolvedTo(IMPORTS)] functionWithParameter.kt
public? final? [ResolvedTo(RAW_FIR)] interface I : R|kotlin/Any| {
public final? [ResolvedTo(RAW_FIR)] interface I : R|kotlin/Any| {
}
public final [ResolvedTo(STATUS)] fun resolveMe([ResolvedTo(STATUS)] param: R|I|): <implicit> { LAZY_BLOCK }
EXPECT_ACTUAL_MATCHING:
FILE: [ResolvedTo(IMPORTS)] functionWithParameter.kt
public? final? [ResolvedTo(RAW_FIR)] interface I : R|kotlin/Any| {
public final? [ResolvedTo(RAW_FIR)] interface I : R|kotlin/Any| {
}
public final [ResolvedTo(EXPECT_ACTUAL_MATCHING)] fun resolveMe([ResolvedTo(EXPECT_ACTUAL_MATCHING)] param: R|I|): <implicit> { LAZY_BLOCK }
CONTRACTS:
FILE: [ResolvedTo(IMPORTS)] functionWithParameter.kt
public? final? [ResolvedTo(RAW_FIR)] interface I : R|kotlin/Any| {
public final? [ResolvedTo(RAW_FIR)] interface I : R|kotlin/Any| {
}
public final [ResolvedTo(CONTRACTS)] fun resolveMe([ResolvedTo(CONTRACTS)] param: R|I|): <implicit> { LAZY_BLOCK }
IMPLICIT_TYPES_BODY_RESOLVE:
FILE: [ResolvedTo(IMPORTS)] functionWithParameter.kt
public? final? [ResolvedTo(RAW_FIR)] interface I : R|kotlin/Any| {
public final? [ResolvedTo(RAW_FIR)] interface I : R|kotlin/Any| {
}
public final [ResolvedTo(IMPLICIT_TYPES_BODY_RESOLVE)] fun resolveMe([ResolvedTo(IMPLICIT_TYPES_BODY_RESOLVE)] param: R|I|): R|kotlin/Unit| {
^resolveMe Q|kotlin/Unit|
@@ -62,7 +62,7 @@ FILE: [ResolvedTo(IMPORTS)] functionWithParameter.kt
ANNOTATION_ARGUMENTS:
FILE: [ResolvedTo(IMPORTS)] functionWithParameter.kt
public? final? [ResolvedTo(RAW_FIR)] interface I : R|kotlin/Any| {
public final? [ResolvedTo(RAW_FIR)] interface I : R|kotlin/Any| {
}
public final [ResolvedTo(ANNOTATION_ARGUMENTS)] fun resolveMe([ResolvedTo(ANNOTATION_ARGUMENTS)] param: R|I|): R|kotlin/Unit| {
^resolveMe Q|kotlin/Unit|
@@ -70,7 +70,7 @@ FILE: [ResolvedTo(IMPORTS)] functionWithParameter.kt
BODY_RESOLVE:
FILE: [ResolvedTo(IMPORTS)] functionWithParameter.kt
public? final? [ResolvedTo(RAW_FIR)] interface I : R|kotlin/Any| {
public final? [ResolvedTo(RAW_FIR)] interface I : R|kotlin/Any| {
}
public final [ResolvedTo(BODY_RESOLVE)] fun resolveMe([ResolvedTo(BODY_RESOLVE)] param: R|I|): R|kotlin/Unit| {
^resolveMe Q|kotlin/Unit|