azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIR] Initialize public visibility for class-like declarations at FIR building phase if no modifier is presented

Browse Source 
Java resolving subsystem requires calculated visibility for correct disambiguation of supertypes.
But visibility remains `Unknown` for Kotlin class-like declarations during supertypes resolving because `STATUS` resolve phase is performed after `SUPER_TYPES` phase.
To fix the problem, the visibility should be initialized to public at the FIR building phase if no modifier is presented.

^KT-64127 Fixed
This commit is contained in:
Ivan Kochurkin
2023-12-13 23:57:19 +01:00
committed by Space Team
parent ee8d42532b
commit 69b9bfc3e0
915 changed files with 12362 additions and 12164 deletions
Download Patch File Download Diff File Expand all files Collapse all files
analysis/low-level-api-fir/testData/getOrBuildFir/wholeDeclaration/assignmentStatement.txt
Vendored
+1 -1
View File
@@ -24,7 +24,7 @@ FILE: [ResolvedTo(IMPORTS)] assignmentStatement.kts
println#(version#)
}
public? final? [ResolvedTo(RAW_FIR)] class NestedBuilder : Builder {
public final? [ResolvedTo(RAW_FIR)] class NestedBuilder : Builder {
public? [ResolvedTo(RAW_FIR)] [ContainingClassKey=NestedBuilder] constructor(): R|Builder.NestedBuilder| {
LAZY_super<Builder>
}
analysis/low-level-api-fir/testData/getOrBuildFir/wholeDeclaration/class.txt
Vendored
+2 -2
View File
@@ -14,7 +14,7 @@ public open [ResolvedTo(BODY_RESOLVE)] class Builder : R|kotlin/Any| {
public final [ResolvedTo(STATUS)] fun execute(): R|kotlin/Unit| { LAZY_BLOCK }
public? final? [ResolvedTo(RAW_FIR)] class NestedBuilder : Builder {
public final? [ResolvedTo(RAW_FIR)] class NestedBuilder : Builder {
public? [ResolvedTo(RAW_FIR)] [ContainingClassKey=NestedBuilder] constructor(): R|Builder.NestedBuilder| {
LAZY_super<Builder>
}
@@ -40,7 +40,7 @@ FILE: [ResolvedTo(IMPORTS)] class.kts
public final [ResolvedTo(STATUS)] fun execute(): R|kotlin/Unit| { LAZY_BLOCK }
public? final? [ResolvedTo(RAW_FIR)] class NestedBuilder : Builder {
public final? [ResolvedTo(RAW_FIR)] class NestedBuilder : Builder {
public? [ResolvedTo(RAW_FIR)] [ContainingClassKey=NestedBuilder] constructor(): R|Builder.NestedBuilder| {
LAZY_super<Builder>
}
analysis/low-level-api-fir/testData/getOrBuildFir/wholeDeclaration/function.txt
Vendored
+1 -1
View File
@@ -24,7 +24,7 @@ FILE: [ResolvedTo(IMPORTS)] function.kts
public final [ResolvedTo(STATUS)] fun execute(): R|kotlin/Unit| { LAZY_BLOCK }
public? final? [ResolvedTo(RAW_FIR)] class NestedBuilder : Builder {
public final? [ResolvedTo(RAW_FIR)] class NestedBuilder : Builder {
public? [ResolvedTo(RAW_FIR)] [ContainingClassKey=NestedBuilder] constructor(): R|Builder.NestedBuilder| {
LAZY_super<Builder>
}
analysis/low-level-api-fir/testData/getOrBuildFir/wholeDeclaration/lambdaAsSAMInterfaceWithAnnotation.txt
Vendored
+1 -1
View File
@@ -14,7 +14,7 @@ FIR FILE:
FILE: [ResolvedTo(IMPORTS)] lambdaAsSAMInterfaceWithAnnotation.kt
package foo
public? final? [ResolvedTo(RAW_FIR)] class Arg : R|kotlin/Any| {
public final? [ResolvedTo(RAW_FIR)] class Arg : R|kotlin/Any| {
public? [ResolvedTo(RAW_FIR)] [ContainingClassKey=Arg] constructor(): R|foo/Arg| {
LAZY_super<R|kotlin/Any|>
}
analysis/low-level-api-fir/testData/getOrBuildFir/wholeDeclaration/scriptInitializer.txt
Vendored
+1 -1
View File
@@ -40,7 +40,7 @@ FILE: [ResolvedTo(IMPORTS)] scriptInitializer.kts
println#(version#)
}
public? final? [ResolvedTo(RAW_FIR)] class NestedBuilder : Builder {
public final? [ResolvedTo(RAW_FIR)] class NestedBuilder : Builder {
public? [ResolvedTo(RAW_FIR)] [ContainingClassKey=NestedBuilder] constructor(): R|Builder.NestedBuilder| {
LAZY_super<Builder>
}
analysis/low-level-api-fir/testData/getOrBuildFir/wholeDeclaration/statement.txt
Vendored
+1 -1
View File
@@ -40,7 +40,7 @@ FILE: [ResolvedTo(IMPORTS)] statement.kts
println#(version#)
}
public? final? [ResolvedTo(RAW_FIR)] class NestedBuilder : Builder {
public final? [ResolvedTo(RAW_FIR)] class NestedBuilder : Builder {
public? [ResolvedTo(RAW_FIR)] [ContainingClassKey=NestedBuilder] constructor(): R|Builder.NestedBuilder| {
LAZY_super<Builder>
}