azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIR] Initialize public visibility for class-like declarations at FIR building phase if no modifier is presented

Browse Source 
Java resolving subsystem requires calculated visibility for correct disambiguation of supertypes.
But visibility remains `Unknown` for Kotlin class-like declarations during supertypes resolving because `STATUS` resolve phase is performed after `SUPER_TYPES` phase.
To fix the problem, the visibility should be initialized to public at the FIR building phase if no modifier is presented.

^KT-64127 Fixed
This commit is contained in:
Ivan Kochurkin
2023-12-13 23:57:19 +01:00
committed by Space Team
parent ee8d42532b
commit 69b9bfc3e0
915 changed files with 12362 additions and 12164 deletions
Download Patch File Download Diff File Expand all files Collapse all files
analysis/low-level-api-fir/testData/getOrBuildFir/declarations/initializerConflict.txt
Vendored
+1 -1
View File
@@ -17,7 +17,7 @@ FILE: [ResolvedTo(IMPORTS)] initializerConflict.kt
}
}
public? final [ResolvedTo(SUPER_TYPES)] typealias Foo = R|one/two/A|
public final [ResolvedTo(SUPER_TYPES)] typealias Foo = R|one/two/A|
public final [ResolvedTo(STATUS)] class Foo : R|kotlin/Any| {
public [ResolvedTo(STATUS)] [ContainingClassKey=Foo] constructor(): R|one/two/Foo| {
LAZY_super<R|kotlin/Any|>
analysis/low-level-api-fir/testData/getOrBuildFir/declarations/ktij23263.txt
Vendored
+2 -2
View File
@@ -7,11 +7,11 @@ FIR element rendered:
FIR FILE:
FILE: [ResolvedTo(IMPORTS)] ktij23263.kt
public? final? [ResolvedTo(RAW_FIR)] class InitOrderDemo : R|kotlin/Any| {
public final? [ResolvedTo(RAW_FIR)] class InitOrderDemo : R|kotlin/Any| {
public? [ResolvedTo(RAW_FIR)] [ContainingClassKey=InitOrderDemo] constructor([ResolvedTo(RAW_FIR)] name: String): R|InitOrderDemo| {
LAZY_super<R|kotlin/Any|>
}
<ERROR PROPERTY: Destructuring declarations are only allowed for local variables/values>
}
}