azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIR] Initialize public visibility for class-like declarations at FIR building phase if no modifier is presented

Browse Source 
Java resolving subsystem requires calculated visibility for correct disambiguation of supertypes.
But visibility remains `Unknown` for Kotlin class-like declarations during supertypes resolving because `STATUS` resolve phase is performed after `SUPER_TYPES` phase.
To fix the problem, the visibility should be initialized to public at the FIR building phase if no modifier is presented.

^KT-64127 Fixed
This commit is contained in:
Ivan Kochurkin
2023-12-13 23:57:19 +01:00
committed by Space Team
parent ee8d42532b
commit 69b9bfc3e0
915 changed files with 12362 additions and 12164 deletions
Download Patch File Download Diff File Expand all files Collapse all files
analysis/low-level-api-fir/testData/getOrBuildFir/calls/noReceiverOnLambda.txt
Vendored
+2 -2
View File
@@ -7,7 +7,7 @@ R|<local>/f2|.R|SubstitutionOverride<kotlin/Function1.invoke: R|kotlin/Unit|><In
FIR FILE:
FILE: [ResolvedTo(IMPORTS)] noReceiverOnLambda.kt
public? final? [ResolvedTo(RAW_FIR)] class SomeTest : R|kotlin/Any| {
public final? [ResolvedTo(RAW_FIR)] class SomeTest : R|kotlin/Any| {
public? [ResolvedTo(RAW_FIR)] [ContainingClassKey=SomeTest] constructor(): R|SomeTest| {
LAZY_super<R|kotlin/Any|>
}
@@ -15,4 +15,4 @@ FILE: [ResolvedTo(IMPORTS)] noReceiverOnLambda.kt
}
public final [ResolvedTo(BODY_RESOLVE)] fun dslSpeedTest([ResolvedTo(BODY_RESOLVE)] f2: R|SomeTest.() -> kotlin/Unit|): R|kotlin/Unit| {
R|<local>/f2|.R|SubstitutionOverride<kotlin/Function1.invoke: R|kotlin/Unit|><Inapplicable(INAPPLICABLE_ARGUMENTS_MAPPING_ERROR): kotlin/Function1.invoke>#|()
}
}
analysis/low-level-api-fir/testData/getOrBuildFir/calls/qualifiedCallInsideSuperCall5.txt
Vendored
+1 -1
View File
@@ -16,7 +16,7 @@ FILE: [ResolvedTo(IMPORTS)] qualifiedCallInsideSuperCall5.kt
public [ResolvedTo(CONTRACTS)] [ContainingClassKey=A] get(): R|kotlin/String|
}
public? final? [ResolvedTo(RAW_FIR)] object B : A {
public final? [ResolvedTo(RAW_FIR)] object B : A {
private [ResolvedTo(RAW_FIR)] [ContainingClassKey=B] constructor(): R|B| {
LAZY_super<A>
}
analysis/low-level-api-fir/testData/getOrBuildFir/calls/superType.txt
Vendored
+1 -1
View File
@@ -7,7 +7,7 @@ R|A|
FIR FILE:
FILE: [ResolvedTo(IMPORTS)] superType.kt
public? final? [ResolvedTo(SUPER_TYPES)] interface A : R|kotlin/Any| {
public final? [ResolvedTo(SUPER_TYPES)] interface A : R|kotlin/Any| {
}
public final [ResolvedTo(ANNOTATION_ARGUMENTS)] class C : R|A| {
public? [ResolvedTo(RAW_FIR)] [ContainingClassKey=C] constructor(): R|C| {
analysis/low-level-api-fir/testData/getOrBuildFir/calls/superTypeScript.txt
Vendored
+1 -1
View File
@@ -11,7 +11,7 @@ FILE: [ResolvedTo(IMPORTS)] superTypeScript.kts
SCRIPT: [ResolvedTo(TYPES)] <script-superTypeScript.kts>
[ResolvedTo(RAW_FIR)] lval args: R|kotlin/Array<kotlin/String>|
public? final? [ResolvedTo(SUPER_TYPES)] interface A : R|kotlin/Any| {
public final? [ResolvedTo(SUPER_TYPES)] interface A : R|kotlin/Any| {
}
public final [ResolvedTo(ANNOTATION_ARGUMENTS)] class C : R|A| {