From 68723125f2692f869f86fd220a2ef20ba82d0a90 Mon Sep 17 00:00:00 2001 From: Ivan Gavrilovic Date: Wed, 16 Oct 2019 18:08:37 +0100 Subject: [PATCH] Clean up KAPT incremental tests Remove redundant class to invalidate sources, because it is already handled in the KaptContext constructor. --- .../base/incremental/IncrementalKaptTest.kt | 18 +++++------------- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/plugins/kapt3/kapt3-base/test/org/jetbrains/kotlin/kapt3/base/incremental/IncrementalKaptTest.kt b/plugins/kapt3/kapt3-base/test/org/jetbrains/kotlin/kapt3/base/incremental/IncrementalKaptTest.kt index 819001fbf30..5fdb35a877f 100644 --- a/plugins/kapt3/kapt3-base/test/org/jetbrains/kotlin/kapt3/base/incremental/IncrementalKaptTest.kt +++ b/plugins/kapt3/kapt3-base/test/org/jetbrains/kotlin/kapt3/base/incremental/IncrementalKaptTest.kt @@ -76,12 +76,10 @@ class IncrementalKaptTest { }.build() KaptContext(optionsForSecondRun, true, logger).use { - val sourcesToReprocess = - it.cacheManager!!.invalidateAndGetDirtyFiles(optionsForSecondRun.changedFiles, emptyList()) assertFalse(outputDir.resolve("test/UserGenerated.java").exists()) it.doAnnotationProcessing( - optionsForSecondRun.collectJavaSourceFiles(sourcesToReprocess), listOf(SimpleProcessor().toIsolating()) + optionsForSecondRun.collectJavaSourceFiles(it.sourcesToReprocess), listOf(SimpleProcessor().toIsolating()) ) } @@ -90,10 +88,8 @@ class IncrementalKaptTest { sourcesDir.resolve("User.java").delete() KaptContext(optionsForSecondRun, true, logger).use { - val sourcesToReprocess = it.cacheManager!!.invalidateAndGetDirtyFiles(optionsForSecondRun.changedFiles, emptyList()) - it.doAnnotationProcessing( - optionsForSecondRun.collectJavaSourceFiles(sourcesToReprocess), listOf(SimpleProcessor().toIsolating()) + optionsForSecondRun.collectJavaSourceFiles(it.sourcesToReprocess), listOf(SimpleProcessor().toIsolating()) ) } @@ -150,12 +146,10 @@ class IncrementalKaptTest { }.build() KaptContext(optionsForSecondRun, true, logger).use { - val sourcesToReprocess = - it.cacheManager!!.invalidateAndGetDirtyFiles(optionsForSecondRun.changedFiles, emptyList()) assertFalse(outputDir.resolve("test/UserGenerated.java").exists()) it.doAnnotationProcessing( - optionsForSecondRun.collectJavaSourceFiles(sourcesToReprocess), listOf(SimpleGeneratingIfTypeDoesNotExist().toIsolating()) + optionsForSecondRun.collectJavaSourceFiles(it.sourcesToReprocess), listOf(SimpleGeneratingIfTypeDoesNotExist().toIsolating()) ) } @@ -209,15 +203,13 @@ class IncrementalKaptTest { }.build() KaptContext(optionsForSecondRun, true, logger).use { - val sourcesToReprocess = - it.cacheManager!!.invalidateAndGetDirtyFiles(optionsForSecondRun.changedFiles, emptyList()) - assertEquals(SourcesToReprocess.FullRebuild, sourcesToReprocess) + assertEquals(SourcesToReprocess.FullRebuild, it.sourcesToReprocess) // check output dir is empty assertEquals(listOf(outputDir), outputDir.walkTopDown().toList()) it.doAnnotationProcessing( - optionsForSecondRun.collectJavaSourceFiles(sourcesToReprocess), + optionsForSecondRun.collectJavaSourceFiles(it.sourcesToReprocess), listOf(DynamicProcessor(RuntimeProcType.NON_INCREMENTAL).toDynamic()) ) }