[NI] Rename NewConstraintSystem.diagnostics to errors

compiler/resolution/src/org/jetbrains/kotlin/resolve/calls/components/KotlinCallCompleter.kt

@@ -236,7 +236,7 @@ class KotlinCallCompleter(
             }
         }
 
-        constraintSystem.diagnostics.forEach(diagnosticsHolder::addError)
+        constraintSystem.errors.forEach(diagnosticsHolder::addError)
     }
 
     private fun prepareCandidateForCompletion(

compiler/resolution/src/org/jetbrains/kotlin/resolve/calls/inference/NewConstraintSystem.kt

@@ -24,7 +24,7 @@ import org.jetbrains.kotlin.resolve.calls.inference.model.ConstraintSystemError
 
 interface NewConstraintSystem {
     val hasContradiction: Boolean
-    val diagnostics: List<ConstraintSystemError>
+    val errors: List<ConstraintSystemError>
 
     fun getBuilder(): ConstraintSystemBuilder
 

compiler/resolution/src/org/jetbrains/kotlin/resolve/calls/inference/model/NewConstraintSystemImpl.kt

@@ -73,7 +73,7 @@ class NewConstraintSystemImpl(
         }
     }
 
-    override val diagnostics: List<ConstraintSystemError>
+    override val errors: List<ConstraintSystemError>
         get() = storage.errors
 
     override fun getBuilder() = apply { checkState(State.BUILDING, State.COMPLETION, State.TRANSACTION) }

compiler/resolution/src/org/jetbrains/kotlin/resolve/calls/model/ResolutionCandidate.kt

@@ -166,7 +166,7 @@ class KotlinResolutionCandidate(
         get() {
             processParts(stopOnFirstError = false)
 
-            val systemApplicability = getResultApplicability(getSystem().diagnostics)
+            val systemApplicability = getResultApplicability(getSystem().errors)
             return maxOf(currentApplicability, systemApplicability, variableApplicability)
         }