FIR: Fix FP error on a call to constructor of a private inner class

Do not check dispatch receiver applicability when checking visibility
for containing class of a callee constructor

analysis/low-level-api-fir/tests/org/jetbrains/kotlin/analysis/low/level/api/fir/diagnostic/compiler/based/DiagnosisCompilerTestFE10TestdataTestGenerated.java

@@ -33496,6 +33496,12 @@ public class DiagnosisCompilerTestFE10TestdataTestGenerated extends AbstractDiag
                 KtTestUtil.assertAllTestsPresentByMetadataWithExcluded(this.getClass(), new File("compiler/testData/diagnostics/tests/visibility"), Pattern.compile("^(.+)\\.kt$"), Pattern.compile("^(.+)\\.fir\\.kts?$"), true);
             }
 
+            @Test
+            @TestMetadata("innerConstructorThroughSubclass.kt")
+            public void testInnerConstructorThroughSubclass() throws Exception {
+                runTest("compiler/testData/diagnostics/tests/visibility/innerConstructorThroughSubclass.kt");
+            }
+
             @Test
             @TestMetadata("innerNestedAndAnonymousClasses.kt")
             public void testInnerNestedAndAnonymousClasses() throws Exception {

compiler/fir/analysis-tests/tests-gen/org/jetbrains/kotlin/test/runners/FirOldFrontendDiagnosticsTestGenerated.java

@@ -33496,6 +33496,12 @@ public class FirOldFrontendDiagnosticsTestGenerated extends AbstractFirDiagnosti
                 KtTestUtil.assertAllTestsPresentByMetadataWithExcluded(this.getClass(), new File("compiler/testData/diagnostics/tests/visibility"), Pattern.compile("^(.+)\\.kt$"), Pattern.compile("^(.+)\\.fir\\.kts?$"), true);
             }
 
+            @Test
+            @TestMetadata("innerConstructorThroughSubclass.kt")
+            public void testInnerConstructorThroughSubclass() throws Exception {
+                runTest("compiler/testData/diagnostics/tests/visibility/innerConstructorThroughSubclass.kt");
+            }
+
             @Test
             @TestMetadata("innerNestedAndAnonymousClasses.kt")
             public void testInnerNestedAndAnonymousClasses() throws Exception {

compiler/fir/analysis-tests/tests-gen/org/jetbrains/kotlin/test/runners/FirOldFrontendDiagnosticsWithLightTreeTestGenerated.java

@@ -33496,6 +33496,12 @@ public class FirOldFrontendDiagnosticsWithLightTreeTestGenerated extends Abstrac
                 KtTestUtil.assertAllTestsPresentByMetadataWithExcluded(this.getClass(), new File("compiler/testData/diagnostics/tests/visibility"), Pattern.compile("^(.+)\\.kt$"), Pattern.compile("^(.+)\\.fir\\.kts?$"), true);
             }
 
+            @Test
+            @TestMetadata("innerConstructorThroughSubclass.kt")
+            public void testInnerConstructorThroughSubclass() throws Exception {
+                runTest("compiler/testData/diagnostics/tests/visibility/innerConstructorThroughSubclass.kt");
+            }
+
             @Test
             @TestMetadata("innerNestedAndAnonymousClasses.kt")
             public void testInnerNestedAndAnonymousClasses() throws Exception {

compiler/fir/resolve/src/org/jetbrains/kotlin/fir/resolve/calls/ResolutionStages.kt

@@ -9,7 +9,9 @@ import org.jetbrains.kotlin.config.LanguageFeature
 import org.jetbrains.kotlin.descriptors.Modality
 import org.jetbrains.kotlin.fir.FirVisibilityChecker
 import org.jetbrains.kotlin.fir.declarations.*
-import org.jetbrains.kotlin.fir.declarations.utils.*
+import org.jetbrains.kotlin.fir.declarations.utils.isInfix
+import org.jetbrains.kotlin.fir.declarations.utils.isOperator
+import org.jetbrains.kotlin.fir.declarations.utils.modality
 import org.jetbrains.kotlin.fir.expressions.*
 import org.jetbrains.kotlin.fir.languageVersionSettings
 import org.jetbrains.kotlin.fir.matchingParameterFunctionType
@@ -516,7 +518,8 @@ internal object CheckVisibility : CheckerStage() {
         val symbol = candidate.symbol
         val declaration = symbol.fir
         if (declaration is FirMemberDeclaration) {
-            if (!checkVisibility(declaration, sink, candidate, visibilityChecker)) {
+            if (!visibilityChecker.isVisible(declaration, candidate)) {
+                sink.yieldDiagnostic(VisibilityError)
                 return
             }
         }
@@ -529,23 +532,13 @@ internal object CheckVisibility : CheckerStage() {
                 if (classSymbol.fir.classKind.isSingleton) {
                     sink.yieldDiagnostic(VisibilityError)
                 }
-                checkVisibility(classSymbol.fir, sink, candidate, visibilityChecker)
+
+                if (!visibilityChecker.isVisible(declaration, candidate.callInfo, dispatchReceiverValue = null)) {
+                    sink.yieldDiagnostic(VisibilityError)
+                }
             }
         }
     }
-
-    private suspend fun <T : FirMemberDeclaration> checkVisibility(
-        declaration: T,
-        sink: CheckerSink,
-        candidate: Candidate,
-        visibilityChecker: FirVisibilityChecker
-    ): Boolean {
-        if (!visibilityChecker.isVisible(declaration, candidate)) {
-            sink.yieldDiagnostic(VisibilityError)
-            return false
-        }
-        return true
-    }
 }
 
 internal object CheckLowPriorityInOverloadResolution : CheckerStage() {

compiler/testData/diagnostics/tests/visibility/innerConstructorThroughSubclass.kt

@@ -0,0 +1,12 @@
+// FIR_IDENTICAL
+// SKIP_TXT
+
+sealed class Outer {
+    class NestedSubClass : Outer() {
+        fun foo() {
+            Inner()
+        }
+    }
+
+    private inner class Inner
+}

compiler/tests-common-new/tests-gen/org/jetbrains/kotlin/test/runners/DiagnosticTestGenerated.java

@@ -33586,6 +33586,12 @@ public class DiagnosticTestGenerated extends AbstractDiagnosticTest {
                 KtTestUtil.assertAllTestsPresentByMetadataWithExcluded(this.getClass(), new File("compiler/testData/diagnostics/tests/visibility"), Pattern.compile("^(.*)\\.kts?$"), Pattern.compile("^(.+)\\.fir\\.kts?$"), true);
             }
 
+            @Test
+            @TestMetadata("innerConstructorThroughSubclass.kt")
+            public void testInnerConstructorThroughSubclass() throws Exception {
+                runTest("compiler/testData/diagnostics/tests/visibility/innerConstructorThroughSubclass.kt");
+            }
+
             @Test
             @TestMetadata("innerNestedAndAnonymousClasses.kt")
             public void testInnerNestedAndAnonymousClasses() throws Exception {