FIR: report MANY_INTERFACES_MEMBER_NOT_IMPLEMENTED also on interfaces

compiler/fir/checkers/src/org/jetbrains/kotlin/fir/analysis/checkers/declaration/FirNotImplementedOverrideChecker.kt

@@ -37,7 +37,7 @@ object FirNotImplementedOverrideChecker : FirClassChecker() {
         val sourceKind = source.kind
         if (sourceKind is FirFakeSourceElementKind && sourceKind != FirFakeSourceElementKind.EnumInitializer) return
         val modality = declaration.modality()
-        if (modality == Modality.ABSTRACT || modality == Modality.SEALED) return
+        val canHaveAbstractDeclarations = modality == Modality.ABSTRACT || modality == Modality.SEALED
         if (declaration is FirRegularClass && declaration.isExpect) return
         val classKind = declaration.classKind
         if (classKind == ClassKind.ANNOTATION_CLASS || classKind == ClassKind.ENUM_CLASS) return
@@ -67,7 +67,7 @@ object FirNotImplementedOverrideChecker : FirClassChecker() {
             classScope.processPropertiesByName(name, ::collectSymbol)
         }
 
-        if (notImplementedSymbols.isNotEmpty()) {
+        if (!canHaveAbstractDeclarations && notImplementedSymbols.isNotEmpty()) {
             val notImplemented = notImplementedSymbols.first().unwrapFakeOverrides().fir
             if (notImplemented.isFromInterfaceOrEnum(context)) {
                 reporter.reportOn(source, ABSTRACT_MEMBER_NOT_IMPLEMENTED, declaration, notImplemented, context)
@@ -75,7 +75,7 @@ object FirNotImplementedOverrideChecker : FirClassChecker() {
                 reporter.reportOn(source, ABSTRACT_CLASS_MEMBER_NOT_IMPLEMENTED, declaration, notImplemented, context)
             }
         }
-        if (invisibleSymbols.isNotEmpty()) {
+        if (!canHaveAbstractDeclarations && invisibleSymbols.isNotEmpty()) {
             val invisible = invisibleSymbols.first().fir
             if (context.session.languageVersionSettings.supportsFeature(LanguageFeature.ProhibitInvisibleAbstractMethodsInSuperclasses)) {
                 reporter.reportOn(source, INVISIBLE_ABSTRACT_MEMBER_FROM_SUPER, declaration, invisible, context)

compiler/testData/diagnostics/tests/declarationChecks/sealedOnMembers.fir.kt

@@ -8,7 +8,7 @@ interface B {
     abstract var bar: Unit
 }
 
-interface C : A, B
+<!MANY_INTERFACES_MEMBER_NOT_IMPLEMENTED!>interface C<!> : A, B
 
 abstract class D(sealed var x: Int) {
     abstract var y: Unit

compiler/testData/diagnostics/tests/delegation/clashes/propertyTypeMismatch.fir.kt

@@ -34,7 +34,7 @@ abstract class Test1 : IStr by CStr(), IInt
 
 abstract class Test2 : IStr, IInt by CInt()
 
-abstract class Test3 : IStr by CStr(), IInt by CInt()
+abstract <!MANY_IMPL_MEMBER_NOT_IMPLEMENTED!>class Test3<!> : IStr by CStr(), IInt by CInt()
 
 abstract class Test4 : IStr by CStr(), IGeneric<String>
 
@@ -49,9 +49,9 @@ abstract class Test8 : IGeneric<String> by CGeneric<String>(), IInt
 // Can't test right now due to https://youtrack.jetbrains.com/issue/KT-10258
 // abstract class Test9 : IGeneric<String> by CGeneric<String>(), IGeneric<Int>
 
-abstract class Test10 : IInt by CInt(), IStr by CStr(), IAny by CAny()
+abstract <!MANY_IMPL_MEMBER_NOT_IMPLEMENTED!>class Test10<!> : IInt by CInt(), IStr by CStr(), IAny by CAny()
 
-abstract class Test11 : IInt, IStr by CStr(), IAny by CAny()
+abstract <!DELEGATED_MEMBER_HIDES_SUPERTYPE_OVERRIDE!>class Test11<!> : IInt, IStr by CStr(), IAny by CAny()
 
 abstract class Test12 : IInt, IStr, IAny by CAny()
 

compiler/testData/diagnostics/tests/delegation/clashes/returnTypeMismatch.fir.kt

@@ -36,7 +36,7 @@ abstract class Test1 : IStr by CStr(), IInt
 
 abstract class Test2 : IStr, IInt by CInt()
 
-abstract class Test3 : IStr by CStr(), IInt by CInt()
+abstract <!MANY_IMPL_MEMBER_NOT_IMPLEMENTED!>class Test3<!> : IStr by CStr(), IInt by CInt()
 
 abstract class Test4 : IStr by CStr(), IGeneric<String>
 
@@ -51,9 +51,9 @@ abstract class Test8 : IGeneric<String> by CGeneric<String>(), IInt
 // Can't test due to https://youtrack.jetbrains.com/issue/KT-10258
 // abstract class Test9 : IGeneric<String> by CGeneric<String>(), IGeneric<Int>
 
-abstract class Test10 : IInt by CInt(), IStr by CStr(), IAny by CAny()
+abstract <!MANY_IMPL_MEMBER_NOT_IMPLEMENTED!>class Test10<!> : IInt by CInt(), IStr by CStr(), IAny by CAny()
 
-abstract class Test11 : IInt, IStr by CStr(), IAny by CAny()
+abstract <!DELEGATED_MEMBER_HIDES_SUPERTYPE_OVERRIDE!>class Test11<!> : IInt, IStr by CStr(), IAny by CAny()
 
 abstract class Test12 : IInt, IStr, IAny by CAny()
 

compiler/testData/diagnostics/tests/java8Overrides/defaultVsAbstract.fir.kt

@@ -1,13 +0,0 @@
-interface ILeft {
-    fun foo() {}
-}
-
-interface IRight {
-    fun foo()
-}
-
-interface IDerived : ILeft, IRight
-
-<!MANY_INTERFACES_MEMBER_NOT_IMPLEMENTED!>class CDerived<!> : ILeft, IRight
-
-abstract class ADerived : ILeft, IRight

compiler/testData/diagnostics/tests/java8Overrides/defaultVsAbstract.kt

@@ -1,3 +1,4 @@
+// FIR_IDENTICAL
 interface ILeft {
     fun foo() {}
 }

compiler/testData/diagnostics/testsWithStdLib/annotations/jvmDefault/superCallAmbiguity.fir.kt

@@ -10,9 +10,9 @@ interface B{
     }
 }
 
-interface AB: A, B
+<!MANY_INTERFACES_MEMBER_NOT_IMPLEMENTED!>interface AB<!>: A, B
 
-interface BA: B, A
+<!MANY_INTERFACES_MEMBER_NOT_IMPLEMENTED!>interface BA<!>: B, A
 
 
 interface C : A, B {

compiler/testData/diagnostics/testsWithStdLib/annotations/jvmDefault/superCallAmbiguity2.fir.kt

@@ -9,9 +9,9 @@ interface B{
     }
 }
 
-interface AB: A, B
+<!MANY_INTERFACES_MEMBER_NOT_IMPLEMENTED!>interface AB<!>: A, B
 
-interface BA: B, A
+<!MANY_INTERFACES_MEMBER_NOT_IMPLEMENTED!>interface BA<!>: B, A
 
 class C : A, B {
     override fun test() {

compiler/testData/diagnostics/testsWithStdLib/annotations/jvmDefault/superCallAmbiguity3.fir.kt

@@ -9,8 +9,8 @@ interface A {
 interface B{
     fun test()
 }
-interface AB : A, B
+<!MANY_INTERFACES_MEMBER_NOT_IMPLEMENTED!>interface AB<!> : A, B
-interface BA : B, A
+<!MANY_INTERFACES_MEMBER_NOT_IMPLEMENTED!>interface BA<!> : B, A
 
 class C : A, B {
     override fun test() {