From 657dd314930e63764e1bcdc976867de0605c4d47 Mon Sep 17 00:00:00 2001 From: Anton Lakotka Date: Sun, 15 Oct 2023 22:50:19 +0200 Subject: [PATCH] [Gradle] Remove up-to-date checks in CleanNativeDistributionCommonizer Gradle doesn't track removed files in OutputDirectory after task execution. So if task removed some files and if these files are added back the task would be still UP-TO-DATE. Which is incorrect. Executing clean task on empty directory is the same as check that directory is empty. Therefore, this up-to-date check can be removed. ^KT-62611 Verification Pending --- .../kotlin/gradle/targets/native/internal/CommonizerTasks.kt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libraries/tools/kotlin-gradle-plugin/src/common/kotlin/org/jetbrains/kotlin/gradle/targets/native/internal/CommonizerTasks.kt b/libraries/tools/kotlin-gradle-plugin/src/common/kotlin/org/jetbrains/kotlin/gradle/targets/native/internal/CommonizerTasks.kt index 86f46a68756..4ae4f0cb8cc 100644 --- a/libraries/tools/kotlin-gradle-plugin/src/common/kotlin/org/jetbrains/kotlin/gradle/targets/native/internal/CommonizerTasks.kt +++ b/libraries/tools/kotlin-gradle-plugin/src/common/kotlin/org/jetbrains/kotlin/gradle/targets/native/internal/CommonizerTasks.kt @@ -10,7 +10,7 @@ import org.gradle.api.Project import org.gradle.api.Task import org.gradle.api.file.FileSystemOperations import org.gradle.api.provider.Property -import org.gradle.api.tasks.OutputDirectory +import org.gradle.api.tasks.Internal import org.gradle.api.tasks.TaskAction import org.gradle.api.tasks.TaskProvider import org.gradle.work.DisableCachingByDefault @@ -175,7 +175,7 @@ internal abstract class CleanNativeDistributionCommonizerTask : DefaultTask() { @get:Inject abstract val fileSystemOperations: FileSystemOperations - @get:OutputDirectory + @get:Internal abstract val commonizerDirectory: Property @TaskAction