From 643cb0a5d421b68e0372124cd33092a46442c8f6 Mon Sep 17 00:00:00 2001 From: "Pavel V. Talanov" Date: Tue, 22 Sep 2015 16:33:51 +0300 Subject: [PATCH] js.frontend: Drop usages of KotlinBuiltIns.getInstance() --- .../kotlin/js/analyze/TopDownAnalyzerFacadeForJS.java | 4 ++-- .../src/org/jetbrains/kotlin/js/config/Config.java | 4 ++-- .../jetbrains/kotlin/js/resolve/nativeAnnotationCheckers.kt | 6 ++++-- 3 files changed, 8 insertions(+), 6 deletions(-) diff --git a/js/js.frontend/src/org/jetbrains/kotlin/js/analyze/TopDownAnalyzerFacadeForJS.java b/js/js.frontend/src/org/jetbrains/kotlin/js/analyze/TopDownAnalyzerFacadeForJS.java index abaf86be75c..e573dab947d 100644 --- a/js/js.frontend/src/org/jetbrains/kotlin/js/analyze/TopDownAnalyzerFacadeForJS.java +++ b/js/js.frontend/src/org/jetbrains/kotlin/js/analyze/TopDownAnalyzerFacadeForJS.java @@ -18,7 +18,6 @@ package org.jetbrains.kotlin.js.analyze; import com.google.common.collect.ImmutableList; import org.jetbrains.annotations.NotNull; -import org.jetbrains.kotlin.builtins.KotlinBuiltIns; import org.jetbrains.kotlin.context.ContextPackage; import org.jetbrains.kotlin.context.ModuleContext; import org.jetbrains.kotlin.context.MutableModuleContext; @@ -28,6 +27,7 @@ import org.jetbrains.kotlin.descriptors.impl.ModuleDescriptorImpl; import org.jetbrains.kotlin.frontend.js.di.DiPackage; import org.jetbrains.kotlin.js.analyzer.JsAnalysisResult; import org.jetbrains.kotlin.js.config.Config; +import org.jetbrains.kotlin.js.resolve.JsPlatform; import org.jetbrains.kotlin.name.Name; import org.jetbrains.kotlin.platform.PlatformToKotlinClassMap; import org.jetbrains.kotlin.psi.JetFile; @@ -83,7 +83,7 @@ public final class TopDownAnalyzerFacadeForJS { List allDependencies = new ArrayList(); allDependencies.add(module); allDependencies.addAll(config.getModuleDescriptors()); - allDependencies.add(KotlinBuiltIns.getInstance().getBuiltInsModule()); + allDependencies.add(JsPlatform.INSTANCE$.getBuiltIns().getBuiltInsModule()); return allDependencies; } diff --git a/js/js.frontend/src/org/jetbrains/kotlin/js/config/Config.java b/js/js.frontend/src/org/jetbrains/kotlin/js/config/Config.java index f1898b5cfb5..857b778df87 100644 --- a/js/js.frontend/src/org/jetbrains/kotlin/js/config/Config.java +++ b/js/js.frontend/src/org/jetbrains/kotlin/js/config/Config.java @@ -24,10 +24,10 @@ import kotlin.Unit; import kotlin.jvm.functions.Function1; import org.jetbrains.annotations.NotNull; import org.jetbrains.annotations.Nullable; -import org.jetbrains.kotlin.builtins.KotlinBuiltIns; import org.jetbrains.kotlin.descriptors.PackageFragmentProvider; import org.jetbrains.kotlin.descriptors.impl.ModuleDescriptorImpl; import org.jetbrains.kotlin.js.analyze.TopDownAnalyzerFacadeForJS; +import org.jetbrains.kotlin.js.resolve.JsPlatform; import org.jetbrains.kotlin.name.Name; import org.jetbrains.kotlin.psi.JetFile; import org.jetbrains.kotlin.serialization.js.KotlinJavascriptSerializationUtil; @@ -166,7 +166,7 @@ public abstract class Config { } private static void setDependencies(ModuleDescriptorImpl module, List modules) { - module.setDependencies(KotlinPackage.plus(modules, KotlinBuiltIns.getInstance().getBuiltInsModule())); + module.setDependencies(KotlinPackage.plus(modules, JsPlatform.INSTANCE$.getBuiltIns().getBuiltInsModule())); } @NotNull diff --git a/js/js.frontend/src/org/jetbrains/kotlin/js/resolve/nativeAnnotationCheckers.kt b/js/js.frontend/src/org/jetbrains/kotlin/js/resolve/nativeAnnotationCheckers.kt index ba24ccf4271..dcdfb6163e9 100644 --- a/js/js.frontend/src/org/jetbrains/kotlin/js/resolve/nativeAnnotationCheckers.kt +++ b/js/js.frontend/src/org/jetbrains/kotlin/js/resolve/nativeAnnotationCheckers.kt @@ -30,6 +30,7 @@ import org.jetbrains.kotlin.psi.JetNamedFunction import org.jetbrains.kotlin.resolve.BindingContext import org.jetbrains.kotlin.resolve.DeclarationChecker import org.jetbrains.kotlin.resolve.DescriptorUtils +import org.jetbrains.kotlin.resolve.descriptorUtil.builtIns import org.jetbrains.kotlin.types.TypeUtils import org.jetbrains.kotlin.types.typeUtil.isSubtypeOf @@ -72,10 +73,11 @@ private abstract class AbstractNativeIndexerChecker( override fun additionalCheck(declaration: JetNamedFunction, descriptor: FunctionDescriptor, diagnosticHolder: DiagnosticSink) { val parameters = descriptor.getValueParameters() + val builtIns = descriptor.builtIns if (parameters.size() > 0) { val firstParamClassDescriptor = DescriptorUtils.getClassDescriptorForType(parameters.get(0).getType()) - if (firstParamClassDescriptor != KotlinBuiltIns.getInstance().getString() && - !DescriptorUtils.isSubclass(firstParamClassDescriptor, KotlinBuiltIns.getInstance().getNumber()) + if (firstParamClassDescriptor != builtIns.string && + !DescriptorUtils.isSubclass(firstParamClassDescriptor, builtIns.number) ) { diagnosticHolder.report(ErrorsJs.NATIVE_INDEXER_KEY_SHOULD_BE_STRING_OR_NUMBER.on(declaration.getValueParameters().firstOrNull(), indexerKind)) }