[FIR] Report missing DEPRECATION on fake sources

#KT-60682

compiler/fir/checkers/src/org/jetbrains/kotlin/fir/analysis/checkers/expression/FirDeprecationChecker.kt

@@ -38,30 +38,32 @@ import org.jetbrains.kotlin.resolve.deprecation.DeprecationLevelValue
 
 object FirDeprecationChecker : FirBasicExpressionChecker() {
 
-    private val allowedSourceKinds = setOf(
+    private val filteredSourceKinds: Set<KtFakeSourceElementKind> = setOf(
-        KtRealSourceElementKind,
+        KtFakeSourceElementKind.PropertyFromParameter,
-        KtFakeSourceElementKind.DesugaredIncrementOrDecrement
+        KtFakeSourceElementKind.DataClassGeneratedMembers
     )
 
     override fun check(expression: FirStatement, context: CheckerContext, reporter: DiagnosticReporter) {
-        if (!allowedSourceKinds.contains(expression.source?.kind)) return
+        if (expression.source?.kind in filteredSourceKinds) return
         if (expression is FirAnnotation) return // checked by FirDeprecatedTypeChecker
         if (expression.isLhsOfAssignment(context)) return
 
         val calleeReference = expression.calleeReference ?: return
         val resolvedReference = calleeReference.resolved ?: return
         val referencedSymbol = resolvedReference.resolvedSymbol
+        val source = resolvedReference.source ?: expression.source
 
         if (expression is FirDelegatedConstructorCall) {
             // Report deprecations on the constructor itself, not on the declaring class as that will be handled by FirDeprecatedTypeChecker
             val constructorOnlyDeprecation = referencedSymbol.getDeprecation(context.session, expression) ?: return
             val isTypealiasExpansion = expression.constructedTypeRef.firClassLike(context.session)?.symbol is FirTypeAliasSymbol
+
             reportApiStatus(
-                resolvedReference.source, referencedSymbol, isTypealiasExpansion,
+                source, referencedSymbol, isTypealiasExpansion,
                 constructorOnlyDeprecation, reporter, context
             )
         } else {
-            reportApiStatusIfNeeded(resolvedReference.source, referencedSymbol, context, reporter, callSite = expression)
+            reportApiStatusIfNeeded(source, referencedSymbol, context, reporter, callSite = expression)
         }
     }
 

compiler/fir/raw-fir/psi2fir/src/org/jetbrains/kotlin/fir/builder/PsiRawFirBuilder.kt

@@ -2025,7 +2025,7 @@ open class PsiRawFirBuilder(
 
                         if (hasDelegate()) {
                             fun extractDelegateExpression() =
-                                buildOrLazyExpression(this@toFirProperty.toFirSourceElement(KtFakeSourceElementKind.WrappedDelegate)) {
+                                buildOrLazyExpression(this@toFirProperty.delegate?.expression?.toFirSourceElement(KtFakeSourceElementKind.WrappedDelegate)) {
                                     this@toFirProperty.delegate?.expression?.let { expression ->
                                         expression.toFirExpression("Should have delegate")
                                     } ?: buildErrorExpression {

compiler/testData/diagnostics/tests/deprecated/componentUsage.fir.kt

@@ -1,11 +0,0 @@
-// !DIAGNOSTICS: -UNUSED_VARIABLE
-
-class Data {
-    @Deprecated("text")
-    operator fun component1(): String = throw Exception()
-    operator fun component2(): String = throw Exception()
-}
-
-fun use() {
-    val (x, y) = Data()
-}

compiler/testData/diagnostics/tests/deprecated/componentUsage.kt

@@ -1,3 +1,4 @@
+// FIR_IDENTICAL
 // !DIAGNOSTICS: -UNUSED_VARIABLE
 
 class Data {

compiler/testData/diagnostics/tests/deprecated/deprecatedConstructorProperty.kt

@@ -14,3 +14,5 @@ fun use() {
     A("").<!DEPRECATION!>s<!>
     A(42).<!DEPRECATION!>s<!>
 }
+
+data class DC(@Deprecated("") val a: String)

compiler/testData/diagnostics/tests/deprecated/iteratorUsage.fir.kt

@@ -19,6 +19,6 @@ class Iter2 {
 }
 
 fun use() {
-    for (x in Iter()) {}
+    <!DEPRECATION!>for (x in Iter()) {}<!>
-    for (x in Iter2()) {}
+    <!DEPRECATION, DEPRECATION!>for (x in Iter2()) {}<!>
 }

compiler/testData/diagnostics/tests/deprecated/propertyUsage.fir.kt

@@ -1,4 +1,7 @@
 // !DIAGNOSTICS: -UNUSED_EXPRESSION
+// IGNORE_DIAGNOSTIC_API
+// IGNORE_REVERSED_RESOLVE
+// ^KT-61491
 
 import kotlin.reflect.KProperty
 
@@ -17,8 +20,8 @@ class PropertyHolder {
     @Deprecated("text")
     var name = "String"
 
-    val valDelegate by Delegate()
+    val valDelegate by <!DEPRECATION!>Delegate<!>()
-    var varDelegate by Delegate()
+    var varDelegate by <!DEPRECATION, DEPRECATION!>Delegate<!>()
 
     public val test1: String = ""
         @Deprecated("val-getter") get

compiler/testData/diagnostics/tests/deprecated/propertyUsage.kt

@@ -1,4 +1,7 @@
 // !DIAGNOSTICS: -UNUSED_EXPRESSION
+// IGNORE_DIAGNOSTIC_API
+// IGNORE_REVERSED_RESOLVE
+// ^KT-61491
 
 import kotlin.reflect.KProperty
 

compiler/testData/diagnostics/tests/deprecated/propertyWithInvoke.fir.kt

@@ -1,6 +0,0 @@
-@Deprecated("No")
-val f: () -> Unit = {}
-
-fun test() {
-    f()
-}

compiler/testData/diagnostics/tests/deprecated/propertyWithInvoke.kt

@@ -1,3 +1,4 @@
+// FIR_IDENTICAL
 @Deprecated("No")
 val f: () -> Unit = {}