[FIR] KT-55503: Prefer members-extensions over @HidesMembers extensions

Passing `EXTENSION_RECEIVER` when processing `noReceiver`
looks like a mistake in general. This change is backed
by the `hidesMembers` and
`memberWithHidesMemberAnnotationVsMemberWithout` tests.

The exact reason with `memberWithHidesMemberAnnotationVsMemberWithout`
is that it first checks `@HidesMembers` candidates,
only takes the `kotlin/collections/Iterable<T>.forEach`,
but then yields `InapplicableWrongReceiver`,
because `explicitReceiverKind = EXTENSION_RECEIVER`
(which is strange, because we really don't have an explicit receiver).
Then we visit the same scope once more (now for all candidates)
and take 2 functions:

- `kotlin/collections/Iterable<T>.forEach`
- `kotlin/sequence/Sequence<T>.forEach`

...and they both result in `RESOLVED`,
because this time `explicitReceiverKind = NO_EXPLICIT_RECEIVER`.

This change ensures the first candidate we see
while checking `@HidesMembers` is taken as `RESOLVED`.

^KT-55503 Fixed
This commit is contained in:
Nikolay Lunyak
2023-01-31 10:57:29 +02:00
committed by Space Team
parent 906b16b41e
commit 603b46e531
4 changed files with 21 additions and 26 deletions
+1 -2
View File
@@ -25,8 +25,7 @@ import sample.pack.*
fun box() {
return with(A()) {
with(B()) {
// K1 resolves to A::B.check
// K2 - to ::A.check
// Both K1 & K2 resolve to A::B.check
forEach()
}
}