Intention / inspection for unnecessary lateinit #KT-13011 Fixed

(cherry picked from commit 45d82f1)

idea/testData/intentions/removeUnnecessaryLateinit/.intention

@@ -0,0 +1 @@
+org.jetbrains.kotlin.idea.intentions.RemoveUnnecessaryLateinitIntention

idea/testData/intentions/removeUnnecessaryLateinit/lateinitWithConstructor.kt

@@ -0,0 +1,9 @@
+// INTENTION_TEXT: Remove unnecessary lateinit
+
+class Foo {
+    <caret>lateinit var bar: String
+
+    constructor(baz: Int) {
+        bar = ""
+    }
+}

idea/testData/intentions/removeUnnecessaryLateinit/lateinitWithConstructor.kt.after

@@ -0,0 +1,9 @@
+// INTENTION_TEXT: Remove unnecessary lateinit
+
+class Foo {
+    var bar: String
+
+    constructor(baz: Int) {
+        bar = ""
+    }
+}

idea/testData/intentions/removeUnnecessaryLateinit/lateinitWithErroneousDelegation.kt

@@ -0,0 +1,12 @@
+// IS_APPLICABLE: false
+// ERROR: None of the following functions can be called with the arguments supplied: <br>public constructor Foo() defined in Foo<br>public constructor Foo(x: String, y: String) defined in Foo
+
+class Foo {
+    <caret>lateinit var x: String
+
+    constructor() {
+        x = "Foo"
+    }
+
+    constructor(x: String, y: String): this(y.hashCode())
+}

idea/testData/intentions/removeUnnecessaryLateinit/lateinitWithInit.kt

@@ -0,0 +1,9 @@
+// INTENTION_TEXT: Remove unnecessary lateinit
+
+class Foo {
+    <caret>lateinit var bar: String
+
+    init {
+        bar = ""
+    }
+}

idea/testData/intentions/removeUnnecessaryLateinit/lateinitWithInit.kt.after

@@ -0,0 +1,9 @@
+// INTENTION_TEXT: Remove unnecessary lateinit
+
+class Foo {
+    var bar: String
+
+    init {
+        bar = ""
+    }
+}

idea/testData/intentions/removeUnnecessaryLateinit/lateinitWithMultipleConstructors.kt

@@ -0,0 +1,13 @@
+// INTENTION_TEXT: Remove unnecessary lateinit
+
+class Foo {
+    <caret>lateinit var bar: String
+
+    constructor() {
+        bar = ""
+    }
+
+    constructor(baz: Int) {
+        bar = ""
+    }
+}

idea/testData/intentions/removeUnnecessaryLateinit/lateinitWithMultipleConstructors.kt.after

@@ -0,0 +1,13 @@
+// INTENTION_TEXT: Remove unnecessary lateinit
+
+class Foo {
+    var bar: String
+
+    constructor() {
+        bar = ""
+    }
+
+    constructor(baz: Int) {
+        bar = ""
+    }
+}

idea/testData/intentions/removeUnnecessaryLateinit/lateinitWithMultipleConstructorsAndDelegation.kt

@@ -0,0 +1,15 @@
+// INTENTION_TEXT: Remove unnecessary lateinit
+
+class Foo {
+    <caret>lateinit var bar: String
+
+    constructor() {
+        bar = ""
+    }
+
+    constructor(a: Int) : this() {
+    }
+
+    constructor(a: Int, b: Int) : this(a) {
+    }
+}

idea/testData/intentions/removeUnnecessaryLateinit/lateinitWithMultipleConstructorsAndDelegation.kt.after

@@ -0,0 +1,15 @@
+// INTENTION_TEXT: Remove unnecessary lateinit
+
+class Foo {
+    var bar: String
+
+    constructor() {
+        bar = ""
+    }
+
+    constructor(a: Int) : this() {
+    }
+
+    constructor(a: Int, b: Int) : this(a) {
+    }
+}

idea/testData/intentions/removeUnnecessaryLateinit/lateinitWithMultipleInit.kt

@@ -0,0 +1,14 @@
+// INTENTION_TEXT: Remove unnecessary lateinit
+
+class Foo {
+    <caret>lateinit var bar: String
+    var baz: Int
+
+    init {
+        baz = 1
+    }
+
+    init {
+        bar = ""
+    }
+}

idea/testData/intentions/removeUnnecessaryLateinit/lateinitWithMultipleInit.kt.after

@@ -0,0 +1,14 @@
+// INTENTION_TEXT: Remove unnecessary lateinit
+
+class Foo {
+    var bar: String
+    var baz: Int
+
+    init {
+        baz = 1
+    }
+
+    init {
+        bar = ""
+    }
+}

idea/testData/intentions/removeUnnecessaryLateinit/lateinitWithPlusAssign.kt

@@ -0,0 +1,9 @@
+// IS_APPLICABLE: false
+
+class Foo {
+    <caret>lateinit var bar: String
+
+    constructor(baz: Int) {
+        bar += baz
+    }
+}

idea/testData/intentions/removeUnnecessaryLateinit/lateinitWithPrimaryConstructorAndConstructor.kt

@@ -0,0 +1,9 @@
+// IS_APPLICABLE: false
+
+class Foo() {
+    <caret>lateinit var bar: String
+
+    constructor(baz: Int) : this() {
+        bar = ""
+    }
+}

idea/testData/intentions/removeUnnecessaryLateinit/normalLateinit.kt

@@ -0,0 +1,9 @@
+// IS_APPLICABLE: false
+
+class Foo {
+    lateinit var bar: String
+
+    fun init() {
+        bar = ""
+    }
+}

idea/testData/intentions/removeUnnecessaryLateinit/secondaryConstructorDelegateItself.kt

@@ -0,0 +1,14 @@
+// IS_APPLICABLE: true
+// ERROR: There's a cycle in the delegation calls chain
+
+class Foo {
+    <caret>lateinit var bar: String
+
+    constructor() {
+        bar = ""
+    }
+
+    constructor(a: Int) : this(a) {
+        bar = "a"
+    }
+}

idea/testData/intentions/removeUnnecessaryLateinit/secondaryConstructorDelegateItself.kt.after

@@ -0,0 +1,14 @@
+// IS_APPLICABLE: true
+// ERROR: There's a cycle in the delegation calls chain
+
+class Foo {
+    <caret>var bar: String
+
+    constructor() {
+        bar = ""
+    }
+
+    constructor(a: Int) : this(a) {
+        bar = "a"
+    }
+}

idea/testData/intentions/removeUnnecessaryLateinit/secondaryConstructorDelegateLoop.kt

@@ -0,0 +1,21 @@
+// IS_APPLICABLE: false
+// ERROR: There's a cycle in the delegation calls chain
+// ERROR: There's a cycle in the delegation calls chain
+// ERROR: There's a cycle in the delegation calls chain
+
+class Foo {
+    <caret>lateinit var bar: String
+
+    constructor() {
+        bar = ""
+    }
+
+    constructor(a: Int) : this(a, 0, 0) {
+    }
+
+    constructor(a: Int, b: Int) : this(a) {
+    }
+
+    constructor(a: Int, b: Int, c: Int) : this(a, b) {
+    }
+}

idea/testData/intentions/removeUnnecessaryLateinit/secondaryConstructorDelegateSuper.kt

@@ -0,0 +1,14 @@
+// IS_APPLICABLE: false
+
+open class Bar(val a: Int = 0)
+
+class Foo : Bar {
+    <caret>lateinit var bar: String
+
+    constructor() : super() {
+        bar = ""
+    }
+
+    constructor(a: Int) : super(a) {
+    }
+}