Add Native-specific frontend checker for @Throws

native/frontend/src/org/jetbrains/kotlin/resolve/konan/diagnostics/DefaultErrorMessagesNative.kt

@@ -7,10 +7,16 @@ package org.jetbrains.kotlin.resolve.konan.diagnostics
 
 import org.jetbrains.kotlin.diagnostics.rendering.DefaultErrorMessages
 import org.jetbrains.kotlin.diagnostics.rendering.DiagnosticFactoryToRendererMap
+import org.jetbrains.kotlin.diagnostics.rendering.Renderers
 
 private val DIAGNOSTIC_FACTORY_TO_RENDERER by lazy {
     DiagnosticFactoryToRendererMap("Native").apply {
-
+        put(ErrorsNative.THROWS_LIST_EMPTY, "@Throws must have non-empty class list")
+        put(ErrorsNative.THROWS_ON_OVERRIDE, "@Throws is prohibited for overridden members")
+        put(
+            ErrorsNative.INCOMPATIBLE_THROWS_INHERITED, "Member inherits different @Throws filters from {0}",
+            Renderers.commaSeparated(Renderers.NAME)
+        )
     }
 }
 

native/frontend/src/org/jetbrains/kotlin/resolve/konan/diagnostics/ErrorsNative.kt

@@ -5,9 +5,21 @@
 
 package org.jetbrains.kotlin.resolve.konan.diagnostics
 
+import org.jetbrains.kotlin.descriptors.DeclarationDescriptor
+import org.jetbrains.kotlin.diagnostics.DiagnosticFactory0
+import org.jetbrains.kotlin.diagnostics.DiagnosticFactory1
 import org.jetbrains.kotlin.diagnostics.Errors
+import org.jetbrains.kotlin.diagnostics.Severity
+import org.jetbrains.kotlin.psi.KtDeclaration
+import org.jetbrains.kotlin.psi.KtElement
 
 object ErrorsNative {
+    @JvmField
+    val THROWS_LIST_EMPTY = DiagnosticFactory0.create<KtElement>(Severity.ERROR)
+    @JvmField
+    val THROWS_ON_OVERRIDE = DiagnosticFactory0.create<KtElement>(Severity.ERROR)
+    @JvmField
+    val INCOMPATIBLE_THROWS_INHERITED = DiagnosticFactory1.create<KtDeclaration, Collection<DeclarationDescriptor>>(Severity.ERROR)
 
     init {
         Errors.Initializer.initializeFactoryNames(ErrorsNative::class.java)

native/frontend/src/org/jetbrains/kotlin/resolve/konan/diagnostics/NativeThrowsChecker.kt

@@ -0,0 +1,63 @@
+/*
+ * Copyright 2010-2020 JetBrains s.r.o. and Kotlin Programming Language contributors.
+ * Use of this source code is governed by the Apache 2.0 license that can be found in the license/LICENSE.txt file.
+ */
+
+package org.jetbrains.kotlin.resolve.konan.diagnostics
+
+
+import org.jetbrains.kotlin.descriptors.CallableMemberDescriptor
+import org.jetbrains.kotlin.descriptors.DeclarationDescriptor
+import org.jetbrains.kotlin.descriptors.annotations.AnnotationDescriptor
+import org.jetbrains.kotlin.name.FqName
+import org.jetbrains.kotlin.psi.KtDeclaration
+import org.jetbrains.kotlin.resolve.DescriptorToSourceUtils
+import org.jetbrains.kotlin.resolve.checkers.DeclarationChecker
+import org.jetbrains.kotlin.resolve.checkers.DeclarationCheckerContext
+import org.jetbrains.kotlin.resolve.constants.ArrayValue
+import org.jetbrains.kotlin.resolve.constants.ConstantValue
+import org.jetbrains.kotlin.resolve.descriptorUtil.firstArgument
+import org.jetbrains.kotlin.resolve.findOriginalTopMostOverriddenDescriptors
+
+object NativeThrowsChecker : DeclarationChecker {
+    private val throwsFqName = FqName("kotlin.native.Throws")
+
+    override fun check(declaration: KtDeclaration, descriptor: DeclarationDescriptor, context: DeclarationCheckerContext) {
+        checkForIncompatibleMultipleInheritance(declaration, descriptor, context)
+
+        val throwsAnnotation = descriptor.annotations.findAnnotation(throwsFqName) ?: return
+        val element = DescriptorToSourceUtils.getSourceFromAnnotation(throwsAnnotation) ?: declaration
+
+        if (descriptor is CallableMemberDescriptor && descriptor.overriddenDescriptors.isNotEmpty()) {
+            context.trace.report(ErrorsNative.THROWS_ON_OVERRIDE.on(element))
+            return
+        }
+
+        if (throwsAnnotation.getVariadicArguments().isEmpty()) {
+            context.trace.report(ErrorsNative.THROWS_LIST_EMPTY.on(element))
+        }
+    }
+
+    private fun checkForIncompatibleMultipleInheritance(
+        declaration: KtDeclaration,
+        descriptor: DeclarationDescriptor,
+        context: DeclarationCheckerContext
+    ) {
+        if (descriptor !is CallableMemberDescriptor) return
+
+        if (descriptor.overriddenDescriptors.size < 2) return // No multiple inheritance here.
+
+        val incompatible = descriptor.findOriginalTopMostOverriddenDescriptors()
+            .distinctBy { it.annotations.findAnnotation(throwsFqName)?.getVariadicArguments()?.toSet() }
+
+        if (incompatible.size < 2) return
+
+        context.trace.report(ErrorsNative.INCOMPATIBLE_THROWS_INHERITED.on(declaration, incompatible.map { it.containingDeclaration }))
+    }
+
+    private fun AnnotationDescriptor.getVariadicArguments(): List<ConstantValue<*>> {
+        val argument = this.firstArgument() as? ArrayValue ?: return emptyList()
+        return argument.value
+    }
+
+}

native/frontend/src/org/jetbrains/kotlin/resolve/konan/platform/NativePlatformConfigurator.kt

@@ -14,9 +14,11 @@ import org.jetbrains.kotlin.resolve.*
 import org.jetbrains.kotlin.resolve.checkers.ExpectedActualDeclarationChecker
 import org.jetbrains.kotlin.resolve.inline.ReasonableInlineRule
 import org.jetbrains.kotlin.resolve.jvm.checkers.SuperCallWithDefaultArgumentsChecker
+import org.jetbrains.kotlin.resolve.konan.diagnostics.NativeThrowsChecker
 
 object NativePlatformConfigurator : PlatformConfiguratorBase(
-    additionalCallCheckers = listOf(SuperCallWithDefaultArgumentsChecker())
+    additionalCallCheckers = listOf(SuperCallWithDefaultArgumentsChecker()),
+    additionalDeclarationCheckers = listOf(NativeThrowsChecker)
 ) {
     override fun configureModuleComponents(container: StorageComponentContainer) {
         container.useInstance(NativeInliningRule)