azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Report warnings on safe call + nullable extension operator

Browse Source 
^KT-41034 In Progress
This commit is contained in:
Denis Zharkov
2020-08-14 11:12:13 +03:00
parent 852d22470e
commit 5ede37d6ab
10 changed files with 270 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/testData/diagnostics/tests/nullableTypes/safeCallOperators.fir.kt
Vendored
+91
View File
@@ -0,0 +1,91 @@
// SKIP_TXT
// !DIAGNOSTICS: -UNUSED_PARAMETER
class A(
val l: MutableList<Int>,
val ll: MutableList<MutableList<Int>>,
var w: Int,
val q: () -> Unit
)
operator fun <T> MutableList<in T>?.plusAssign(t: Any?) {}
operator fun <T> MutableList<T>?.set(t: Int, w: Any?) {}
operator fun <T> List<T>?.get(t: Int): T? = this?.get(t)
operator fun Int?.inc(): Int = 1
operator fun (() -> Unit)?.invoke() {}
fun foo(a: A?) {
a?.l += 1
a?.l[0]
a?.l[0]++
a?.l[0] = 1
a?.ll[0][0]
a?.ll[0][0]++
a?.ll[0][0] = 1
// No warning is reported because
// 1. All kinds of green code with safe+call + invoke we identified fails with CCE if `a != null`, anyway
// 2. In case of null value, the behavior is intended (no call performed)
a?.q()
a?.w++
(a?.l) += 1
(a?.l)[0]
(a?.l)[0]++
(a?.l)[0] = 1
(a?.ll)[0][0]
(a?.ll)[0][0]++
(a?.ll)[0][0] = 1
(a?.q)()
(a?.w)++
a?.l.plusAssign(1)
a?.l.get(0)
a?.l.get(0).inc()
a?.l.set(0, 1)
a?.ll.get(0).get(0)
a?.ll.get(0).get(0).inc()
a?.ll.get(0).set(0, 1)
a?.q.invoke()
a?.w.inc()
if (a != null) {
a?.l += 1
a?.l[0]
a?.l[0]++
a?.l[0] = 1
a?.ll[0][0]
a?.ll[0][0]++
a?.ll[0][0] = 1
// No warning is reported because
// 1. All kinds of green code with safe+call + invoke we identified fails with CCE if `a != null`, anyway
// 2. In case of null value, the behavior is intended (no call performed)
a?.q()
a?.w++
(a?.l) += 1
(a?.l)[0]
(a?.l)[0]++
(a?.l)[0] = 1
(a?.ll)[0][0]
(a?.ll)[0][0]++
(a?.ll)[0][0] = 1
(a?.q)()
(a?.w)++
a?.l.plusAssign(1)
a?.l.get(0)
a?.l.get(0).inc()
a?.l.set(0, 1)
a?.ll.get(0).get(0)
a?.ll.get(0).get(0).inc()
a?.ll.get(0).set(0, 1)
a?.q.invoke()
a?.w.inc()
}
}
compiler/testData/diagnostics/tests/nullableTypes/safeCallOperators.kt
Vendored
+91
View File
@@ -0,0 +1,91 @@
// SKIP_TXT
// !DIAGNOSTICS: -UNUSED_PARAMETER
class A(
val l: MutableList<Int>,
val ll: MutableList<MutableList<Int>>,
var w: Int,
val q: () -> Unit
)
operator fun <T> MutableList<in T>?.plusAssign(t: Any?) {}
operator fun <T> MutableList<T>?.set(t: Int, w: Any?) {}
operator fun <T> List<T>?.get(t: Int): T? = this?.get(t)
operator fun Int?.inc(): Int = 1
operator fun (() -> Unit)?.invoke() {}
fun foo(a: A?) {
a?.l <!NULLABLE_EXTENSION_OPERATOR_WITH_SAFE_CALL_RECEIVER!>+=<!> 1
<!NULLABLE_EXTENSION_OPERATOR_WITH_SAFE_CALL_RECEIVER!>a?.l[0]<!>
<!NULLABLE_EXTENSION_OPERATOR_WITH_SAFE_CALL_RECEIVER, NULLABLE_EXTENSION_OPERATOR_WITH_SAFE_CALL_RECEIVER!>a?.l[0]<!>++
<!NULLABLE_EXTENSION_OPERATOR_WITH_SAFE_CALL_RECEIVER!>a?.l[0]<!> = 1
<!NULLABLE_EXTENSION_OPERATOR_WITH_SAFE_CALL_RECEIVER!>a?.ll[0]<!>[0]
<!NULLABLE_EXTENSION_OPERATOR_WITH_SAFE_CALL_RECEIVER!>a?.ll[0]<!>[0]++
<!NULLABLE_EXTENSION_OPERATOR_WITH_SAFE_CALL_RECEIVER!>a?.ll[0]<!>[0] = 1
// No warning is reported because
// 1. All kinds of green code with safe+call + invoke we identified fails with CCE if `a != null`, anyway
// 2. In case of null value, the behavior is intended (no call performed)
a?.q()
a?.w<!NULLABLE_EXTENSION_OPERATOR_WITH_SAFE_CALL_RECEIVER!>++<!>
(a?.l) += 1
(a?.l)[0]
(a?.l)[0]++
(a?.l)[0] = 1
(a?.ll)[0][0]
(a?.ll)[0][0]++
(a?.ll)[0][0] = 1
(a?.q)()
(a?.w)++
a?.l.plusAssign(1)
a?.l.get(0)
a?.l.get(0).inc()
a?.l.set(0, 1)
a?.ll.get(0).get(0)
a?.ll.get(0).get(0).inc()
a?.ll.get(0).set(0, 1)
a?.q.invoke()
a?.w.inc()
if (a != null) {
a<!UNNECESSARY_SAFE_CALL!>?.<!>l += 1
a<!UNNECESSARY_SAFE_CALL!>?.<!>l[0]
a<!UNNECESSARY_SAFE_CALL!>?.<!>l[0]++
a<!UNNECESSARY_SAFE_CALL!>?.<!>l[0] = 1
a<!UNNECESSARY_SAFE_CALL!>?.<!>ll[0][0]
a<!UNNECESSARY_SAFE_CALL!>?.<!>ll[0][0]++
a<!UNNECESSARY_SAFE_CALL!>?.<!>ll[0][0] = 1
// No warning is reported because
// 1. All kinds of green code with safe+call + invoke we identified fails with CCE if `a != null`, anyway
// 2. In case of null value, the behavior is intended (no call performed)
a<!UNNECESSARY_SAFE_CALL!>?.<!>q()
a<!UNNECESSARY_SAFE_CALL!>?.<!>w++
(a<!UNNECESSARY_SAFE_CALL!>?.<!>l) += 1
(a<!UNNECESSARY_SAFE_CALL!>?.<!>l)[0]
(a<!UNNECESSARY_SAFE_CALL!>?.<!>l)[0]++
(a<!UNNECESSARY_SAFE_CALL!>?.<!>l)[0] = 1
(a<!UNNECESSARY_SAFE_CALL!>?.<!>ll)[0][0]
(a<!UNNECESSARY_SAFE_CALL!>?.<!>ll)[0][0]++
(a<!UNNECESSARY_SAFE_CALL!>?.<!>ll)[0][0] = 1
(a<!UNNECESSARY_SAFE_CALL!>?.<!>q)()
(a<!UNNECESSARY_SAFE_CALL!>?.<!>w)++
a<!UNNECESSARY_SAFE_CALL!>?.<!>l.plusAssign(1)
a<!UNNECESSARY_SAFE_CALL!>?.<!>l.get(0)
a<!UNNECESSARY_SAFE_CALL!>?.<!>l.get(0).inc()
a<!UNNECESSARY_SAFE_CALL!>?.<!>l.set(0, 1)
a<!UNNECESSARY_SAFE_CALL!>?.<!>ll.get(0).get(0)
a<!UNNECESSARY_SAFE_CALL!>?.<!>ll.get(0).get(0).inc()
a<!UNNECESSARY_SAFE_CALL!>?.<!>ll.get(0).set(0, 1)
a<!UNNECESSARY_SAFE_CALL!>?.<!>q.invoke()
a<!UNNECESSARY_SAFE_CALL!>?.<!>w.inc()
}
}