From 5eb11ae7544f02539030af3d21ad8613fd5f8e4f Mon Sep 17 00:00:00 2001 From: pTalanov Date: Wed, 6 Jun 2012 15:35:50 +0400 Subject: [PATCH] Remove error logging when we can't determine the type (js or jvm) of the module the source belongs to (for example navigating to library sources which happens really often) --- .../jet/plugin/project/AnalyzerFacadeProvider.java | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/idea/src/org/jetbrains/jet/plugin/project/AnalyzerFacadeProvider.java b/idea/src/org/jetbrains/jet/plugin/project/AnalyzerFacadeProvider.java index 4fcc42613d1..4d4d8e1e141 100644 --- a/idea/src/org/jetbrains/jet/plugin/project/AnalyzerFacadeProvider.java +++ b/idea/src/org/jetbrains/jet/plugin/project/AnalyzerFacadeProvider.java @@ -16,7 +16,6 @@ package org.jetbrains.jet.plugin.project; -import com.intellij.openapi.application.ApplicationManager; import com.intellij.openapi.diagnostic.Logger; import com.intellij.openapi.module.Module; import com.intellij.openapi.roots.ProjectFileIndex; @@ -40,25 +39,18 @@ public final class AnalyzerFacadeProvider { public static AnalyzerFacade getAnalyzerFacadeForFile(@NotNull JetFile file) { VirtualFile virtualFile = file.getOriginalFile().getVirtualFile(); if (virtualFile == null) { - logErrorIfNotTests("No virtual file for " + file.getName() + " with text:\n" + file.getText()); return getDefaultAnalyzerFacade(); } Module moduleForFile = ProjectFileIndex.SERVICE.getInstance(file.getProject()).getModuleForFile(virtualFile); if (moduleForFile == null) { - logErrorIfNotTests("File " + virtualFile.getPath() + " is not under any module. Cannot determine which facade to use."); return getDefaultAnalyzerFacade(); } return getAnalyzerFacadeForModule(moduleForFile); } - private static void logErrorIfNotTests(@NotNull String message) { - if (!ApplicationManager.getApplication().isUnitTestMode()) { - LOG.error(message); - } - } - @NotNull private static AnalyzerFacade getDefaultAnalyzerFacade() { + //TODO: should deal with situations when we can't determine whether to use java or js backend more carefully LOG.info("Using default analyzer facade"); return AnalyzerFacadeForJVM.INSTANCE; }