From 5e96bf07953540de572947ce63c9f3160ee0d434 Mon Sep 17 00:00:00 2001 From: "konstantin.tskhovrebov" Date: Mon, 10 Oct 2022 14:33:41 +0200 Subject: [PATCH] [KT-54314] Cocoapods: disable signing for all pod dependencies in synthetic project --- .../kotlin/gradle/native/CocoaPodsIT.kt | 3 +++ .../native/tasks/AdvancedCocoapodsTasks.kt | 17 ++++++++++++++++- 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/libraries/tools/kotlin-gradle-plugin-integration-tests/src/test/kotlin/org/jetbrains/kotlin/gradle/native/CocoaPodsIT.kt b/libraries/tools/kotlin-gradle-plugin-integration-tests/src/test/kotlin/org/jetbrains/kotlin/gradle/native/CocoaPodsIT.kt index fb9f1e0e218..474ab102511 100644 --- a/libraries/tools/kotlin-gradle-plugin-integration-tests/src/test/kotlin/org/jetbrains/kotlin/gradle/native/CocoaPodsIT.kt +++ b/libraries/tools/kotlin-gradle-plugin-integration-tests/src/test/kotlin/org/jetbrains/kotlin/gradle/native/CocoaPodsIT.kt @@ -245,6 +245,9 @@ class CocoaPodsIT : BaseGradleIT() { assertTrue(podfileText.contains("pod 'SSZipArchive'")) assertTrue(podfileText.contains("pod 'AFNetworking', '~> 4.0.1'")) assertTrue(podfileText.contains("pod 'Alamofire', :git => 'https://github.com/Alamofire/Alamofire.git', :tag => '5.6.1'")) + assertTrue(podfileText.contains("config.build_settings['EXPANDED_CODE_SIGN_IDENTITY'] = \"\"")) + assertTrue(podfileText.contains("config.build_settings['CODE_SIGNING_REQUIRED'] = \"NO\"")) + assertTrue(podfileText.contains("config.build_settings['CODE_SIGNING_ALLOWED'] = \"NO\"")) } } diff --git a/libraries/tools/kotlin-gradle-plugin/src/common/kotlin/org/jetbrains/kotlin/gradle/targets/native/tasks/AdvancedCocoapodsTasks.kt b/libraries/tools/kotlin-gradle-plugin/src/common/kotlin/org/jetbrains/kotlin/gradle/targets/native/tasks/AdvancedCocoapodsTasks.kt index 31b26ab92e2..79836d26e32 100644 --- a/libraries/tools/kotlin-gradle-plugin/src/common/kotlin/org/jetbrains/kotlin/gradle/targets/native/tasks/AdvancedCocoapodsTasks.kt +++ b/libraries/tools/kotlin-gradle-plugin/src/common/kotlin/org/jetbrains/kotlin/gradle/targets/native/tasks/AdvancedCocoapodsTasks.kt @@ -97,7 +97,8 @@ open class PodInstallTask : CocoapodsTask() { returnCode, output, project, - frameworkName.get()) + frameworkName.get() + ) }, exceptionHandler = { e: IOException -> CocoapodsErrorHandlingUtil.handle(e, podInstallCommand) @@ -236,6 +237,20 @@ open class PodGenTask : CocoapodsTask() { } }.forEach { appendLine("\t$it") } appendLine("end\n") + //disable signing for all synthetic pods KT-54314 + append( + """ + post_install do |installer| + installer.pods_project.targets.each do |target| + target.build_configurations.each do |config| + config.build_settings['EXPANDED_CODE_SIGN_IDENTITY'] = "" + config.build_settings['CODE_SIGNING_REQUIRED'] = "NO" + config.build_settings['CODE_SIGNING_ALLOWED'] = "NO" + end + end + end + """.trimIndent() + ) } }