Compile common code to klib whenever HMPP is enabled

As the HMPP with *.kotlin_metadata was never widespread, we can
immediately move to *.klib compilations whenever a build author
enables HMPP.

libraries/tools/kotlin-gradle-plugin-integration-tests/src/test/kotlin/org/jetbrains/kotlin/gradle/HierarchicalMppIT.kt

@@ -167,14 +167,14 @@ class HierarchicalMppIT : BaseGradleIT() {
             publishedMetadataJar.checkAllEntryNamesArePresent(
                 "META-INF/$MULTIPLATFORM_PROJECT_METADATA_FILE_NAME",
 
-                "commonMain/META-INF/my-lib-foo_commonMain.kotlin_module",
+                "commonMain/manifest",
-                "commonMain/com/example/foo/FooKt.kotlin_metadata",
+                "commonMain/linkdata/package_com.example/",
 
-                "jvmAndJsMain/META-INF/my-lib-foo_jvmAndJsMain.kotlin_module",
+                "jvmAndJsMain/manifest",
-                "jvmAndJsMain/com/example/foo/FooJvmAndJsKt.kotlin_metadata",
+                "jvmAndJsMain/linkdata/package_com.example/",
 
-                "linuxAndJsMain/META-INF/my-lib-foo_linuxAndJsMain.kotlin_module",
+                "linuxAndJsMain/manifest",
-                "linuxAndJsMain/com/example/foo/FooLinuxAndJsKt.kotlin_metadata"
+                "linuxAndJsMain/linkdata/package_com.example/"
             )
 
             val parsedProjectStructureMetadata: KotlinProjectStructureMetadata = publishedMetadataJar.getProjectStructureMetadata()
@@ -205,14 +205,14 @@ class HierarchicalMppIT : BaseGradleIT() {
             publishedMetadataJar.checkAllEntryNamesArePresent(
                 "META-INF/$MULTIPLATFORM_PROJECT_METADATA_FILE_NAME",
 
-                "commonMain/META-INF/my-lib-bar_commonMain.kotlin_module",
+                "commonMain/manifest",
-                "commonMain/com/example/bar/BarKt.kotlin_metadata",
+                "commonMain/linkdata/package_com.example.bar/",
 
-                "jvmAndJsMain/META-INF/my-lib-bar_jvmAndJsMain.kotlin_module",
+                "jvmAndJsMain/manifest",
-                "jvmAndJsMain/com/example/bar/BarJvmAndJsKt.kotlin_metadata",
+                "jvmAndJsMain/linkdata/package_com.example.bar/",
 
-                "linuxAndJsMain/META-INF/my-lib-bar_linuxAndJsMain.kotlin_module",
+                "linuxAndJsMain/manifest",
-                "linuxAndJsMain/com/example/bar/BarLinuxAndJsKt.kotlin_metadata"
+                "linuxAndJsMain/linkdata/package_com.example.bar/"
             )
 
             val parsedProjectStructureMetadata: KotlinProjectStructureMetadata = publishedMetadataJar.getProjectStructureMetadata()
@@ -376,7 +376,7 @@ class HierarchicalMppIT : BaseGradleIT() {
                     ModuleDependencyIdentifier(it.first, it.second)
                 }.toSet()
             },
-            sourceSetBinaryLayout = sourceSetModuleDependencies.mapValues { SourceSetMetadataLayout.METADATA }
+            sourceSetBinaryLayout = sourceSetModuleDependencies.mapValues { SourceSetMetadataLayout.KLIB }
         )
     }
 

libraries/tools/kotlin-gradle-plugin-integration-tests/src/test/resources/testProject/common-klib-lib-and-app/gradle.properties

@@ -1,2 +1 @@
 kotlin.mpp.enableGranularSourceSetsMetadata=true
-kotlin.mpp.enableCommonKlibs=true

libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/plugin/KotlinProperties.kt

@@ -94,9 +94,6 @@ internal class PropertiesProvider private constructor(private val project: Proje
     val enableGranularSourceSetsMetadata: Boolean?
         get() = booleanProperty("kotlin.mpp.enableGranularSourceSetsMetadata")
 
-    val enableCommonKlibs: Boolean?
-        get() = booleanProperty("kotlin.mpp.enableCommonKlibs")
-
     val enableCompatibilityMetadataVariant: Boolean?
         get() = booleanProperty("kotlin.mpp.enableCompatibilityMetadataVariant")
 

libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/plugin/mpp/KotlinCommonCompilation.kt

@@ -24,7 +24,7 @@ class KotlinCommonCompilation(
         get() = super.compileKotlinTask as KotlinCompileCommon
 
     internal val isKlibCompilation: Boolean
-        get() = PropertiesProvider(target.project).enableCommonKlibs == true && !forceCompilationToKotlinMetadata
+        get() = PropertiesProvider(target.project).enableGranularSourceSetsMetadata == true && !forceCompilationToKotlinMetadata
 
     internal var forceCompilationToKotlinMetadata: Boolean = false
 }

libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/plugin/mpp/KotlinProjectStructureMetadata.kt

@@ -41,10 +41,8 @@ sealed class SourceSetMetadataLayout(
         fun byName(name: String): SourceSetMetadataLayout? = values.firstOrNull { it.name == name }
 
         fun chooseForProducingProject(project: Project) =
-            if (PropertiesProvider(project.rootProject).enableCommonKlibs == true)
+            /** A producing project will now only generate Granular source sets metadata as a KLIB */
-                KLIB
+            KLIB
-            else
-                METADATA
     }
 }