FIR IDE: fix test data in fir-ide module

idea/idea-completion/testData/basic/common/ClassRedeclaration2.kt

@@ -1,4 +1,3 @@
-// FIR_COMPARISON
 class A {
   fun f() : A
 }

idea/idea-completion/testData/basic/common/ObjectRedeclaration2.kt

@@ -1,4 +1,3 @@
-// FIR_COMPARISON
 object A {
   fun f() : S
 }

idea/idea-fir/tests/org/jetbrains/kotlin/checkers/AbstractFirPsiCheckerTest.kt

@@ -6,6 +6,8 @@
 package org.jetbrains.kotlin.checkers
 
 import com.intellij.rt.execution.junit.FileComparisonFailure
+import org.jetbrains.kotlin.idea.completion.FIR_COMPARISON
+import org.jetbrains.kotlin.idea.completion.runTestWithCustomEnableDirective
 import org.jetbrains.kotlin.idea.test.withCustomCompilerOptions
 import org.jetbrains.kotlin.idea.withPossiblyDisabledDuplicatedFirSourceElementsException
 import org.jetbrains.kotlin.test.InTextDirectivesUtils
@@ -16,13 +18,11 @@ abstract class AbstractFirPsiCheckerTest : AbstractPsiCheckerTest() {
 
     override fun isFirPlugin(): Boolean = true
 
-    override fun setUp() {
-        super.setUp()
-    }
-
     override fun doTest(filePath: String) {
-        myFixture.configureByFile(fileName())
+        runTestWithCustomEnableDirective(FIR_COMPARISON, testDataFile()) {
-        checkHighlighting(checkWarnings = false, checkInfos = false, checkWeakWarnings = false)
+            myFixture.configureByFile(fileName())
+            checkHighlighting(checkWarnings = false, checkInfos = false, checkWeakWarnings = false)
+        }
     }
 
     override fun checkHighlighting(
@@ -30,27 +30,15 @@ abstract class AbstractFirPsiCheckerTest : AbstractPsiCheckerTest() {
         checkInfos: Boolean,
         checkWeakWarnings: Boolean
     ): Long {
-        val file = file
         val fileText = file.text
         return withCustomCompilerOptions(fileText, project, module) {
-            val doComparison = InTextDirectivesUtils.isDirectiveDefined(myFixture.file.text, "FIR_COMPARISON")
             try {
                 withPossiblyDisabledDuplicatedFirSourceElementsException(fileText) {
                     myFixture.checkHighlighting(checkWarnings, checkInfos, checkWeakWarnings)
                 }
             } catch (e: FileComparisonFailure) {
-                if (doComparison) {
+                throw FileComparisonFailure(e.message, e.expected, e.actual, File(e.filePath).absolutePath)
-                    // Even this is very partial check (only error compatibility, no warnings / infos)
-                    throw FileComparisonFailure(e.message, e.expected, e.actual, File(e.filePath).absolutePath)
-                } else {
-                    // Here we just check that we haven't crashed due to exception
-                    0
-                }
             }
         }
     }
-
-    override fun tearDown() {
-        super.tearDown()
-    }
 }

idea/testData/checker/ClassObjectInEnum.kt

@@ -1,3 +1,4 @@
+// FIR_COMPARISON
 enum class E {
     ENTRY;
 

idea/testData/checker/Nullability.kt

@@ -1,3 +1,4 @@
+// FIR_COMPARISON
 fun test() {
   val a : Int? = 0
   if (a != null) {

idea/testData/checker/Redeclaration.kt

@@ -1,3 +1,4 @@
+// IGNORE_FIR
 // !DIAGNOSTICS: -DUPLICATE_CLASS_NAMES
 val <error>a</error> : Int = 1
 val <error>a</error> : Int = 1

idea/testData/checker/SupertypeListChecks.kt

@@ -1,3 +1,4 @@
+// IGNORE_FIR
 // KT-286 Check supertype lists
 
 /*

idea/testData/checker/TraitSupertypeList.kt

@@ -1,3 +1,5 @@
+// IGNORE_FIR
+
 open class bar()
 
 interface Foo<error>()</error> : <error>bar</error><error>()</error>, <error><error>bar</error></error>, <error><error>bar</error></error> {

idea/testData/checker/infos/CapturedConstructorParameter.kt

@@ -1,3 +1,4 @@
+// FIR_COMPARISON
 <info>import</info> kotlin.reflect.KProperty
 
 interface T

idea/testData/checker/infos/CapturedInInlinedClosure.kt

@@ -1,3 +1,4 @@
+// FIR_COMPARISON
 <info descr="null">inline</info> fun <T> run(f: () -> T) = f()
 fun run2(f: () -> Unit) = f()
 

idea/testData/checker/infos/threeImplicitReceivers.kt

@@ -1,3 +1,4 @@
+// FIR_COMPARISON
 interface IA
 interface IB
 interface IC

idea/testData/checker/infos/twoImplicitReceivers.kt

@@ -1,3 +1,4 @@
+// FIR_COMPARISON
 interface IA
 interface IB
 

idea/testData/checker/kt32189returnTypeWithTypealiasSubtitution.kt

@@ -1,3 +1,4 @@
+// FIR_COMPARISON
 class B {
     class Builder
 }

idea/testData/checker/recovery/namelessMembers.kt

@@ -1,3 +1,5 @@
+// IGNORE_FIR
+
 class C {
     <error>fun ()</error> {
 

idea/testData/checker/recovery/namelessToplevelDeclarations.kt

@@ -1,3 +1,5 @@
+// IGNORE_FIR
+
 package<EOLError></EOLError>
 
 <error>fun ()</error> {

idea/testData/checker/regression/AmbiguityOnLazyTypeComputation.kt

@@ -1,3 +1,4 @@
+// FIR_COMPARISON
 // One of the two passes is making a scope and turning vals into functions
 // See KT-76
 

idea/testData/checker/regression/DestructuringDeclarationInLambda.kt

@@ -1,5 +1,3 @@
-// FIR_COMPARISON
-
 data class XY(val x: Int, val y: Int)
 
 fun convert(xy: XY, f: (XY) -> Int) = f(xy)

idea/testData/checker/regression/FunctionLiteralInsideAnnotation.kt

@@ -1,3 +1,4 @@
+// FIR_COMPARISON
 package foo
 
 @<error>Anno</error> ({ val x: Int })

idea/testData/checker/regression/Jet121.kt

@@ -1,3 +1,4 @@
+// FIR_COMPARISON
 package jet121
 
 fun box(): String {

idea/testData/checker/regression/Jet53.kt

@@ -1,5 +1,3 @@
-// FIR_COMPARISON
-
 import java.util.Collections
 
 fun <T> checkSubtype(t: T) = t

idea/testData/checker/regression/callVariableAsFunctionWithAnonymousObjectArg.kt

@@ -1,3 +1,4 @@
+// FIR_COMPARISON
 fun f() {
     val g = 3
     <error>g</error>(object : Any() {})

idea/testData/checker/regression/extensionMemberInClassObject.kt

@@ -1,5 +1,3 @@
-// FIR_COMPARISON
-
 interface Bar {
     fun <T> T.bar() {}
 }

idea/testData/findUsages/kotlin/internal/findFunctionUsages/kotlinTraitImplThroughDelegate.0.kt

@@ -1,5 +1,6 @@
 // PSI_ELEMENT: org.jetbrains.kotlin.psi.KtNamedFunction
 // OPTIONS: usages, skipImports
+// FIR_COMPARISON
 package server
 
 interface TraitWithImpl {

idea/testData/highlighter/DelegatingCtor.kt

@@ -1,3 +1,5 @@
+// IGNORE_FIR
+
 <info textAttributesKey="KOTLIN_BUILTIN_ANNOTATION">open</info> class <info textAttributesKey="KOTLIN_CLASS">Foo</info> {
     <info textAttributesKey="KOTLIN_KEYWORD">constructor</info>(<warning descr="[UNUSED_PARAMETER] Parameter 'i' is never used" textAttributesKey="NOT_USED_ELEMENT_ATTRIBUTES"><info textAttributesKey="KOTLIN_PARAMETER">i</info></warning>: <info textAttributesKey="KOTLIN_CLASS">Int</info>)
 }

idea/testData/highlighter/TypeAlias.kt

@@ -1,3 +1,4 @@
+// IGNORE_FIR
 // EXPECTED_DUPLICATED_HIGHLIGHTING
 
 typealias <info textAttributesKey="KOTLIN_TYPE_ALIAS">Predicate</info><<info textAttributesKey="KOTLIN_TYPE_PARAMETER">T</info>> = (<info textAttributesKey="KOTLIN_TYPE_PARAMETER">T</info>) -> <info textAttributesKey="KOTLIN_CLASS">Boolean</info>

idea/testData/highlighter/Variables.kt

@@ -1,3 +1,4 @@
+// IGNORE_FIR
 // EXPECTED_DUPLICATED_HIGHLIGHTING
 
 var <info textAttributesKey="KOTLIN_MUTABLE_VARIABLE"><info textAttributesKey="KOTLIN_PACKAGE_PROPERTY">x</info></info> = 5

idea/testData/highlighter/deprecated/Class.kt

@@ -1,5 +1,3 @@
-// IGNORE_FIR
-
 package test
 
 import java.util.ArrayList

idea/testData/resolve/references/ClassObjectClassLiteralReferenceWithField.kt

@@ -1,3 +1,4 @@
+// IGNORE_FIR
 package t
 
 class A {