[Gradle][Tests][MPP] Use MAX_SUPPORTED AGP/Gradle versions for MPP tests

This commit is contained in:
Pavel Kargashinsky
2023-04-03 13:07:50 +02:00
committed by Space Team
parent 4b66160afb
commit 5c56145a19
7 changed files with 17 additions and 12 deletions
@@ -224,7 +224,7 @@ class ConfigurationCacheIT : AbstractConfigurationCacheIT() {
} }
@JvmGradlePluginTests @JvmGradlePluginTests
@DisplayName("with build build scan report") @DisplayName("with build scan report")
@GradleTest @GradleTest
fun testBuildScanReportSmokeTestForConfigurationCache(gradleVersion: GradleVersion) { fun testBuildScanReportSmokeTestForConfigurationCache(gradleVersion: GradleVersion) {
project("simpleProject", gradleVersion) { project("simpleProject", gradleVersion) {
@@ -19,6 +19,7 @@ package org.jetbrains.kotlin.gradle
import org.gradle.util.GradleVersion import org.gradle.util.GradleVersion
import org.jetbrains.kotlin.com.google.common.base.Objects import org.jetbrains.kotlin.com.google.common.base.Objects
import org.jetbrains.kotlin.gradle.GradleVersionRequired.Companion.OLDEST_SUPPORTED import org.jetbrains.kotlin.gradle.GradleVersionRequired.Companion.OLDEST_SUPPORTED
import org.jetbrains.kotlin.gradle.testbase.TestVersions
import org.jetbrains.kotlin.gradle.utils.minSupportedGradleVersion import org.jetbrains.kotlin.gradle.utils.minSupportedGradleVersion
import org.junit.Assume import org.junit.Assume
@@ -26,7 +27,7 @@ sealed class GradleVersionRequired(val minVersion: String, val maxVersion: Strin
companion object { companion object {
const val OLDEST_SUPPORTED = minSupportedGradleVersion const val OLDEST_SUPPORTED = minSupportedGradleVersion
val FOR_MPP_SUPPORT = AtLeast(OLDEST_SUPPORTED) val FOR_MPP_SUPPORT = AtLeast(TestVersions.Gradle.MAX_SUPPORTED)
} }
class Exact(version: String) : GradleVersionRequired(version, version) { class Exact(version: String) : GradleVersionRequired(version, version) {
@@ -71,6 +71,7 @@ class KotlinAndroidMppIT : KGPBaseTest() {
android { android {
compileSdkVersion 22 compileSdkVersion 22
namespace 'org.jetbrains.kotlin.gradle.test.android.libalfa'
} }
kotlin { android("android") { } } kotlin { android("android") { } }
@@ -129,7 +130,6 @@ class KotlinAndroidMppIT : KGPBaseTest() {
@DisplayName("mpp source sets are registered in AGP") @DisplayName("mpp source sets are registered in AGP")
@GradleAndroidTest @GradleAndroidTest
@AndroidTestVersions(minVersion = TestVersions.AGP.AGP_42)
fun testAndroidMppSourceSets( fun testAndroidMppSourceSets(
gradleVersion: GradleVersion, gradleVersion: GradleVersion,
agpVersion: String, agpVersion: String,
@@ -540,10 +540,7 @@ class KotlinAndroidMppIT : KGPBaseTest() {
} }
} }
// AGP max version is limited due to https://youtrack.jetbrains.com/issue/KT-51940/HMPP-resolves-configurations-during-configuration
@DisplayName("android app can depend on mpp lib") @DisplayName("android app can depend on mpp lib")
@AndroidTestVersions(maxVersion = TestVersions.AGP.AGP_72)
@GradleTestVersions(maxVersion = TestVersions.Gradle.G_7_4) // due AGP version limit ^
@GradleAndroidTest @GradleAndroidTest
fun testAndroidWithNewMppApp( fun testAndroidWithNewMppApp(
gradleVersion: GradleVersion, gradleVersion: GradleVersion,
@@ -727,6 +724,9 @@ class KotlinAndroidMppIT : KGPBaseTest() {
//language=Gradle //language=Gradle
""" """
android {
namespace 'app.example.com.lib'
}
kotlin.targets.all { kotlin.targets.all {
compilations.all { compilations.all {
attributes.attribute( attributes.attribute(
@@ -742,6 +742,9 @@ class KotlinAndroidMppIT : KGPBaseTest() {
//language=Gradle //language=Gradle
""" """
android {
namespace 'app.example.com.app_sample'
}
kotlin.targets.androidApp.compilations.all { kotlin.targets.androidApp.compilations.all {
attributes.attribute( attributes.attribute(
Attribute.of("com.example.compilation", String), Attribute.of("com.example.compilation", String),
@@ -28,7 +28,8 @@ class AppleFrameworkIT : BaseGradleIT() {
override val defaultGradleVersion = GradleVersionRequired.FOR_MPP_SUPPORT override val defaultGradleVersion = GradleVersionRequired.FOR_MPP_SUPPORT
override fun defaultBuildOptions() = super.defaultBuildOptions().copy( override fun defaultBuildOptions() = super.defaultBuildOptions().copy(
androidHome = KtTestUtil.findAndroidSdk(), androidHome = KtTestUtil.findAndroidSdk(),
androidGradlePluginVersion = AGPVersion.v4_2_0 androidGradlePluginVersion = AGPVersion.v7_4_0,
javaHome = KtTestUtil.getJdk17Home()
) )
@Test @Test
@@ -98,7 +98,6 @@ class AppleSiliconIT : BaseGradleIT() {
val x64Tests = listOf( val x64Tests = listOf(
":iosX64Test", ":iosX64Test",
":jvmTest",
":macosX64Test", ":macosX64Test",
":tvosX64Test", ":tvosX64Test",
":watchosX64Test", ":watchosX64Test",
@@ -28,7 +28,8 @@ class XCFrameworkIT : BaseGradleIT() {
override val defaultGradleVersion = GradleVersionRequired.FOR_MPP_SUPPORT override val defaultGradleVersion = GradleVersionRequired.FOR_MPP_SUPPORT
override fun defaultBuildOptions() = super.defaultBuildOptions().copy( override fun defaultBuildOptions() = super.defaultBuildOptions().copy(
androidHome = KtTestUtil.findAndroidSdk(), androidHome = KtTestUtil.findAndroidSdk(),
androidGradlePluginVersion = AGPVersion.v4_2_0 androidGradlePluginVersion = AGPVersion.v7_4_0,
javaHome = KtTestUtil.getJdk17Home()
) )
@Test @Test
@@ -22,7 +22,7 @@ interface TestVersions {
const val G_7_6 = "7.6" const val G_7_6 = "7.6"
// https://gradle.org/nightly/ // https://gradle.org/nightly/
// Retention policy is 3 months // Retention policy is 3 months
const val G_8_0 = "8.0-rc-1" const val G_8_0 = "8.0.2"
const val MIN_SUPPORTED = minSupportedGradleVersion const val MIN_SUPPORTED = minSupportedGradleVersion
const val MIN_SUPPORTED_KPM = G_7_0 const val MIN_SUPPORTED_KPM = G_7_0
const val MAX_SUPPORTED = G_7_6 const val MAX_SUPPORTED = G_7_6