azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Minor, update doc on -Xsanitize-parentheses

Browse Source 
The ASM issue with parentheses was fixed in
https://gitlab.ow2.org/asm/asm/commit/02f00c4a82d9252b34d08dad47c540309fda3b7e

 #KT-29475
This commit is contained in:
Alexander Udalov
2019-03-07 12:26:29 +01:00
parent bd6e90f302
commit 5aae832c5f
3 changed files with 5 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/cli/cli-common/src/org/jetbrains/kotlin/cli/common/arguments/K2JVMCompilerArguments.kt
+2 -2
View File
@@ -263,8 +263,8 @@ class K2JVMCompilerArguments : CommonCompilerArguments() {
@Argument( @Argument(
value = "-Xsanitize-parentheses", value = "-Xsanitize-parentheses",
description = "Transform '(' and ')' in method names to some other character sequence.\n" + description = "Transform '(' and ')' in method names to some other character sequence.\n" +
"This mode can BREAK BINARY COMPATIBILITY and is only supposed to be used as a workaround\n" + "This mode can BREAK BINARY COMPATIBILITY and is only supposed to be used to workaround\n" +
"of an issue in the ASM bytecode framework. See KT-29475 for more details" "problems with parentheses in identifiers on certain platforms"
) )
var sanitizeParentheses: Boolean by FreezableVar(false) var sanitizeParentheses: Boolean by FreezableVar(false)
compiler/testData/cli/jvm/extraHelp.out
Vendored
+2 -2
View File
@@ -49,8 +49,8 @@ where advanced options include:
-Xno-param-assertions Don't generate not-null assertions on parameters of methods accessible from Java -Xno-param-assertions Don't generate not-null assertions on parameters of methods accessible from Java
-Xno-receiver-assertions Don't generate not-null assertion for extension receiver arguments of platform types -Xno-receiver-assertions Don't generate not-null assertion for extension receiver arguments of platform types
-Xsanitize-parentheses Transform '(' and ')' in method names to some other character sequence. -Xsanitize-parentheses Transform '(' and ')' in method names to some other character sequence.
This mode can BREAK BINARY COMPATIBILITY and is only supposed to be used as a workaround This mode can BREAK BINARY COMPATIBILITY and is only supposed to be used to workaround
of an issue in the ASM bytecode framework. See KT-29475 for more details problems with parentheses in identifiers on certain platforms
-Xscript-resolver-environment=<key=value[,]> -Xscript-resolver-environment=<key=value[,]>
Script resolver environment in key-value pairs (the value could be quoted and escaped) Script resolver environment in key-value pairs (the value could be quoted and escaped)
-Xsingle-module Combine modules for source files and binary dependencies into a single module -Xsingle-module Combine modules for source files and binary dependencies into a single module
compiler/testData/codegen/box/mangling/parentheses.kt
Vendored
+1 -4
View File
@@ -1,10 +1,7 @@
// !SANITIZE_PARENTHESES // !SANITIZE_PARENTHESES
// IGNORE_BACKEND: JS, JS_IR // IGNORE_BACKEND: JS, JS_IR
// Sanitization is needed here because of an ASM bug: https://gitlab.ow2.org/asm/asm/issues/317868 // Sanitization is needed here because DxChecker reports ParseException on parentheses in names.
// As soon as that bug is fixed and we've updated to the new version of ASM, this test will start to pass without sanitization.
// At that point, we should remove the -Xsanitize-parentheses compiler argument.
// Also don't forget to disable this test on Android where parentheses are not allowed in names
class `()` { class `()` {
fun `()`(): String { fun `()`(): String {