azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIR] KT-54507: Report redundant for abstract interfaces

Browse Source 
^KT-54507 Fixed

Merge-request: KT-MR-8490
Merged-by: Nikolay Lunyak <Nikolay.Lunyak@jetbrains.com>
This commit is contained in:
Nikolay Lunyak
2023-01-30 16:45:20 +00:00
committed by Space Team
parent 7ef7d0e062
commit 5994a99dbb
4 changed files with 41 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/fir/analysis-tests/testData/resolve/extendedCheckers/RedundantModalityModifierChecker.fir.txt
Vendored
+15
View File
@@ -83,6 +83,9 @@ FILE: RedundantModalityModifierChecker.kt
public open override val gav: R|kotlin/Int| = Int(13)
public get(): R|kotlin/Int|
private final fun fan(): R|kotlin/Unit| {
}
}
public final class Final : R|kotlin/Any| {
public constructor(): R|Final| {
@@ -136,3 +139,15 @@ FILE: RedundantModalityModifierChecker.kt
}
public open interface OpenInterface : R|kotlin/Any| {
}
public final class FinalDerived2 : R|Base| {
public constructor(gav: R|kotlin/Int|): R|FinalDerived2| {
super<R|Base|>()
}
public final override val gav: R|kotlin/Int| = R|<local>/gav|
public get(): R|kotlin/Int|
public open override fun bar(): R|kotlin/Unit| {
}
}
compiler/fir/analysis-tests/testData/resolve/extendedCheckers/RedundantModalityModifierChecker.kt
Vendored
+7 -1
View File
@@ -55,6 +55,8 @@ open class OpenDerived : Base() {
override final fun bar() {}
// Redundant open
override <!REDUNDANT_MODALITY_MODIFIER!>open<!> val gav = 13
private <!REDUNDANT_MODALITY_MODIFIER!>final<!> fun fan() {}
}
// Redundant final
<!REDUNDANT_MODALITY_MODIFIER!>final<!> class Final
@@ -78,8 +80,12 @@ abstract class AbstractDerived2 : Interface {
override <!REDUNDANT_MODALITY_MODIFIER!>open<!> val gav = 13
}
// Redundant abstract interface
abstract interface AbstractInterface
<!REDUNDANT_MODALITY_MODIFIER!>abstract<!> interface AbstractInterface
// Redundant final object
<!REDUNDANT_MODALITY_MODIFIER!>final<!> object FinalObject
// Open interface
<!REDUNDANT_MODIFIER_FOR_TARGET!>open<!> interface OpenInterface
class FinalDerived2(override <!REDUNDANT_MODALITY_MODIFIER!>final<!> val gav: Int) : Base() {
override fun bar() {}
}