JVM IR: disable SAM conversion in case type has 'in' projection

... and the corresponding type parameter has a non-trivial (i.e.
non-`Any?`) upper bound.

The best solution here would be to get rid of
`removeExternalProjections` completely, and just use the type of the
argument at the call site, but see KT-52428.

 #KT-51868 Fixed
This commit is contained in:
Alexander Udalov
2022-04-22 00:15:11 +02:00
parent 62c12864f3
commit 584b70719e
14 changed files with 138 additions and 51 deletions
@@ -0,0 +1,47 @@
// IGNORE_BACKEND_FIR: JVM_IR
// FIR status: "ClassCastException: String cannot be cast to StringBuilder".
// FIR always takes the parameter type and erases type projections in it to obtain the SAM type. This is incorrect, see KT-51868 and KT-52428.
// TARGET_BACKEND: JVM
// JVM_TARGET: 1.8
// WITH_STDLIB
// CHECK_BYTECODE_TEXT
// JVM_IR_TEMPLATES
// 0 java/lang/invoke/LambdaMetafactory
// FILE: box.kt
fun box(): String {
var result = "Fail"
val r = Request { obj: CharSequence ->
result = obj as String
}
r.deliver("OK")
return result
}
// FILE: Request.java
public class Request {
private final Consumer<? super StringBuilder> consumer;
public Request(Consumer<? super StringBuilder> consumer) {
this.consumer = consumer;
}
public void deliver(Object response) {
deliverResponse(consumer, response);
}
public <K extends CharSequence> void deliverResponse(final Consumer<K> consumer, Object rawResponse) {
K response = (K) rawResponse;
consumer.accept(response);
}
}
// FILE: Consumer.java
public interface Consumer<T extends CharSequence> {
void accept(T t);
}
@@ -1,10 +1,15 @@
// IGNORE_BACKEND_FIR: JVM_IR
// FIR status: the test passes but LambdaMetafactory is used, so bytecode text check fails.
// In this case FIR behavior is fine but it works because of a hack in
// TARGET_BACKEND: JVM
// JVM_TARGET: 1.8
// SAM_CONVERSIONS: INDY
// CHECK_BYTECODE_TEXT
// JVM_IR_TEMPLATES
// 1 java/lang/invoke/LambdaMetafactory
// 0 java/lang/invoke/LambdaMetafactory
// TODO: restore indy for SAM types with contravariant projections. See KT-52428 for more info.
fun interface Cmp<T> {
fun compare(a: T, b: T): Int