Rewrite GradleDaemonAnalyzerTest
Previously, GradleDaemonAnalyzer reused common IJ infrastructure for highlighting tests (see DaemonAnalyzerTеstCase, ExpectedHighlightingData and such). Unfortunately, this infrastructure had several flaws, mainly around checking expected highlighting against actual one: - overlapping line markers lead to crash (fixed in 193+) - no way to sanitize descriptions of line markers (important for cases where description returns HTML-formatted text, which makes testdata completely unreadable and also drives parser insane) - thrown FileNotFoundException doesn't have a physical file with expected testdata attached, which makes browsing diff a little less convenient (no way to apply changes to expected file) - no easy way to plug-in with additional after-highlighting checks This commit fixes it by overriding doCheckResult and providing custom checking of highlighting/line markers, based on TagsTestDataUtil. Because we don't rely on IJ-checking anymore, we also remove weird hoops with removing/adding testdata markup in checkFiles. Also this commit adds strings sanitization in TagsTestDataUtil, removing HTML-tags and line breaks, so that description of tag is always one-liner with plain text.
This commit is contained in:
+2
-2
@@ -1,3 +1,3 @@
|
||||
expect class <error descr="[NO_ACTUAL_FOR_EXPECT] Expected class 'My' has no actual declaration in module first_jsMain for JS"><lineMarker>My</lineMarker></error> {
|
||||
fun <lineMarker>foo</lineMarker>()
|
||||
expect class <lineMarker descr="Has actuals in JVM"><error descr="[NO_ACTUAL_FOR_EXPECT] Expected class 'My' has no actual declaration in module first_jsMain for JS" textAttributesKey="ERRORS_ATTRIBUTES">My</error></lineMarker> {
|
||||
fun <lineMarker descr="Has actuals in JVM">foo</lineMarker>()
|
||||
}
|
||||
+3
-3
@@ -1,5 +1,5 @@
|
||||
actual class <lineMarker>My</lineMarker> {
|
||||
actual fun <lineMarker>foo</lineMarker>() {}
|
||||
actual class <lineMarker descr="Has declaration in common module">My</lineMarker> {
|
||||
actual fun <lineMarker descr="Has declaration in common module">foo</lineMarker>() {}
|
||||
|
||||
actual fun <error descr="[ACTUAL_WITHOUT_EXPECT] Actual function 'bar' has no corresponding expected declaration">bar</error>() {}
|
||||
actual fun <error descr="[ACTUAL_WITHOUT_EXPECT] Actual function 'bar' has no corresponding expected declaration" textAttributesKey="ERRORS_ATTRIBUTES">bar</error>() {}
|
||||
}
|
||||
Reference in New Issue
Block a user