Rewrite GradleDaemonAnalyzerTest
Previously, GradleDaemonAnalyzer reused common IJ infrastructure for highlighting tests (see DaemonAnalyzerTеstCase, ExpectedHighlightingData and such). Unfortunately, this infrastructure had several flaws, mainly around checking expected highlighting against actual one: - overlapping line markers lead to crash (fixed in 193+) - no way to sanitize descriptions of line markers (important for cases where description returns HTML-formatted text, which makes testdata completely unreadable and also drives parser insane) - thrown FileNotFoundException doesn't have a physical file with expected testdata attached, which makes browsing diff a little less convenient (no way to apply changes to expected file) - no easy way to plug-in with additional after-highlighting checks This commit fixes it by overriding doCheckResult and providing custom checking of highlighting/line markers, based on TagsTestDataUtil. Because we don't rely on IJ-checking anymore, we also remove weird hoops with removing/adding testdata markup in checkFiles. Also this commit adds strings sanitization in TagsTestDataUtil, removing HTML-tags and line breaks, so that description of tag is always one-liner with plain text.
This commit is contained in:
+1
-1
@@ -1,7 +1,7 @@
|
||||
package sample
|
||||
|
||||
expect class <lineMarker descr="Has actuals in JS, JVM">Sample</lineMarker>() {
|
||||
fun <lineMarker>checkMe</lineMarker>(): Int
|
||||
fun <lineMarker descr="Has actuals in JS, JVM">checkMe</lineMarker>(): Int
|
||||
}
|
||||
|
||||
expect object <lineMarker descr="Has actuals in JS, JVM">Platform</lineMarker> {
|
||||
|
||||
+1
-1
@@ -1,4 +1,4 @@
|
||||
package sample
|
||||
fun common(): Boolean {
|
||||
return <error descr="[TYPE_MISMATCH] Type mismatch: inferred type is String but Boolean was expected">""</error>
|
||||
return <error descr="[TYPE_MISMATCH] Type mismatch: inferred type is String but Boolean was expected" textAttributesKey="ERRORS_ATTRIBUTES">""</error>
|
||||
}
|
||||
+1
-1
@@ -2,5 +2,5 @@ package sample
|
||||
|
||||
fun jvm() {
|
||||
println(common())
|
||||
println(<error descr="[UNRESOLVED_REFERENCE] Unresolved reference: js">js</error>())
|
||||
println(<error descr="[UNRESOLVED_REFERENCE] Unresolved reference: js" textAttributesKey="WRONG_REFERENCES_ATTRIBUTES">js</error>())
|
||||
}
|
||||
Reference in New Issue
Block a user