Lint: Fix KT-11924 (False positive on beginTransaction() should be completed with a commit() call)

2016-04-15 19:44:29 +03:00
parent 35fca9171c
commit 574aa5debe
12 changed files with 171 additions and 13 deletions
@@ -0,0 +1,27 @@
+// INSPECTION_CLASS: org.jetbrains.android.inspections.klint.AndroidLintInspectionToolProvider$AndroidKLintCommitTransactionInspection
+
+import android.app.Activity
+import android.app.FragmentTransaction
+import android.os.Bundle
+
+class MainActivity : Activity() {
+
+    override fun onCreate(savedInstanceState: Bundle?) {
+        super.onCreate(savedInstanceState)
+
+        //OK
+        val transaction = fragmentManager.beginTransaction()
+        val transaction2: FragmentTransaction
+        transaction2 = fragmentManager.beginTransaction()
+        transaction.commit()
+        transaction2.commit()
+
+        //WARNING
+        @Suppress("UNUSED_VARIABLE")
+        val transaction3 = fragmentManager.<warning>beginTransaction</warning>()
+
+        //OK
+        fragmentManager.beginTransaction().commit()
+        fragmentManager.beginTransaction().add(null, "A").commit()
+    }
+}