azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Lint: Fix KT-11924 (False positive on beginTransaction() should be completed with a commit() call)

Browse Source
This commit is contained in:
Yan Zhulanow
2016-04-15 19:44:29 +03:00
parent 35fca9171c
commit 574aa5debe
12 changed files with 171 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/lint/lint-checks/src/com/android/tools/klint/checks/CleanupDetector.java
+19 -8
View File
@@ -365,15 +365,16 @@ public class CleanupDetector extends Detector implements UastScanner {
// getFragmentManager().beginTransaction().addToBackStack("test")
// .disallowAddToBackStack().hide(mFragment2).setBreadCrumbShortTitle("test")
// .show(mFragment2).setCustomAnimations(0, 0).commit();
UElement parent = node.getParent();
while (parent instanceof UCallExpression) {
UCallExpression methodInvocation = (UCallExpression) parent;
if (isTransactionCommitMethodCall(context, methodInvocation)
List<UExpression> chains = UastUtils.getQualifiedChains(node);
if (chains.size() > 0) {
UExpression lastExpression = chains.get(chains.size() - 1);
if (lastExpression instanceof UCallExpression) {
UCallExpression methodInvocation = (UCallExpression) lastExpression;
if (isTransactionCommitMethodCall(context, methodInvocation)
|| isShowFragmentMethodCall(context, methodInvocation)) {
return true;
return true;
}
}
parent = parent.getParent();
}
return false;
@@ -413,7 +414,17 @@ public class CleanupDetector extends Detector implements UastScanner {
@Nullable
public static UVariable getVariable(@NonNull UastAndroidContext context,
@NonNull UElement expression) {
UElement parent = expression.getParent();
if (!(expression instanceof UExpression)) {
return null;
}
UQualifiedExpression topMostQualified = UastUtils.findTopMostQualifiedExpression(((UExpression) expression));
if (topMostQualified == null) {
return null;
}
UElement parent = topMostQualified.getParent();
if (parent instanceof UBinaryExpression) {
UBinaryExpression binaryExpression = (UBinaryExpression) parent;
if (binaryExpression.getOperator() == UastBinaryOperator.ASSIGN) {