azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add a point about invalidated state between inspection checks and quick-fix run

Browse Source
This commit is contained in:
Nikolay Krasko
2019-04-01 15:44:41 +03:00
parent 9ab54d0e44
commit 5723bfdcaf
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/intentions_inspections_quickfixes.md
+4
View File
@@ -35,6 +35,10 @@ requires multiple resolve calls in a row.
- Prefer `resolveToDescriptorIfAny()` over `resolveToDesciptor()` because of exceptions that are thrown from latter - Prefer `resolveToDescriptorIfAny()` over `resolveToDesciptor()` because of exceptions that are thrown from latter
function when descriptor is absent. function when descriptor is absent.
- Any checks about code state and resolve that were made during reporting an inspection problem an registering a quick fix might be
invalidated by the moment of the actual quick fix execution. Avoid the code that can throw exceptions because of that. Re-checks with early
exit from the quick fix can be used to workaround it.
- There shouldn't be PSI elements stored in QuickFix classes (`val psi: PsiElement`) as such elements might be invalidated and can lead - There shouldn't be PSI elements stored in QuickFix classes (`val psi: PsiElement`) as such elements might be invalidated and can lead
to memory leaks. Smart pointer (check `SmartPsiElementPointer` class and `createSmartPointer()` function) can be used when such storage to memory leaks. Smart pointer (check `SmartPsiElementPointer` class and `createSmartPointer()` function) can be used when such storage
is absolutely necessary. is absolutely necessary.