[Psi2Ir] Fix generation of IrError* nodes

- Provide detailed description
 - Support syntax-incorrect statements
 - Generate an error declaration if normal generation has failed

compiler/ir/ir.psi2ir/src/org/jetbrains/kotlin/psi2ir/generators/DeclarationGenerator.kt

@@ -39,24 +39,34 @@ class DeclarationGenerator(override val context: GeneratorContext) : Generator {
 
     fun KotlinType.toIrType() = typeTranslator.translateType(this)
 
-    fun generateMemberDeclaration(ktDeclaration: KtDeclaration): IrDeclaration? =
+    fun generateMemberDeclaration(ktDeclaration: KtDeclaration): IrDeclaration? {
-        when (ktDeclaration) {
+        return try {
-            is KtNamedFunction ->
+            when (ktDeclaration) {
-                FunctionGenerator(this).generateFunctionDeclaration(ktDeclaration)
+                is KtNamedFunction ->
-            is KtProperty ->
+                    FunctionGenerator(this).generateFunctionDeclaration(ktDeclaration)
-                PropertyGenerator(this).generatePropertyDeclaration(ktDeclaration)
+                is KtProperty ->
-            is KtClassOrObject ->
+                    PropertyGenerator(this).generatePropertyDeclaration(ktDeclaration)
-                generateClassOrObjectDeclaration(ktDeclaration)
+                is KtClassOrObject ->
-            is KtTypeAlias ->
+                    generateClassOrObjectDeclaration(ktDeclaration)
-                generateTypeAliasDeclaration(ktDeclaration)
+                is KtTypeAlias ->
-            is KtScript ->
+                    generateTypeAliasDeclaration(ktDeclaration)
-                ScriptGenerator(this).generateScriptDeclaration(ktDeclaration)
+                is KtScript ->
-            else ->
+                    ScriptGenerator(this).generateScriptDeclaration(ktDeclaration)
+                else ->
+                    context.irFactory.createErrorDeclaration(
+                        ktDeclaration.startOffsetSkippingComments, ktDeclaration.endOffset,
+                        getOrFail(BindingContext.DECLARATION_TO_DESCRIPTOR, ktDeclaration)
+                    )
+            }
+        } catch (e: Throwable) {
+            if (context.configuration.ignoreErrors) {
                 context.irFactory.createErrorDeclaration(
                     ktDeclaration.startOffsetSkippingComments, ktDeclaration.endOffset,
                     getOrFail(BindingContext.DECLARATION_TO_DESCRIPTOR, ktDeclaration)
                 )
+            } else throw e
         }
+    }
 
     fun generateSyntheticClassOrObject(syntheticDeclaration: KtPureClassOrObject): IrClass {
         return generateClassOrObjectDeclaration(syntheticDeclaration)

compiler/ir/ir.psi2ir/src/org/jetbrains/kotlin/psi2ir/generators/ErrorExpressionGenerator.kt

@@ -27,13 +27,13 @@ import org.jetbrains.kotlin.types.ErrorUtils
 class ErrorExpressionGenerator(statementGenerator: StatementGenerator) : StatementGeneratorExtension(statementGenerator) {
     private val ignoreErrors: Boolean get() = context.configuration.ignoreErrors
 
-    private inline fun generateErrorExpression(ktElement: KtElement, e: Exception? = null, body: () -> IrExpression) =
+    private inline fun generateErrorExpression(ktElement: KtElement, e: Throwable? = null, body: () -> IrExpression) =
         if (ignoreErrors)
             body()
         else
             throw RuntimeException("${e?.message}: ${ktElement::class.java.simpleName}:\n${ktElement.text}", e)
 
-    fun generateErrorExpression(ktElement: KtElement, e: Exception): IrExpression =
+    fun generateErrorExpression(ktElement: KtElement, e: Throwable): IrExpression =
         generateErrorExpression(ktElement, e) {
             val errorExpressionType =
                 if (ktElement is KtExpression)
@@ -43,14 +43,14 @@ class ErrorExpressionGenerator(statementGenerator: StatementGenerator) : Stateme
             IrErrorExpressionImpl(
                 ktElement.startOffsetSkippingComments, ktElement.endOffset,
                 errorExpressionType.toIrType(),
-                e.message ?: ""
+                e.message ?: ktElement.text
             )
         }
 
     fun generateErrorCall(ktCall: KtCallExpression): IrExpression = generateErrorExpression(ktCall) {
         val type = getErrorExpressionType(ktCall).toIrType()
 
-        val irErrorCall = IrErrorCallExpressionImpl(ktCall.startOffsetSkippingComments, ktCall.endOffset, type, "") // TODO problem description?
+        val irErrorCall = IrErrorCallExpressionImpl(ktCall.startOffsetSkippingComments, ktCall.endOffset, type, ktCall.text) // TODO problem description?
         irErrorCall.explicitReceiver = (ktCall.parent as? KtDotQualifiedExpression)?.run {
             receiverExpression.genExpr()
         }
@@ -71,7 +71,7 @@ class ErrorExpressionGenerator(statementGenerator: StatementGenerator) : Stateme
     fun generateErrorSimpleName(ktName: KtSimpleNameExpression): IrExpression = generateErrorExpression(ktName) {
         val type = getErrorExpressionType(ktName).toIrType()
 
-        val irErrorCall = IrErrorCallExpressionImpl(ktName.startOffsetSkippingComments, ktName.endOffset, type, "") // TODO problem description?
+        val irErrorCall = IrErrorCallExpressionImpl(ktName.startOffsetSkippingComments, ktName.endOffset, type, ktName.text) // TODO problem description?
         irErrorCall.explicitReceiver = (ktName.parent as? KtDotQualifiedExpression)?.let { ktParent ->
             if (ktParent.receiverExpression == ktName) null
             else ktParent.receiverExpression.genExpr()

compiler/ir/ir.psi2ir/src/org/jetbrains/kotlin/psi2ir/generators/StatementGenerator.kt

@@ -73,7 +73,7 @@ class StatementGenerator(
     private fun KtElement.genStmt(): IrStatement =
         try {
             deparenthesize().accept(this@StatementGenerator, null)
-        } catch (e: Exception) {
+        } catch (e: Throwable) {
             ErrorExpressionGenerator(this@StatementGenerator).generateErrorExpression(this, e)
         }