KT-7443 Inspection + intention to replace assert (x != null) with "!!" or elvis

#KT-7443 Fixed
This commit is contained in:
Valentin Kipyatkov
2016-01-14 16:20:43 +03:00
parent 5ad4571ddf
commit 552359ce03
30 changed files with 397 additions and 0 deletions
@@ -0,0 +1 @@
org.jetbrains.kotlin.idea.intentions.SimplifyAssertNotNullIntention
@@ -0,0 +1,8 @@
// INTENTION_TEXT: "Replace with '?: error(...)'"
// WITH_RUNTIME
fun foo(p: Array<String?>) {
val v = p[0]
// now let's check it for null
<caret>assert(v != null /* null */, /* lazy message */ { "Should be not null" }) // 'v' should not be null
}
@@ -0,0 +1,8 @@
// INTENTION_TEXT: "Replace with '?: error(...)'"
// WITH_RUNTIME
fun foo(p: Array<String?>) {
val v = p[0] ?: error(/* null */ /* lazy message */"Should be not null")
// now let's check it for null
// 'v' should not be null
}
@@ -0,0 +1,8 @@
// INTENTION_TEXT: "Replace with '!!' operator"
// WITH_RUNTIME
fun foo(p: Array<String?>) {
val v = p[0]
// now let's check it for null
<caret>assert(v != null /* null */) // 'v' should not be null
}
@@ -0,0 +1,8 @@
// INTENTION_TEXT: "Replace with '!!' operator"
// WITH_RUNTIME
fun foo(p: Array<String?>) {
val v = p[0]!!<caret>/* null */
// now let's check it for null
// 'v' should not be null
}
@@ -0,0 +1,7 @@
// IS_APPLICABLE: false
// WITH_RUNTIME
fun foo(p: Array<String?>) {
val v = p[0]
<caret>assert(v != null, { val t = 1; "Should be not null: $t" })
}
@@ -0,0 +1,7 @@
// IS_APPLICABLE: false
// WITH_RUNTIME
fun foo(p: Array<String?>) {
val v = p[0]
<caret>assert(v == null)
}
@@ -0,0 +1,11 @@
// INTENTION_TEXT: "Replace with '?: error(...)'"
// WITH_RUNTIME
class C {
fun error(message: String) { }
fun foo(p: Array<String?>) {
val v = p[0]
<caret>assert(v != null) { "message" }
}
}
@@ -0,0 +1,10 @@
// INTENTION_TEXT: "Replace with '?: error(...)'"
// WITH_RUNTIME
class C {
fun error(message: String) { }
fun foo(p: Array<String?>) {
val v = p[0] <caret>?: kotlin.error("message")
}
}
@@ -0,0 +1,11 @@
// IS_APPLICABLE: false
// WITH_RUNTIME
class C {
fun assert(b: Boolean) { }
fun foo(p: Array<String?>) {
val v = p[0]
<caret>assert(v != null)
}
}
@@ -0,0 +1,7 @@
// INTENTION_TEXT: "Replace with '!!' operator"
// WITH_RUNTIME
fun foo(p: Array<String?>) {
val v = p[0]
<caret>assert(v != null)
}
@@ -0,0 +1,6 @@
// INTENTION_TEXT: "Replace with '!!' operator"
// WITH_RUNTIME
fun foo(p: Array<String?>) {
val v = p[0]!!<caret>
}
@@ -0,0 +1,8 @@
// IS_APPLICABLE: false
// WITH_RUNTIME
fun foo(p: Array<String?>) {
val v1 = p[0]
val v2 = p[1]
<caret>assert(v1 != null)
}
@@ -0,0 +1,9 @@
// IS_APPLICABLE: false
// WITH_RUNTIME
class C(val v: String?) {
fun foo(p: Array<String?>) {
val v = p[0]
<caret>assert(this.v != null)
}
}
@@ -0,0 +1,7 @@
// INTENTION_TEXT: "Replace with '?: error(...)'"
// WITH_RUNTIME
fun foo(p: Array<String?>) {
val v = p[0]
<caret>assert(v != null, { "Should be not null" })
}
@@ -0,0 +1,6 @@
// INTENTION_TEXT: "Replace with '?: error(...)'"
// WITH_RUNTIME
fun foo(p: Array<String?>) {
val v = p[0] <caret>?: error("Should be not null")
}
@@ -0,0 +1,7 @@
// INTENTION_TEXT: "Replace with '?: error(...)'"
// WITH_RUNTIME
fun foo(p: Array<String?>) {
val v = p[0]
<caret>assert(v != null) { "Should be not null" }
}
@@ -0,0 +1,6 @@
// INTENTION_TEXT: "Replace with '?: error(...)'"
// WITH_RUNTIME
fun foo(p: Array<String?>) {
val v = p[0] <caret>?: error("Should be not null")
}