From 54c21ffbf304a6bed43e7760c11716a9454e1937 Mon Sep 17 00:00:00 2001 From: Alexander Udalov Date: Fri, 16 May 2014 20:55:04 +0400 Subject: [PATCH] Delete K*FunctionNImpl classes In favor of KFunctionImpl, KMemberFunctionImpl and KExtensionFunctionImpl --- .../jvm/internal/KExtensionFunctionsImpl.kt | 91 ------------------- .../reflect/jvm/internal/KFunctionsImpl.kt | 91 ------------------- .../jvm/internal/KMemberFunctionsImpl.kt | 91 ------------------- .../jet/generators/builtins/functions.kt | 35 +------ .../generators/builtins/generateBuiltIns.kt | 8 +- 5 files changed, 5 insertions(+), 311 deletions(-) delete mode 100644 core/runtime.jvm/src/kotlin/reflect/jvm/internal/KExtensionFunctionsImpl.kt delete mode 100644 core/runtime.jvm/src/kotlin/reflect/jvm/internal/KFunctionsImpl.kt delete mode 100644 core/runtime.jvm/src/kotlin/reflect/jvm/internal/KMemberFunctionsImpl.kt diff --git a/core/runtime.jvm/src/kotlin/reflect/jvm/internal/KExtensionFunctionsImpl.kt b/core/runtime.jvm/src/kotlin/reflect/jvm/internal/KExtensionFunctionsImpl.kt deleted file mode 100644 index 65b076ef0bc..00000000000 --- a/core/runtime.jvm/src/kotlin/reflect/jvm/internal/KExtensionFunctionsImpl.kt +++ /dev/null @@ -1,91 +0,0 @@ -/* - * Copyright 2010-2014 JetBrains s.r.o. - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -// Auto-generated file. DO NOT EDIT! - -package kotlin.reflect.jvm.internal - -import java.io.Serializable - -public abstract class KExtensionFunction0Impl : KExtensionFunction0, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KExtensionFunction1Impl : KExtensionFunction1, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KExtensionFunction2Impl : KExtensionFunction2, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KExtensionFunction3Impl : KExtensionFunction3, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KExtensionFunction4Impl : KExtensionFunction4, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KExtensionFunction5Impl : KExtensionFunction5, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KExtensionFunction6Impl : KExtensionFunction6, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KExtensionFunction7Impl : KExtensionFunction7, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KExtensionFunction8Impl : KExtensionFunction8, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KExtensionFunction9Impl : KExtensionFunction9, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KExtensionFunction10Impl : KExtensionFunction10, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KExtensionFunction11Impl : KExtensionFunction11, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KExtensionFunction12Impl : KExtensionFunction12, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KExtensionFunction13Impl : KExtensionFunction13, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KExtensionFunction14Impl : KExtensionFunction14, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KExtensionFunction15Impl : KExtensionFunction15, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KExtensionFunction16Impl : KExtensionFunction16, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KExtensionFunction17Impl : KExtensionFunction17, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KExtensionFunction18Impl : KExtensionFunction18, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KExtensionFunction19Impl : KExtensionFunction19, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KExtensionFunction20Impl : KExtensionFunction20, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KExtensionFunction21Impl : KExtensionFunction21, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KExtensionFunction22Impl : KExtensionFunction22, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} diff --git a/core/runtime.jvm/src/kotlin/reflect/jvm/internal/KFunctionsImpl.kt b/core/runtime.jvm/src/kotlin/reflect/jvm/internal/KFunctionsImpl.kt deleted file mode 100644 index fa8c3c5bf0c..00000000000 --- a/core/runtime.jvm/src/kotlin/reflect/jvm/internal/KFunctionsImpl.kt +++ /dev/null @@ -1,91 +0,0 @@ -/* - * Copyright 2010-2014 JetBrains s.r.o. - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -// Auto-generated file. DO NOT EDIT! - -package kotlin.reflect.jvm.internal - -import java.io.Serializable - -public abstract class KFunction0Impl : KFunction0, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KFunction1Impl : KFunction1, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KFunction2Impl : KFunction2, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KFunction3Impl : KFunction3, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KFunction4Impl : KFunction4, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KFunction5Impl : KFunction5, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KFunction6Impl : KFunction6, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KFunction7Impl : KFunction7, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KFunction8Impl : KFunction8, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KFunction9Impl : KFunction9, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KFunction10Impl : KFunction10, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KFunction11Impl : KFunction11, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KFunction12Impl : KFunction12, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KFunction13Impl : KFunction13, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KFunction14Impl : KFunction14, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KFunction15Impl : KFunction15, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KFunction16Impl : KFunction16, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KFunction17Impl : KFunction17, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KFunction18Impl : KFunction18, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KFunction19Impl : KFunction19, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KFunction20Impl : KFunction20, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KFunction21Impl : KFunction21, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KFunction22Impl : KFunction22, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} diff --git a/core/runtime.jvm/src/kotlin/reflect/jvm/internal/KMemberFunctionsImpl.kt b/core/runtime.jvm/src/kotlin/reflect/jvm/internal/KMemberFunctionsImpl.kt deleted file mode 100644 index af64bae9e27..00000000000 --- a/core/runtime.jvm/src/kotlin/reflect/jvm/internal/KMemberFunctionsImpl.kt +++ /dev/null @@ -1,91 +0,0 @@ -/* - * Copyright 2010-2014 JetBrains s.r.o. - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -// Auto-generated file. DO NOT EDIT! - -package kotlin.reflect.jvm.internal - -import java.io.Serializable - -public abstract class KMemberFunction0Impl : KMemberFunction0, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KMemberFunction1Impl : KMemberFunction1, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KMemberFunction2Impl : KMemberFunction2, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KMemberFunction3Impl : KMemberFunction3, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KMemberFunction4Impl : KMemberFunction4, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KMemberFunction5Impl : KMemberFunction5, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KMemberFunction6Impl : KMemberFunction6, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KMemberFunction7Impl : KMemberFunction7, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KMemberFunction8Impl : KMemberFunction8, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KMemberFunction9Impl : KMemberFunction9, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KMemberFunction10Impl : KMemberFunction10, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KMemberFunction11Impl : KMemberFunction11, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KMemberFunction12Impl : KMemberFunction12, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KMemberFunction13Impl : KMemberFunction13, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KMemberFunction14Impl : KMemberFunction14, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KMemberFunction15Impl : KMemberFunction15, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KMemberFunction16Impl : KMemberFunction16, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KMemberFunction17Impl : KMemberFunction17, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KMemberFunction18Impl : KMemberFunction18, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KMemberFunction19Impl : KMemberFunction19, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KMemberFunction20Impl : KMemberFunction20, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KMemberFunction21Impl : KMemberFunction21, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} -public abstract class KMemberFunction22Impl : KMemberFunction22, Serializable { - override fun toString() = "${getClass().getGenericSuperclass()}" -} diff --git a/generators/src/org/jetbrains/jet/generators/builtins/functions.kt b/generators/src/org/jetbrains/jet/generators/builtins/functions.kt index 2b4dacb2c86..9e767276bac 100644 --- a/generators/src/org/jetbrains/jet/generators/builtins/functions.kt +++ b/generators/src/org/jetbrains/jet/generators/builtins/functions.kt @@ -34,16 +34,15 @@ enum class FunctionKind( K_EXTENSION_FUNCTION : FunctionKind("KExtensionFunction", true, "ExtensionFunction") fun getFileName() = (if (isReflection()) "reflect/" else "") + classNamePrefix + "s.kt" - fun getImplFileName() = "reflect/jvm/internal/${classNamePrefix}sImpl.kt" fun getClassName(i: Int) = classNamePrefix + i - fun getImplClassName(i: Int) = classNamePrefix + i + "Impl" fun getSuperClassName(i: Int) = superClassNamePrefix?.plus(i) + fun getPackage() = if (isReflection()) "kotlin.reflect" else "kotlin" - fun isReflection() = superClassNamePrefix != null + fun isReflection() = name() startsWith "K" } -abstract class GenerateFunctionsBase(out: PrintWriter, val kind: FunctionKind): BuiltInsSourceGenerator(out) { - override fun getPackage() = if (kind.isReflection()) "kotlin.reflect" else "kotlin" +class GenerateFunctions(out: PrintWriter, val kind: FunctionKind) : BuiltInsSourceGenerator(out) { + override fun getPackage() = kind.getPackage() fun generateTypeParameters(i: Int, variance: Boolean) { out.print("<") @@ -60,9 +59,7 @@ abstract class GenerateFunctionsBase(out: PrintWriter, val kind: FunctionKind): if (variance) out.print("out ") out.print("R>") } -} -class GenerateFunctions(out: PrintWriter, kind: FunctionKind) : GenerateFunctionsBase(out, kind) { override fun generateBody() { for (i in 0..MAX_PARAM_COUNT) { out.print("public trait " + kind.getClassName(i)) @@ -102,27 +99,3 @@ class GenerateFunctions(out: PrintWriter, kind: FunctionKind) : GenerateFunction out.println("): R") } } - -class GenerateKFunctionsImpl(out: PrintWriter, kind: FunctionKind) : GenerateFunctionsBase(out, kind) { - override fun getPackage() = "kotlin.reflect.jvm.internal" - - override fun generateBody() { - out.println("import java.io.Serializable") - out.println() - for (i in 0..MAX_PARAM_COUNT) { - out.print("public abstract class " + kind.getImplClassName(i)) - generateTypeParameters(i, true) - out.print(" : ") - out.print(kind.getClassName(i)) - generateTypeParameters(i, false) - out.println(", Serializable {") - generateToStringForFunctionImpl() - out.println("}") - } - } - - fun generateToStringForFunctionImpl() { - // TODO: don't generate this in every function, create a common superclass for all functions / extension functions - out.println(" override fun toString() = \"\${getClass().getGenericSuperclass()}\"") - } -} diff --git a/generators/src/org/jetbrains/jet/generators/builtins/generateBuiltIns.kt b/generators/src/org/jetbrains/jet/generators/builtins/generateBuiltIns.kt index b3952068cbf..ae5d506cf84 100644 --- a/generators/src/org/jetbrains/jet/generators/builtins/generateBuiltIns.kt +++ b/generators/src/org/jetbrains/jet/generators/builtins/generateBuiltIns.kt @@ -59,13 +59,7 @@ fun generateBuiltIns(generate: (File, (PrintWriter) -> BuiltInsSourceGenerator) assertExists(RUNTIME_JVM_DIR) for (kind in FunctionKind.values()) { - if (kind.isReflection()) { - generate(File(REFLECTION_DIR, kind.getFileName())) { GenerateFunctions(it, kind) } - generate(File(RUNTIME_JVM_DIR, kind.getImplFileName()), { GenerateKFunctionsImpl(it, kind) }) - } - else { - generate(File(BUILT_INS_SRC_DIR, kind.getFileName())) { GenerateFunctions(it, kind) } - } + generate(File(if (kind.isReflection()) REFLECTION_DIR else BUILT_INS_SRC_DIR, kind.getFileName())) { GenerateFunctions(it, kind) } } generate(File(BUILT_INS_NATIVE_DIR, "Arrays.kt")) { GenerateArrays(it) }