[Build] Add jUnit dependencies in testApiJUnit5 to the implementation configuration

Adding these dependencies to the `api` configuration pollutes classpath for each dependant modules even if it doesn't need them. Instead, the dependencies should be declared more granularly if they're required
#KTI-1349 In Progress
This commit is contained in:
Alexander.Likhachev
2023-08-23 14:04:23 +02:00
committed by Space Team
parent 0ecbb64c64
commit 53fde520d5
45 changed files with 121 additions and 55 deletions
@@ -37,7 +37,7 @@ dependencies {
testApi(project(":kotlin-android-extensions-runtime"))
testApi(projectTests(":compiler:tests-common"))
testApi(project(":kotlin-test:kotlin-test-jvm"))
testApi(libs.junit4)
testImplementation(libs.junit4)
robolectricDependency("org.robolectric:android-all:5.0.2_r3-robolectric-r0")
+2 -1
View File
@@ -20,12 +20,13 @@ dependencies {
testApi(projectTests(":compiler:tests-common-new"))
testImplementation(projectTests(":compiler:tests-common"))
testImplementation(libs.junit4)
testImplementation(libs.junit.jupyter.api)
testCompileOnly(project(":kotlin-reflect-api"))
testRuntimeOnly(project(":kotlin-reflect"))
testRuntimeOnly(project(":core:descriptors.runtime"))
testRuntimeOnly(project(":compiler:fir:fir-serialization"))
testRuntimeOnly(libs.junit.jupyter.engine)
testApi(intellijCore())
}
@@ -83,7 +83,7 @@ dependencies {
testImplementation(projectTests(":generators:test-generator"))
testImplementation(projectTests(":js:js.tests"))
testApi(libs.junit4)
testImplementation(libs.junit4)
testApi(project(":kotlin-test:kotlin-test-jvm"))
// Dependencies for Kotlin/Native test infra:
@@ -9,6 +9,7 @@ dependencies {
testApi(project(":plugins:fir-plugin-prototype"))
testApi(project(":compiler:incremental-compilation-impl"))
testApi(projectTests(":compiler:incremental-compilation-impl"))
testImplementation(libs.junit.jupyter.api)
testCompileOnly(intellijCore())
+3 -1
View File
@@ -28,6 +28,7 @@ dependencies {
testApi(projectTests(":compiler:tests-common-new"))
testApi(projectTests(":compiler:test-infrastructure"))
testApi(projectTests(":compiler:test-infrastructure-utils"))
testImplementation(libs.junit.jupyter.api)
// FIR dependencies
testApi(project(":compiler:fir:checkers"))
@@ -35,8 +36,9 @@ dependencies {
testRuntimeOnly(project(":compiler:fir:fir-serialization"))
testRuntimeOnly(project(":core:descriptors.runtime"))
testRuntimeOnly(libs.junit.jupyter.engine)
testApi(libs.junit4)
testImplementation(libs.junit4)
testRuntimeOnly(libs.guava)
testRuntimeOnly(commonDependency("org.codehaus.woodstox:stax2-api"))
@@ -53,7 +53,7 @@ dependencies {
testRuntimeOnly(commonDependency("com.fasterxml:aalto-xml"))
testRuntimeOnly("com.jetbrains.intellij.platform:util-xml-dom:$intellijVersion") { isTransitive = false }
testApi(libs.junit4)
testImplementation(libs.junit4)
robolectricDependency("org.robolectric:android-all:5.0.2_r3-robolectric-r0")
@@ -32,7 +32,7 @@ dependencies {
testApi(project(":compiler:cli-common"))
testApi(project(":compiler:frontend.java"))
testApi(projectTests(":compiler:tests-common"))
testApi(libs.junit4)
testImplementation(libs.junit4)
}
sourceSets {
@@ -32,7 +32,7 @@ dependencies {
testApi(project(":compiler:cli-common"))
testApi(project(":compiler:frontend.java"))
testApi(projectTests(":compiler:tests-common"))
testApi(libs.junit4)
testImplementation(libs.junit4)
testImplementation(intellijCore())
testImplementation(commonDependency("org.jetbrains.kotlinx", "kotlinx-coroutines-core"))