Introduce "Function with = { ... }" inspection

#KT-17119 Fixed

idea/testData/inspectionsLocal/functionWithLambdaExpressionBody/.inspection

@@ -0,0 +1 @@
+org.jetbrains.kotlin.idea.inspections.FunctionWithLambdaExpressionBodyInspection

idea/testData/inspectionsLocal/functionWithLambdaExpressionBody/addArrow/function.kt

@@ -0,0 +1,2 @@
+// FIX: Specify explicit lambda signature
+fun test(a: Int, b: Int) = <caret>{ a + b }

idea/testData/inspectionsLocal/functionWithLambdaExpressionBody/addArrow/function.kt.after

@@ -0,0 +1,2 @@
+// FIX: Specify explicit lambda signature
+fun test(a: Int, b: Int) = { -> a + b }

idea/testData/inspectionsLocal/functionWithLambdaExpressionBody/addArrow/getter.kt

@@ -0,0 +1,2 @@
+// FIX: Specify explicit lambda signature
+val test get() = <caret>{ "" }

idea/testData/inspectionsLocal/functionWithLambdaExpressionBody/addArrow/getter.kt.after

@@ -0,0 +1,2 @@
+// FIX: Specify explicit lambda signature
+val test get() = { -> "" }

idea/testData/inspectionsLocal/functionWithLambdaExpressionBody/functionHasArrow.kt

@@ -0,0 +1,2 @@
+// PROBLEM: none
+fun test(a: Int, b: Int) = <caret>{ -> a + b }

idea/testData/inspectionsLocal/functionWithLambdaExpressionBody/functionHasLabel.kt

@@ -0,0 +1,4 @@
+// PROBLEM: none
+fun test(a: Int, b: Int) = label@<caret>{
+    return@label
+}

idea/testData/inspectionsLocal/functionWithLambdaExpressionBody/functionHasNoExpressionBody.kt

@@ -0,0 +1,2 @@
+// PROBLEM: none
+fun test(a: Int, b: Int) <caret>{ { a + b } }

idea/testData/inspectionsLocal/functionWithLambdaExpressionBody/functionHasNoLambda.kt

@@ -0,0 +1,2 @@
+// PROBLEM: none
+fun test(a: Int, b: Int) = <caret>a + b

idea/testData/inspectionsLocal/functionWithLambdaExpressionBody/functionHasType.kt

@@ -0,0 +1,2 @@
+// PROBLEM: none
+fun test(a: Int, b: Int): () -> Int = <caret>{ a + b }

idea/testData/inspectionsLocal/functionWithLambdaExpressionBody/getterHasArrow.kt

@@ -0,0 +1,2 @@
+// PROBLEM: none
+val test get() = <caret>{ -> "" }

idea/testData/inspectionsLocal/functionWithLambdaExpressionBody/getterHasLabel.kt

@@ -0,0 +1,5 @@
+// PROBLEM: none
+val test
+    get() = label@<caret>{
+        return@label
+    }

idea/testData/inspectionsLocal/functionWithLambdaExpressionBody/getterHasNoLambda.kt

@@ -0,0 +1,2 @@
+// PROBLEM: none
+val test get() = <caret>""

idea/testData/inspectionsLocal/functionWithLambdaExpressionBody/getterHasType.kt

@@ -0,0 +1,2 @@
+// PROBLEM: none
+val test: () -> String get() = <caret>{ "" }

idea/testData/inspectionsLocal/functionWithLambdaExpressionBody/getterHasType2.kt

@@ -0,0 +1,2 @@
+// PROBLEM: none
+val test get(): () -> String = <caret>{ "" }

idea/testData/inspectionsLocal/functionWithLambdaExpressionBody/removeBraces/function.kt

@@ -0,0 +1,2 @@
+// FIX: Remove braces
+fun test(a: Int, b: Int) = <caret>{ a + b }

idea/testData/inspectionsLocal/functionWithLambdaExpressionBody/removeBraces/function.kt.after

@@ -0,0 +1,2 @@
+// FIX: Remove braces
+fun test(a: Int, b: Int) = a + b

idea/testData/inspectionsLocal/functionWithLambdaExpressionBody/removeBraces/functionReturnsNothing.kt

@@ -0,0 +1,3 @@
+// FIX: Remove braces
+// WITH_RUNTIME
+fun test() = <caret>{ error("") }

idea/testData/inspectionsLocal/functionWithLambdaExpressionBody/removeBraces/functionReturnsNothing.kt.after

@@ -0,0 +1,3 @@
+// FIX: Remove braces
+// WITH_RUNTIME
+fun test(): Nothing = error("")

idea/testData/inspectionsLocal/functionWithLambdaExpressionBody/removeBraces/getter.kt

@@ -0,0 +1,2 @@
+// FIX: Remove braces
+val test get() = <caret>{ "" }

idea/testData/inspectionsLocal/functionWithLambdaExpressionBody/removeBraces/getter.kt.after

@@ -0,0 +1,2 @@
+// FIX: Remove braces
+val test get() = ""

idea/testData/inspectionsLocal/functionWithLambdaExpressionBody/removeBraces/getterReturnsNothing.kt

@@ -0,0 +1,3 @@
+// FIX: Remove braces
+// WITH_RUNTIME
+val test get() = <caret>{ error("") }

idea/testData/inspectionsLocal/functionWithLambdaExpressionBody/removeBraces/getterReturnsNothing.kt.after

@@ -0,0 +1,3 @@
+// FIX: Remove braces
+// WITH_RUNTIME
+val test: Nothing get() = error("")

idea/testData/inspectionsLocal/functionWithLambdaExpressionBody/specifyType/function.kt

@@ -0,0 +1,2 @@
+// FIX: Specify return type explicitly
+fun test(a: Int, b: Int) = <caret>{ a + b }

idea/testData/inspectionsLocal/functionWithLambdaExpressionBody/specifyType/function.kt.after

@@ -0,0 +1,2 @@
+// FIX: Specify return type explicitly
+fun test(a: Int, b: Int): () -> Int = { a + b }

idea/testData/inspectionsLocal/functionWithLambdaExpressionBody/specifyType/getter.kt

@@ -0,0 +1,2 @@
+// FIX: Specify type explicitly
+val test get() = <caret>{ "" }

idea/testData/inspectionsLocal/functionWithLambdaExpressionBody/specifyType/getter.kt.after

@@ -0,0 +1,2 @@
+// FIX: Specify type explicitly
+val test: () -> String get() = { "" }

idea/testData/inspectionsLocal/functionWithLambdaExpressionBody/wrapRun/function.kt

@@ -0,0 +1,3 @@
+// FIX: Convert to run { ... }
+// WITH_RUNTIME
+fun test(a: Int, b: Int) = <caret>{ a + b }

idea/testData/inspectionsLocal/functionWithLambdaExpressionBody/wrapRun/function.kt.after

@@ -0,0 +1,3 @@
+// FIX: Convert to run { ... }
+// WITH_RUNTIME
+fun test(a: Int, b: Int) = run { a + b }

idea/testData/inspectionsLocal/functionWithLambdaExpressionBody/wrapRun/functionReturnsNothing.kt

@@ -0,0 +1,3 @@
+// FIX: Convert to run { ... }
+// WITH_RUNTIME
+fun test() = <caret>{ error("") }

idea/testData/inspectionsLocal/functionWithLambdaExpressionBody/wrapRun/functionReturnsNothing.kt.after

@@ -0,0 +1,3 @@
+// FIX: Convert to run { ... }
+// WITH_RUNTIME
+fun test(): Nothing = run { error("") }

idea/testData/inspectionsLocal/functionWithLambdaExpressionBody/wrapRun/getter.kt

@@ -0,0 +1,3 @@
+// FIX: Convert to run { ... }
+// WITH_RUNTIME
+val test get() = <caret>{ "" }

idea/testData/inspectionsLocal/functionWithLambdaExpressionBody/wrapRun/getter.kt.after

@@ -0,0 +1,3 @@
+// FIX: Convert to run { ... }
+// WITH_RUNTIME
+val test get() = run { "" }

idea/testData/inspectionsLocal/functionWithLambdaExpressionBody/wrapRun/getterReturnsNothing.kt

@@ -0,0 +1,3 @@
+// FIX: Convert to run { ... }
+// WITH_RUNTIME
+val test get() = <caret>{ error("") }

idea/testData/inspectionsLocal/functionWithLambdaExpressionBody/wrapRun/getterReturnsNothing.kt.after

@@ -0,0 +1,3 @@
+// FIX: Convert to run { ... }
+// WITH_RUNTIME
+val test: Nothing get() = run { error("") }

idea/testData/quickfix/functionWithLambdaExpressionBody/removeBraces/functionHasComment.kt

@@ -0,0 +1,11 @@
+// "Remove braces" "false"
+// TOOL: org.jetbrains.kotlin.idea.inspections.FunctionWithLambdaExpressionBodyInspection
+// ACTION: Convert to block body
+// ACTION: Convert to run { ... }
+// ACTION: Specify explicit lambda signature
+// ACTION: Specify explicit lambda signature
+// ACTION: Specify return type explicitly
+fun test(a: Int, b: Int) = <caret>{
+    // comment
+    ""
+}

idea/testData/quickfix/functionWithLambdaExpressionBody/removeBraces/functionHasMultiStatements.kt

@@ -0,0 +1,13 @@
+// "Remove braces" "false"
+// TOOL: org.jetbrains.kotlin.idea.inspections.FunctionWithLambdaExpressionBodyInspection
+// ACTION: Convert to block body
+// ACTION: Convert to run { ... }
+// ACTION: Specify explicit lambda signature
+// ACTION: Specify explicit lambda signature
+// ACTION: Specify return type explicitly
+fun test(a: Int, b: Int) = <caret>{
+    foo()
+    foo()
+}
+
+fun foo() {}

idea/testData/quickfix/functionWithLambdaExpressionBody/removeBraces/functionHasNoStatement.kt

@@ -0,0 +1,8 @@
+// "Remove braces" "false"
+// TOOL: org.jetbrains.kotlin.idea.inspections.FunctionWithLambdaExpressionBodyInspection
+// ACTION: Convert to block body
+// ACTION: Convert to run { ... }
+// ACTION: Specify explicit lambda signature
+// ACTION: Specify explicit lambda signature
+// ACTION: Specify return type explicitly
+fun test(a: Int, b: Int) = <caret>{}

idea/testData/quickfix/functionWithLambdaExpressionBody/removeBraces/funtionIsUsed.kt

@@ -0,0 +1,9 @@
+// "Remove braces" "false"
+// TOOL: org.jetbrains.kotlin.idea.inspections.FunctionWithLambdaExpressionBodyInspection
+// ACTION: Convert to block body
+// ACTION: Specify explicit lambda signature
+// ACTION: Specify explicit lambda signature
+// ACTION: Specify return type explicitly
+fun test(a: Int, b: Int) = <caret>{ a + b }
+
+val foo = test(1, 2)()

idea/testData/quickfix/functionWithLambdaExpressionBody/removeBraces/getterHasComment.kt

@@ -0,0 +1,13 @@
+// "Remove braces" "false"
+// TOOL: org.jetbrains.kotlin.idea.inspections.FunctionWithLambdaExpressionBodyInspection
+// ACTION: Convert property getter to initializer
+// ACTION: Convert to block body
+// ACTION: Convert to run { ... }
+// ACTION: Specify explicit lambda signature
+// ACTION: Specify explicit lambda signature
+// ACTION: Specify type explicitly
+// ACTION: Specify type explicitly
+val test get() = <caret>{
+    // comment
+    ""
+}

idea/testData/quickfix/functionWithLambdaExpressionBody/removeBraces/getterHasMultiStatements.kt

@@ -0,0 +1,15 @@
+// "Remove braces" "false"
+// TOOL: org.jetbrains.kotlin.idea.inspections.FunctionWithLambdaExpressionBodyInspection
+// ACTION: Convert property getter to initializer
+// ACTION: Convert to block body
+// ACTION: Convert to run { ... }
+// ACTION: Specify explicit lambda signature
+// ACTION: Specify explicit lambda signature
+// ACTION: Specify type explicitly
+// ACTION: Specify type explicitly
+val test get() = <caret>{
+    foo()
+    foo()
+}
+
+fun foo() {}

idea/testData/quickfix/functionWithLambdaExpressionBody/removeBraces/getterHasNoStatement.kt

@@ -0,0 +1,10 @@
+// "Remove braces" "false"
+// TOOL: org.jetbrains.kotlin.idea.inspections.FunctionWithLambdaExpressionBodyInspection
+// ACTION: Convert property getter to initializer
+// ACTION: Convert to block body
+// ACTION: Convert to run { ... }
+// ACTION: Specify explicit lambda signature
+// ACTION: Specify explicit lambda signature
+// ACTION: Specify type explicitly
+// ACTION: Specify type explicitly
+val test get() = <caret>{}

idea/testData/quickfix/functionWithLambdaExpressionBody/removeBraces/getterIsUsed.kt

@@ -0,0 +1,13 @@
+// "Remove braces" "false"
+// TOOL: org.jetbrains.kotlin.idea.inspections.FunctionWithLambdaExpressionBodyInspection
+// ACTION: Convert property getter to initializer
+// ACTION: Convert to block body
+// ACTION: Specify explicit lambda signature
+// ACTION: Specify explicit lambda signature
+// ACTION: Specify type explicitly
+// ACTION: Specify type explicitly
+val test get() = <caret>{ "" }
+
+fun foo() {
+    test()
+}

idea/testData/quickfix/functionWithLambdaExpressionBody/wrapRun/funtionIsUsed.kt

@@ -0,0 +1,9 @@
+// "Convert to run { ... }" "false"
+// TOOL: org.jetbrains.kotlin.idea.inspections.FunctionWithLambdaExpressionBodyInspection
+// ACTION: Convert to block body
+// ACTION: Specify explicit lambda signature
+// ACTION: Specify explicit lambda signature
+// ACTION: Specify return type explicitly
+fun test(a: Int, b: Int) = <caret>{ a + b }
+
+val foo = test(1, 2)()

idea/testData/quickfix/functionWithLambdaExpressionBody/wrapRun/getterIsUsed.kt

@@ -0,0 +1,13 @@
+// "Convert to run { ... }" "false"
+// TOOL: org.jetbrains.kotlin.idea.inspections.FunctionWithLambdaExpressionBodyInspection
+// ACTION: Convert property getter to initializer
+// ACTION: Convert to block body
+// ACTION: Specify explicit lambda signature
+// ACTION: Specify explicit lambda signature
+// ACTION: Specify type explicitly
+// ACTION: Specify type explicitly
+val test get() = <caret>{ "" }
+
+fun foo() {
+    test()
+}