Implement module detection for Gradle IC with Android

#KT-22431 fixed
This commit is contained in:
Alexey Tsvetkov
2018-05-17 05:34:07 +03:00
parent e5cdc64f4f
commit 53266300d4
9 changed files with 110 additions and 51 deletions
@@ -157,6 +157,25 @@ fun getSomething() = 10
}
}
@Test
fun testMultiModuleIC() {
val project = Project("AndroidProject", gradleVersion)
val options = defaultBuildOptions().copy(incremental = true)
project.build("assembleDebug", options = options) {
assertSuccessful()
}
val libUtilKt = project.projectDir.getFileByName("libUtil.kt")
libUtilKt.modify { it.replace("fun libUtil(): String", "fun libUtil(): CharSequence") }
project.build("assembleDebug", options = options) {
assertSuccessful()
val affectedSources = project.projectDir.getFilesByNames("libUtil.kt", "MainActivity2.kt")
assertCompiledKotlinSources(project.relativize(affectedSources), weakTesting = false)
}
}
@Test
fun testIncrementalBuildWithNoChanges() {
val project = Project("AndroidIncrementalSingleModuleProject", gradleVersion)
@@ -9,18 +9,6 @@ import org.junit.Test
import java.io.File
class IncrementalCompilationMultiProjectIT : BaseGradleIT() {
companion object {
private val ANDROID_GRADLE_PLUGIN_VERSION = "1.5.+"
}
private fun androidBuildOptions() =
BuildOptions(
withDaemon = true,
androidHome = KotlinTestUtils.findAndroidSdk(),
androidGradlePluginVersion = ANDROID_GRADLE_PLUGIN_VERSION,
incremental = true
)
override fun defaultBuildOptions(): BuildOptions =
super.defaultBuildOptions().copy(withDaemon = true, incremental = true)
@@ -201,25 +189,6 @@ open class A {
assertCompiledKotlinSources(relativePaths, weakTesting = false)
}
}
@Test
fun testAndroid() {
val project = Project("AndroidProject", GradleVersionRequired.Exact("2.10"))
val options = androidBuildOptions()
project.build("assembleDebug", options = options) {
assertSuccessful()
}
val libUtilKt = project.projectDir.getFileByName("libUtil.kt")
libUtilKt.modify { it.replace("fun libUtil(): String", "fun libUtil(): None") }
project.build("assembleDebug", options = options) {
assertSuccessful()
val affectedSources = project.projectDir.getFilesByNames("libUtil.kt", "MainActivity2.kt")
assertCompiledKotlinSources(project.relativize(affectedSources), weakTesting = false)
}
}
}
class IncrementalJavaChangeDefaultIT : IncrementalCompilationJavaChangesBase(usePreciseJavaTracking = null) {
@@ -3,6 +3,7 @@ package org.jetbrains.kotlin.compilerRunner
import org.jetbrains.kotlin.annotation.AnnotationFileUpdater
import org.jetbrains.kotlin.cli.common.arguments.CommonCompilerArguments
import org.jetbrains.kotlin.config.Services
import org.jetbrains.kotlin.daemon.common.MultiModuleICSettings
import org.jetbrains.kotlin.gradle.tasks.GradleMessageCollector
import org.jetbrains.kotlin.gradle.tasks.findToolsJar
import org.jetbrains.kotlin.incremental.ChangedFiles
@@ -31,8 +32,8 @@ internal class GradleIncrementalCompilerEnvironment(
messageCollector: GradleMessageCollector,
outputItemsCollector: OutputItemsCollector,
compilerArgs: CommonCompilerArguments,
val buildHistoryFile: File,
val kaptAnnotationsFileUpdater: AnnotationFileUpdater? = null,
val usePreciseJavaTracking: Boolean = false,
val localStateDirs: List<File> = emptyList()
val localStateDirs: List<File> = emptyList(),
val multiModuleICSettings: MultiModuleICSettings
) : GradleCompilerEnvironment(compilerClasspath, messageCollector, outputItemsCollector, compilerArgs)
@@ -275,7 +275,7 @@ internal class GradleCompilerRunner(private val project: Project) : KotlinCompil
targetPlatform = targetPlatform,
usePreciseJavaTracking = environment.usePreciseJavaTracking,
localStateDirs = environment.localStateDirs,
buildHistoryFile = environment.buildHistoryFile,
multiModuleICSettings = environment.multiModuleICSettings,
modulesInfo = buildModulesInfo(project.gradle)
)
@@ -35,6 +35,7 @@ import org.jetbrains.kotlin.cli.common.messages.CompilerMessageLocation
import org.jetbrains.kotlin.cli.common.messages.CompilerMessageSeverity
import org.jetbrains.kotlin.cli.common.messages.MessageCollector
import org.jetbrains.kotlin.compilerRunner.*
import org.jetbrains.kotlin.daemon.common.MultiModuleICSettings
import org.jetbrains.kotlin.gradle.dsl.*
import org.jetbrains.kotlin.gradle.internal.CompilerArgumentAwareWithInput
import org.jetbrains.kotlin.gradle.internal.prepareCompilerArguments
@@ -99,6 +100,13 @@ abstract class AbstractKotlinCompile<T : CommonCompilerArguments>() : AbstractKo
@get:Internal
internal val buildHistoryFile: File get() = File(taskBuildDirectory, "build-history.bin")
@get:Input
internal var useModuleDetection: Boolean = false
@get:Internal
protected val multiModuleICSettings: MultiModuleICSettings
get() = MultiModuleICSettings(buildHistoryFile, useModuleDetection)
@get:Internal
internal val pluginOptions = CompilerPluginOptions()
@@ -353,11 +361,10 @@ open class KotlinCompile : AbstractKotlinCompile<K2JVMCompilerArguments>(), Kotl
computedCompilerClasspath,
if (hasFilesInTaskBuildDirectory()) changedFiles else ChangedFiles.Unknown(),
taskBuildDirectory,
messageCollector, outputItemCollector, args,
buildHistoryFile = buildHistoryFile,
kaptAnnotationsFileUpdater = kaptAnnotationsFileUpdater,
messageCollector, outputItemCollector, args, kaptAnnotationsFileUpdater,
usePreciseJavaTracking = usePreciseJavaTracking,
localStateDirs = outputDirectories
localStateDirs = outputDirectories,
multiModuleICSettings = multiModuleICSettings
)
}
}
@@ -509,7 +516,7 @@ open class Kotlin2JsCompile() : AbstractKotlinCompile<K2JSCompilerArguments>(),
if (hasFilesInTaskBuildDirectory()) changedFiles else ChangedFiles.Unknown(),
taskBuildDirectory,
messageCollector, outputItemCollector, args,
buildHistoryFile = buildHistoryFile
multiModuleICSettings = multiModuleICSettings
)
}
else -> {
@@ -22,25 +22,29 @@ import org.jetbrains.kotlin.gradle.plugin.TaskToFriendTaskMapper
import org.jetbrains.kotlin.gradle.plugin.mapKotlinTaskProperties
internal open class KotlinTasksProvider {
fun createKotlinJVMTask(project: Project, name: String, sourceSetName: String): KotlinCompile =
open fun createKotlinJVMTask(project: Project, name: String, sourceSetName: String): KotlinCompile =
project.tasks.create(name, KotlinCompile::class.java).apply {
configure(project, sourceSetName)
configure(this, project, sourceSetName)
}
fun createKotlinJSTask(project: Project, name: String, sourceSetName: String): Kotlin2JsCompile =
project.tasks.create(name, Kotlin2JsCompile::class.java).apply {
configure(project, sourceSetName)
configure(this, project, sourceSetName)
}
fun createKotlinCommonTask(project: Project, name: String, sourceSetName: String): KotlinCompileCommon =
project.tasks.create(name, KotlinCompileCommon::class.java).apply {
configure(project, sourceSetName)
configure(this, project, sourceSetName)
}
private fun AbstractKotlinCompile<*>.configure(project: Project, sourceSetName: String) {
this.sourceSetName = sourceSetName
this.friendTaskName = taskToFriendTaskMapper[this]
mapKotlinTaskProperties(project, this)
open fun configure(
kotlinTask: AbstractKotlinCompile<*>,
project: Project,
sourceSetName: String
) {
kotlinTask.sourceSetName = sourceSetName
kotlinTask.friendTaskName = taskToFriendTaskMapper[kotlinTask]
mapKotlinTaskProperties(project, kotlinTask)
}
protected open val taskToFriendTaskMapper: TaskToFriendTaskMapper =
@@ -60,4 +64,9 @@ internal class Kotlin2JsTasksProvider : KotlinTasksProvider() {
internal class AndroidTasksProvider : KotlinTasksProvider() {
override val taskToFriendTaskMapper: TaskToFriendTaskMapper =
RegexTaskToFriendTaskMapper.Android()
override fun configure(kotlinTask: AbstractKotlinCompile<*>, project: Project, sourceSetName: String) {
super.configure(kotlinTask, project, sourceSetName)
kotlinTask.useModuleDetection = true
}
}