azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

FIR checker: report tailrec problems on the keyword

Browse Source 
FE1.0 reports it on the declaration signature. This is not ideal so we
move it to the `tailrec` keyword in FIR.
This commit is contained in:
Tianyu Geng
2021-09-23 20:34:27 -07:00
committed by teamcityserver
parent 922ae607f6
commit 5252effb10
26 changed files with 86 additions and 74 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/testData/codegen/box/diagnostics/functions/tailRecursion/functionWithNoTails.kt
Vendored
+1 -1
View File
@@ -6,7 +6,7 @@
// DONT_RUN_GENERATED_CODE: JS
// IGNORE_BACKEND: JS
<!NO_TAIL_CALLS_FOUND!>tailrec fun noTails()<!> {
<!NO_TAIL_CALLS_FOUND!>tailrec<!> fun noTails() {
// nothing here
}
compiler/testData/codegen/box/diagnostics/functions/tailRecursion/labeledThisReferences.kt
Vendored
+1 -1
View File
@@ -16,7 +16,7 @@ class B {
}
}
<!NO_TAIL_CALLS_FOUND!>tailrec fun h2(x : Any)<!> {
<!NO_TAIL_CALLS_FOUND!>tailrec<!> fun h2(x : Any) {
this@B.h2("no recursion") // keep vigilance
}
compiler/testData/codegen/box/diagnostics/functions/tailRecursion/recursiveCallInLambda.kt
Vendored
+1 -1
View File
@@ -8,7 +8,7 @@
// DONT_RUN_GENERATED_CODE: JS
// IGNORE_BACKEND: JS
<!NO_TAIL_CALLS_FOUND!>tailrec fun foo()<!> {
<!NO_TAIL_CALLS_FOUND!>tailrec<!> fun foo() {
bar {
<!NON_TAIL_RECURSIVE_CALL!>foo<!>()
}
compiler/testData/codegen/box/diagnostics/functions/tailRecursion/recursiveCallInLocalFunction.kt
Vendored
+1 -1
View File
@@ -6,7 +6,7 @@
// DONT_RUN_GENERATED_CODE: JS
// IGNORE_BACKEND: JS
<!NO_TAIL_CALLS_FOUND!>tailrec fun foo()<!> {
<!NO_TAIL_CALLS_FOUND!>tailrec<!> fun foo() {
fun bar() {
<!NON_TAIL_RECURSIVE_CALL!>foo<!>()
}
compiler/testData/codegen/box/diagnostics/functions/tailRecursion/returnInCatch.kt
Vendored
+1 -1
View File
@@ -6,7 +6,7 @@
// DONT_RUN_GENERATED_CODE: JS
// IGNORE_BACKEND: JS
<!NO_TAIL_CALLS_FOUND!>tailrec fun test(counter : Int) : Int<!> {
<!NO_TAIL_CALLS_FOUND!>tailrec<!> fun test(counter : Int) : Int {
if (counter == 0) return 0
try {
compiler/testData/codegen/box/diagnostics/functions/tailRecursion/returnInFinally.kt
Vendored
+1 -1
View File
@@ -6,7 +6,7 @@
// DONT_RUN_GENERATED_CODE: JS
// IGNORE_BACKEND: JS
<!NO_TAIL_CALLS_FOUND!>tailrec fun test(counter : Int) : Int<!> {
<!NO_TAIL_CALLS_FOUND!>tailrec<!> fun test(counter : Int) : Int {
if (counter == 0) return 0
try {
compiler/testData/codegen/box/diagnostics/functions/tailRecursion/returnInIfInFinally.kt
Vendored
+1 -1
View File
@@ -6,7 +6,7 @@
// DONT_RUN_GENERATED_CODE: JS
// IGNORE_BACKEND: JS
<!NO_TAIL_CALLS_FOUND!>tailrec fun test(counter : Int) : Int<!> {
<!NO_TAIL_CALLS_FOUND!>tailrec<!> fun test(counter : Int) : Int {
if (counter == 0) return 0
try {
compiler/testData/codegen/box/diagnostics/functions/tailRecursion/returnInTry.kt
Vendored
+1 -1
View File
@@ -6,7 +6,7 @@
// DONT_RUN_GENERATED_CODE: JS
// IGNORE_BACKEND: JS
<!NO_TAIL_CALLS_FOUND!>tailrec fun test(counter : Int) : Int<!> {
<!NO_TAIL_CALLS_FOUND!>tailrec<!> fun test(counter : Int) : Int {
if (counter == 0) return 0
try {
compiler/testData/codegen/box/diagnostics/functions/tailRecursion/tailRecursionInFinally.kt
Vendored
+1 -1
View File
@@ -6,7 +6,7 @@
// DONT_RUN_GENERATED_CODE: JS
// IGNORE_BACKEND: JS
<!NO_TAIL_CALLS_FOUND!>tailrec fun test(go: Boolean) : Unit<!> {
<!NO_TAIL_CALLS_FOUND!>tailrec<!> fun test(go: Boolean) : Unit {
if (!go) return
try {
<!TAIL_RECURSION_IN_TRY_IS_NOT_SUPPORTED!>test<!>(false)
compiler/testData/codegen/box/diagnostics/functions/tailRecursion/thisReferences.kt
Vendored
+1 -1
View File
@@ -19,7 +19,7 @@ class A {
}
}
<!NO_TAIL_CALLS_FOUND!>tailrec fun f3(a : A)<!> {
<!NO_TAIL_CALLS_FOUND!>tailrec<!> fun f3(a : A) {
a.<!NON_TAIL_RECURSIVE_CALL!>f3<!>(a) // non-tail recursion, could be potentially resolved by condition if (a == this) f3() else a.f3()
}
}