azalea/kotlin-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Lift return or assignment: use register...WithoutOfflineInformation

Browse Source
This commit is contained in:
Mikhail Glukhikh
2017-12-07 16:57:22 +03:00
parent a375500a33
commit 5252cd4da4
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
idea/src/org/jetbrains/kotlin/idea/inspections/LiftReturnOrAssignmentInspection.kt
+2 -1
View File
@@ -37,9 +37,10 @@ class LiftReturnOrAssignmentInspection : AbstractKotlinInspection() {
val foldableReturns = BranchedFoldingUtils.getFoldableReturns(expression) val foldableReturns = BranchedFoldingUtils.getFoldableReturns(expression)
if (foldableReturns?.isNotEmpty() == true) { if (foldableReturns?.isNotEmpty() == true) {
val hasOtherReturns = expression.anyDescendantOfType<KtReturnExpression> { it !in foldableReturns } val hasOtherReturns = expression.anyDescendantOfType<KtReturnExpression> { it !in foldableReturns }
holder.registerProblem( holder.registerProblemWithoutOfflineInformation(
keyword, keyword,
"Return can be lifted out of '${keyword.text}'", "Return can be lifted out of '${keyword.text}'",
isOnTheFly,
if (!hasOtherReturns && foldableReturns.size > 1) ProblemHighlightType.GENERIC_ERROR_OR_WARNING if (!hasOtherReturns && foldableReturns.size > 1) ProblemHighlightType.GENERIC_ERROR_OR_WARNING
else ProblemHighlightType.INFORMATION, else ProblemHighlightType.INFORMATION,
LiftReturnOutFix(keyword.text) LiftReturnOutFix(keyword.text)