diff --git a/idea/testData/refactoring/introduceVariable/ArrayAccessExpr.kt b/idea/testData/refactoring/introduceVariable/ArrayAccessExpr.kt index 52b4a8ef50e..fbf1aaa74c4 100644 --- a/idea/testData/refactoring/introduceVariable/ArrayAccessExpr.kt +++ b/idea/testData/refactoring/introduceVariable/ArrayAccessExpr.kt @@ -1,9 +1,3 @@ fun f(list: List) { val value = list[1 + 2] -} -/* -fun f(list: List) { - val i = 1 + 2 - val value = list[i] -} -*/ \ No newline at end of file +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/ArrayAccessExpr.kt.after b/idea/testData/refactoring/introduceVariable/ArrayAccessExpr.kt.after new file mode 100644 index 00000000000..c6c6d3f2cd4 --- /dev/null +++ b/idea/testData/refactoring/introduceVariable/ArrayAccessExpr.kt.after @@ -0,0 +1,4 @@ +fun f(list: List) { + val i = 1 + 2 + val value = list[i] +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/ClassBody.kt b/idea/testData/refactoring/introduceVariable/ClassBody.kt index a5bd81ba677..a71fafec3f1 100644 --- a/idea/testData/refactoring/introduceVariable/ClassBody.kt +++ b/idea/testData/refactoring/introduceVariable/ClassBody.kt @@ -1,9 +1,3 @@ open class A { val x = 1 -} -/* -open class A { - val i = 1 - val x = i -} -*/ \ No newline at end of file +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/ClassBody.kt.after b/idea/testData/refactoring/introduceVariable/ClassBody.kt.after new file mode 100644 index 00000000000..937980e268c --- /dev/null +++ b/idea/testData/refactoring/introduceVariable/ClassBody.kt.after @@ -0,0 +1,4 @@ +open class A { + val i = 1 + val x = i +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/DoWhileAddBlock.kt b/idea/testData/refactoring/introduceVariable/DoWhileAddBlock.kt index 494ee246db9..68e12813d35 100644 --- a/idea/testData/refactoring/introduceVariable/DoWhileAddBlock.kt +++ b/idea/testData/refactoring/introduceVariable/DoWhileAddBlock.kt @@ -2,13 +2,4 @@ open class A() { { do 1 while (true) } -} -/* -open class A() { - { - do { - val i = 1 - } while (true) - } -} -*/ \ No newline at end of file +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/DoWhileAddBlock.kt.after b/idea/testData/refactoring/introduceVariable/DoWhileAddBlock.kt.after new file mode 100644 index 00000000000..8bd97cf4fb8 --- /dev/null +++ b/idea/testData/refactoring/introduceVariable/DoWhileAddBlock.kt.after @@ -0,0 +1,7 @@ +open class A() { + { + do { + val i = 1 + } while (true) + } +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/DoWhileAddBlockInner.kt b/idea/testData/refactoring/introduceVariable/DoWhileAddBlockInner.kt index ec34a0f00fb..fa320c5399d 100644 --- a/idea/testData/refactoring/introduceVariable/DoWhileAddBlockInner.kt +++ b/idea/testData/refactoring/introduceVariable/DoWhileAddBlockInner.kt @@ -2,14 +2,4 @@ open class A() { { do println(1) while (true) } -} -/* -open class A() { - { - do { - val i = 1 - println(i) - } while (true) - } -} -*/ \ No newline at end of file +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/DoWhileAddBlockInner.kt.after b/idea/testData/refactoring/introduceVariable/DoWhileAddBlockInner.kt.after new file mode 100644 index 00000000000..583da6902a8 --- /dev/null +++ b/idea/testData/refactoring/introduceVariable/DoWhileAddBlockInner.kt.after @@ -0,0 +1,8 @@ +open class A() { + { + do { + val i = 1 + println(i) + } while (true) + } +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/FewOccurrences.kt b/idea/testData/refactoring/introduceVariable/FewOccurrences.kt index 0c4c14f3ffc..185be4fa997 100644 --- a/idea/testData/refactoring/introduceVariable/FewOccurrences.kt +++ b/idea/testData/refactoring/introduceVariable/FewOccurrences.kt @@ -2,12 +2,4 @@ fun a() { 1 1 if (true) 1 -} -/* -fun a() { - val i = 1 - i - i - if (true) i -} -*/ \ No newline at end of file +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/FewOccurrences.kt.after b/idea/testData/refactoring/introduceVariable/FewOccurrences.kt.after new file mode 100644 index 00000000000..b249efa00cd --- /dev/null +++ b/idea/testData/refactoring/introduceVariable/FewOccurrences.kt.after @@ -0,0 +1,6 @@ +fun a() { + val i = 1 + i + i + if (true) i +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/FunctionAddBlock.kt b/idea/testData/refactoring/introduceVariable/FunctionAddBlock.kt index 8403106987d..fb33754b117 100644 --- a/idea/testData/refactoring/introduceVariable/FunctionAddBlock.kt +++ b/idea/testData/refactoring/introduceVariable/FunctionAddBlock.kt @@ -1,6 +1 @@ -fun x(): Int = 1 -/* -fun x(): Int { - val i = 1 -} -*/ \ No newline at end of file +fun x(): Int = 1 \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/FunctionAddBlock.kt.after b/idea/testData/refactoring/introduceVariable/FunctionAddBlock.kt.after new file mode 100644 index 00000000000..31ca620fef4 --- /dev/null +++ b/idea/testData/refactoring/introduceVariable/FunctionAddBlock.kt.after @@ -0,0 +1,3 @@ +fun x(): Int { + val i = 1 +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/FunctionAddBlockInner.kt b/idea/testData/refactoring/introduceVariable/FunctionAddBlockInner.kt index c1ad9303d00..3462b44ccf5 100644 --- a/idea/testData/refactoring/introduceVariable/FunctionAddBlockInner.kt +++ b/idea/testData/refactoring/introduceVariable/FunctionAddBlockInner.kt @@ -1,7 +1 @@ -fun x(): Int = println(1) -/* -fun x(): Int { - val i = 1 - println(i) -} -*/ \ No newline at end of file +fun x(): Int = println(1) \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/FunctionAddBlockInner.kt.after b/idea/testData/refactoring/introduceVariable/FunctionAddBlockInner.kt.after new file mode 100644 index 00000000000..9ab41811fd3 --- /dev/null +++ b/idea/testData/refactoring/introduceVariable/FunctionAddBlockInner.kt.after @@ -0,0 +1,4 @@ +fun x(): Int { + val i = 1 + println(i) +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/FunctionLiteral.kt b/idea/testData/refactoring/introduceVariable/FunctionLiteral.kt index 60443bf7198..651cf248267 100644 --- a/idea/testData/refactoring/introduceVariable/FunctionLiteral.kt +++ b/idea/testData/refactoring/introduceVariable/FunctionLiteral.kt @@ -1,9 +1,3 @@ fun foo(c : Collection){ c.filter{it; false} -} -/* -fun foo(c : Collection){ - val function = { it; false } - c.filter(function) -} -*/ \ No newline at end of file +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/FunctionLiteral.kt.after b/idea/testData/refactoring/introduceVariable/FunctionLiteral.kt.after new file mode 100644 index 00000000000..05f4b0cac1c --- /dev/null +++ b/idea/testData/refactoring/introduceVariable/FunctionLiteral.kt.after @@ -0,0 +1,4 @@ +fun foo(c : Collection){ + val function = { it; false } + c.filter(function) +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/FunctionLiteralFromExpected.kt b/idea/testData/refactoring/introduceVariable/FunctionLiteralFromExpected.kt index 0ef532a7182..08b0e4c44cf 100644 --- a/idea/testData/refactoring/introduceVariable/FunctionLiteralFromExpected.kt +++ b/idea/testData/refactoring/introduceVariable/FunctionLiteralFromExpected.kt @@ -4,14 +4,4 @@ class A { fun apply(x: (A) -> Int) = 2 fun test() { apply{it.foo()} -} -/* -class A { - fun foo() = 1 -} -fun apply(x: (A) -> Int) = 2 -fun test() { - val function: (A) -> Int = { it.foo() } - apply(function) -} -*/ \ No newline at end of file +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/FunctionLiteralFromExpected.kt.after b/idea/testData/refactoring/introduceVariable/FunctionLiteralFromExpected.kt.after new file mode 100644 index 00000000000..e3a8b9f69b8 --- /dev/null +++ b/idea/testData/refactoring/introduceVariable/FunctionLiteralFromExpected.kt.after @@ -0,0 +1,8 @@ +class A { + fun foo() = 1 +} +fun apply(x: (A) -> Int) = 2 +fun test() { + val function: (A) -> Int = { it.foo() } + apply(function) +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/IfCondition.kt b/idea/testData/refactoring/introduceVariable/IfCondition.kt index f9eeed5f999..168342bb98e 100644 --- a/idea/testData/refactoring/introduceVariable/IfCondition.kt +++ b/idea/testData/refactoring/introduceVariable/IfCondition.kt @@ -1,11 +1,4 @@ fun a() { if (true) 2 else 1 -} -/* -fun a() { - val b = true - if (b) 2 - else 1 -} -*/ \ No newline at end of file +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/IfCondition.kt.after b/idea/testData/refactoring/introduceVariable/IfCondition.kt.after new file mode 100644 index 00000000000..64eeb858658 --- /dev/null +++ b/idea/testData/refactoring/introduceVariable/IfCondition.kt.after @@ -0,0 +1,5 @@ +fun a() { + val b = true + if (b) 2 + else 1 +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/IfElseAddBlock.kt b/idea/testData/refactoring/introduceVariable/IfElseAddBlock.kt index 1c390070055..e5f6a8c5e24 100644 --- a/idea/testData/refactoring/introduceVariable/IfElseAddBlock.kt +++ b/idea/testData/refactoring/introduceVariable/IfElseAddBlock.kt @@ -1,12 +1,4 @@ fun a() { if (true) 2 else 1 -} -/* -fun a() { - if (true) 2 - else { - val i = 1 - } -} -*/ \ No newline at end of file +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/IfElseAddBlock.kt.after b/idea/testData/refactoring/introduceVariable/IfElseAddBlock.kt.after new file mode 100644 index 00000000000..b793150b15e --- /dev/null +++ b/idea/testData/refactoring/introduceVariable/IfElseAddBlock.kt.after @@ -0,0 +1,6 @@ +fun a() { + if (true) 2 + else { + val i = 1 + } +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/IfElseAddBlockInner.kt b/idea/testData/refactoring/introduceVariable/IfElseAddBlockInner.kt index 674eedd3031..1ea662ed22b 100644 --- a/idea/testData/refactoring/introduceVariable/IfElseAddBlockInner.kt +++ b/idea/testData/refactoring/introduceVariable/IfElseAddBlockInner.kt @@ -1,13 +1,4 @@ fun a() { if (true) 2 else println(1) -} -/* -fun a() { - if (true) 2 - else { - val i = 1 - println(i) - } -} -*/ \ No newline at end of file +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/IfElseAddBlockInner.kt.after b/idea/testData/refactoring/introduceVariable/IfElseAddBlockInner.kt.after new file mode 100644 index 00000000000..bda286d8668 --- /dev/null +++ b/idea/testData/refactoring/introduceVariable/IfElseAddBlockInner.kt.after @@ -0,0 +1,7 @@ +fun a() { + if (true) 2 + else { + val i = 1 + println(i) + } +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/IfThenAddBlock.kt b/idea/testData/refactoring/introduceVariable/IfThenAddBlock.kt index 61e5cece18f..e04e2a466bc 100644 --- a/idea/testData/refactoring/introduceVariable/IfThenAddBlock.kt +++ b/idea/testData/refactoring/introduceVariable/IfThenAddBlock.kt @@ -1,11 +1,4 @@ fun a() { if (true) 1 else 2 -} -/* -fun a() { - if (true) { - val i = 1 - } else 2 -} -*/ \ No newline at end of file +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/IfThenAddBlock.kt.after b/idea/testData/refactoring/introduceVariable/IfThenAddBlock.kt.after new file mode 100644 index 00000000000..5c6aad22e3b --- /dev/null +++ b/idea/testData/refactoring/introduceVariable/IfThenAddBlock.kt.after @@ -0,0 +1,5 @@ +fun a() { + if (true) { + val i = 1 + } else 2 +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/IfThenAddBlockInner.kt b/idea/testData/refactoring/introduceVariable/IfThenAddBlockInner.kt index a2d001ac260..be2f37e6a6d 100644 --- a/idea/testData/refactoring/introduceVariable/IfThenAddBlockInner.kt +++ b/idea/testData/refactoring/introduceVariable/IfThenAddBlockInner.kt @@ -1,12 +1,4 @@ fun a() { if (true) println(1) else 2 -} -/* -fun a() { - if (true) { - val i = 1 - println(i) - } else 2 -} -*/ \ No newline at end of file +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/IfThenAddBlockInner.kt.after b/idea/testData/refactoring/introduceVariable/IfThenAddBlockInner.kt.after new file mode 100644 index 00000000000..5e69e0bcb9c --- /dev/null +++ b/idea/testData/refactoring/introduceVariable/IfThenAddBlockInner.kt.after @@ -0,0 +1,6 @@ +fun a() { + if (true) { + val i = 1 + println(i) + } else 2 +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/It.kt b/idea/testData/refactoring/introduceVariable/It.kt index be8c115c77c..58655fdf12a 100644 --- a/idea/testData/refactoring/introduceVariable/It.kt +++ b/idea/testData/refactoring/introduceVariable/It.kt @@ -4,13 +4,4 @@ fun b() { a { it } -} -/* -fun a(op: (Int) -> Int) {} -fun b() { - a {it} - a { - val i = it - } -} -*/ \ No newline at end of file +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/It.kt.after b/idea/testData/refactoring/introduceVariable/It.kt.after new file mode 100644 index 00000000000..57e869d9c78 --- /dev/null +++ b/idea/testData/refactoring/introduceVariable/It.kt.after @@ -0,0 +1,7 @@ +fun a(op: (Int) -> Int) {} +fun b() { + a {it} + a { + val i = it + } +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/LoopRange.kt b/idea/testData/refactoring/introduceVariable/LoopRange.kt index ceee33b1156..741753b024c 100644 --- a/idea/testData/refactoring/introduceVariable/LoopRange.kt +++ b/idea/testData/refactoring/introduceVariable/LoopRange.kt @@ -1,9 +1,3 @@ fun a() { for (a in 1..2) {} -} -/* -fun a() { - val intRange = 1..2 - for (a in intRange) {} -} -*/ \ No newline at end of file +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/LoopRange.kt.after b/idea/testData/refactoring/introduceVariable/LoopRange.kt.after new file mode 100644 index 00000000000..7ec88d554ff --- /dev/null +++ b/idea/testData/refactoring/introduceVariable/LoopRange.kt.after @@ -0,0 +1,4 @@ +fun a() { + val intRange = 1..2 + for (a in intRange) {} +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/ManyInnerOccurences.kt b/idea/testData/refactoring/introduceVariable/ManyInnerOccurences.kt index e89d8a9ea8b..b7050f49943 100644 --- a/idea/testData/refactoring/introduceVariable/ManyInnerOccurences.kt +++ b/idea/testData/refactoring/introduceVariable/ManyInnerOccurences.kt @@ -8,18 +8,4 @@ fun a() { 1 } } -} -/* -fun a() { - val i = 1 - if (true) { - if (true) { - i - } - } else { - if (true) { - i - } - } -} -*/ \ No newline at end of file +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/ManyInnerOccurences.kt.after b/idea/testData/refactoring/introduceVariable/ManyInnerOccurences.kt.after new file mode 100644 index 00000000000..388d5829534 --- /dev/null +++ b/idea/testData/refactoring/introduceVariable/ManyInnerOccurences.kt.after @@ -0,0 +1,12 @@ +fun a() { + val i = 1 + if (true) { + if (true) { + i + } + } else { + if (true) { + i + } + } +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/ManyOccurrences.kt b/idea/testData/refactoring/introduceVariable/ManyOccurrences.kt index 91849808a39..93b778c0703 100644 --- a/idea/testData/refactoring/introduceVariable/ManyOccurrences.kt +++ b/idea/testData/refactoring/introduceVariable/ManyOccurrences.kt @@ -12,22 +12,4 @@ fun a() { 1 } } -} -/* -fun a() { - val i = 1 - if (true) { - i - } - if (true) { - i - } - if (true) { - i - } else { - if (true) { - i - } - } -} -*/ \ No newline at end of file +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/ManyOccurrences.kt.after b/idea/testData/refactoring/introduceVariable/ManyOccurrences.kt.after new file mode 100644 index 00000000000..341b9b7fb3e --- /dev/null +++ b/idea/testData/refactoring/introduceVariable/ManyOccurrences.kt.after @@ -0,0 +1,16 @@ +fun a() { + val i = 1 + if (true) { + i + } + if (true) { + i + } + if (true) { + i + } else { + if (true) { + i + } + } +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/ReplaceOccurence.kt b/idea/testData/refactoring/introduceVariable/ReplaceOccurence.kt index 94f09bb3557..5134acf73d8 100644 --- a/idea/testData/refactoring/introduceVariable/ReplaceOccurence.kt +++ b/idea/testData/refactoring/introduceVariable/ReplaceOccurence.kt @@ -1,11 +1,4 @@ fun a(x: Int) {} fun b() { a(1) -} -/* -fun a(x: Int) {} -fun b() { - val i = 1 - a(i) -} -*/ \ No newline at end of file +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/ReplaceOccurence.kt.after b/idea/testData/refactoring/introduceVariable/ReplaceOccurence.kt.after new file mode 100644 index 00000000000..18fffc66edf --- /dev/null +++ b/idea/testData/refactoring/introduceVariable/ReplaceOccurence.kt.after @@ -0,0 +1,5 @@ +fun a(x: Int) {} +fun b() { + val i = 1 + a(i) +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/Simple.kt b/idea/testData/refactoring/introduceVariable/Simple.kt index 23c4d75fe91..25dc89c7cd8 100644 --- a/idea/testData/refactoring/introduceVariable/Simple.kt +++ b/idea/testData/refactoring/introduceVariable/Simple.kt @@ -1,8 +1,3 @@ fun a() { 1 -} -/* -fun a() { - val i = 1 -} -*/ \ No newline at end of file +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/Simple.kt.after b/idea/testData/refactoring/introduceVariable/Simple.kt.after new file mode 100644 index 00000000000..777a2bb26c9 --- /dev/null +++ b/idea/testData/refactoring/introduceVariable/Simple.kt.after @@ -0,0 +1,3 @@ +fun a() { + val i = 1 +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/SimpleCreateValue.kt b/idea/testData/refactoring/introduceVariable/SimpleCreateValue.kt index 23c4d75fe91..25dc89c7cd8 100644 --- a/idea/testData/refactoring/introduceVariable/SimpleCreateValue.kt +++ b/idea/testData/refactoring/introduceVariable/SimpleCreateValue.kt @@ -1,8 +1,3 @@ fun a() { 1 -} -/* -fun a() { - val i = 1 -} -*/ \ No newline at end of file +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/SimpleCreateValue.kt.after b/idea/testData/refactoring/introduceVariable/SimpleCreateValue.kt.after new file mode 100644 index 00000000000..777a2bb26c9 --- /dev/null +++ b/idea/testData/refactoring/introduceVariable/SimpleCreateValue.kt.after @@ -0,0 +1,3 @@ +fun a() { + val i = 1 +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/StringInjection.kt b/idea/testData/refactoring/introduceVariable/StringInjection.kt index 581181fc9dc..20ead975aae 100644 --- a/idea/testData/refactoring/introduceVariable/StringInjection.kt +++ b/idea/testData/refactoring/introduceVariable/StringInjection.kt @@ -1,9 +1,3 @@ fun a() { "it's a number ${1}" -} -/* -fun a() { - val i = 1 - "it's a number ${i}" -} -*/ \ No newline at end of file +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/StringInjection.kt.after b/idea/testData/refactoring/introduceVariable/StringInjection.kt.after new file mode 100644 index 00000000000..7caa4ba7bed --- /dev/null +++ b/idea/testData/refactoring/introduceVariable/StringInjection.kt.after @@ -0,0 +1,4 @@ +fun a() { + val i = 1 + "it's a number ${i}" +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/WhenAddBlock.kt b/idea/testData/refactoring/introduceVariable/WhenAddBlock.kt index d5b80609c49..4bca5fa11a0 100644 --- a/idea/testData/refactoring/introduceVariable/WhenAddBlock.kt +++ b/idea/testData/refactoring/introduceVariable/WhenAddBlock.kt @@ -2,13 +2,4 @@ fun a() { when (1) { is 1 -> 2 } -} -/* -fun a() { - when (1) { - is 1 -> { - val i = 2 - } - } -} -*/ \ No newline at end of file +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/WhenAddBlock.kt.after b/idea/testData/refactoring/introduceVariable/WhenAddBlock.kt.after new file mode 100644 index 00000000000..252e7aba070 --- /dev/null +++ b/idea/testData/refactoring/introduceVariable/WhenAddBlock.kt.after @@ -0,0 +1,7 @@ +fun a() { + when (1) { + is 1 -> { + val i = 2 + } + } +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/WhenAddBlockInner.kt b/idea/testData/refactoring/introduceVariable/WhenAddBlockInner.kt index 3ae3550318b..eda70c58393 100644 --- a/idea/testData/refactoring/introduceVariable/WhenAddBlockInner.kt +++ b/idea/testData/refactoring/introduceVariable/WhenAddBlockInner.kt @@ -2,14 +2,4 @@ fun a() { when (1) { is 1 -> println(2) } -} -/* -fun a() { - when (1) { - is 1 -> { - val i = 2 - println(i) - } - } -} -*/ \ No newline at end of file +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/WhenAddBlockInner.kt.after b/idea/testData/refactoring/introduceVariable/WhenAddBlockInner.kt.after new file mode 100644 index 00000000000..235ec19093e --- /dev/null +++ b/idea/testData/refactoring/introduceVariable/WhenAddBlockInner.kt.after @@ -0,0 +1,8 @@ +fun a() { + when (1) { + is 1 -> { + val i = 2 + println(i) + } + } +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/WhenParts.kt b/idea/testData/refactoring/introduceVariable/WhenParts.kt index 55cbd1a1262..d9ac159674e 100644 --- a/idea/testData/refactoring/introduceVariable/WhenParts.kt +++ b/idea/testData/refactoring/introduceVariable/WhenParts.kt @@ -3,13 +3,4 @@ fun a() { is 3 -> 1 is 4 -> 1 } -} -/* -fun a() { - val i = 1 - when (i) { - is 3 -> i - is 4 -> i - } -} -*/ \ No newline at end of file +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/WhenParts.kt.after b/idea/testData/refactoring/introduceVariable/WhenParts.kt.after new file mode 100644 index 00000000000..86f2fa82d6e --- /dev/null +++ b/idea/testData/refactoring/introduceVariable/WhenParts.kt.after @@ -0,0 +1,7 @@ +fun a() { + val i = 1 + when (i) { + is 3 -> i + is 4 -> i + } +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/WhileAddBlock.kt b/idea/testData/refactoring/introduceVariable/WhileAddBlock.kt index c4bab487c7e..2ea3ea2f0ce 100644 --- a/idea/testData/refactoring/introduceVariable/WhileAddBlock.kt +++ b/idea/testData/refactoring/introduceVariable/WhileAddBlock.kt @@ -2,13 +2,4 @@ open class A() { { while (true) 1 } -} -/* -open class A() { - { - while (true) { - val i = 1 - } - } -} -*/ \ No newline at end of file +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/WhileAddBlock.kt.after b/idea/testData/refactoring/introduceVariable/WhileAddBlock.kt.after new file mode 100644 index 00000000000..774dc3da8bc --- /dev/null +++ b/idea/testData/refactoring/introduceVariable/WhileAddBlock.kt.after @@ -0,0 +1,7 @@ +open class A() { + { + while (true) { + val i = 1 + } + } +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/WhileAddBlockInner.kt b/idea/testData/refactoring/introduceVariable/WhileAddBlockInner.kt index 1d46852ce01..8eb53bed8b3 100644 --- a/idea/testData/refactoring/introduceVariable/WhileAddBlockInner.kt +++ b/idea/testData/refactoring/introduceVariable/WhileAddBlockInner.kt @@ -2,14 +2,4 @@ open class A() { { while (true) println(1) } -} -/* -open class A() { - { - while (true) { - val i = 1 - println(i) - } - } -} -*/ \ No newline at end of file +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/WhileAddBlockInner.kt.after b/idea/testData/refactoring/introduceVariable/WhileAddBlockInner.kt.after new file mode 100644 index 00000000000..be5902f5420 --- /dev/null +++ b/idea/testData/refactoring/introduceVariable/WhileAddBlockInner.kt.after @@ -0,0 +1,8 @@ +open class A() { + { + while (true) { + val i = 1 + println(i) + } + } +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/WhileCondition.kt b/idea/testData/refactoring/introduceVariable/WhileCondition.kt index d586b27486b..3493844de5f 100644 --- a/idea/testData/refactoring/introduceVariable/WhileCondition.kt +++ b/idea/testData/refactoring/introduceVariable/WhileCondition.kt @@ -1,9 +1,3 @@ fun a() { while (true) {} -} -/* -fun a() { - val b = true - while (b) {} -} -*/ \ No newline at end of file +} \ No newline at end of file diff --git a/idea/testData/refactoring/introduceVariable/WhileCondition.kt.after b/idea/testData/refactoring/introduceVariable/WhileCondition.kt.after new file mode 100644 index 00000000000..63921251bee --- /dev/null +++ b/idea/testData/refactoring/introduceVariable/WhileCondition.kt.after @@ -0,0 +1,4 @@ +fun a() { + val b = true + while (b) {} +} \ No newline at end of file diff --git a/idea/tests/org/jetbrains/jet/plugin/refactoring/introduce/introduceVariable/AbstractJetExtractionTest.kt b/idea/tests/org/jetbrains/jet/plugin/refactoring/introduce/introduceVariable/AbstractJetExtractionTest.kt index cc45ce281ee..0128bde2c5c 100644 --- a/idea/tests/org/jetbrains/jet/plugin/refactoring/introduce/introduceVariable/AbstractJetExtractionTest.kt +++ b/idea/tests/org/jetbrains/jet/plugin/refactoring/introduce/introduceVariable/AbstractJetExtractionTest.kt @@ -17,16 +17,14 @@ package org.jetbrains.jet.plugin.refactoring.introduce.introduceVariable import com.intellij.ide.DataManager -import com.intellij.psi.PsiElement import com.intellij.refactoring.RefactoringActionHandler import com.intellij.testFramework.fixtures.LightCodeInsightFixtureTestCase import org.jetbrains.jet.JetTestCaseBuilder import org.jetbrains.jet.lang.psi.JetFile -import org.jetbrains.jet.lexer.JetTokens import org.jetbrains.jet.plugin.refactoring.extractFunction.ExtractKotlinFunctionHandler import java.io.File -import junit.framework.TestCase -import kotlin.test.assertEquals +import org.jetbrains.jet.JetTestUtils +import com.intellij.refactoring.BaseRefactoringProcessor.ConflictsInTestsException public abstract class AbstractJetExtractionTest() : LightCodeInsightFixtureTestCase() { protected fun doIntroduceVariableTest(path: String) { @@ -35,33 +33,27 @@ public abstract class AbstractJetExtractionTest() : LightCodeInsightFixtureTestC protected fun doTest(path: String, handler: RefactoringActionHandler) { val mainFile = File(path) + val afterFile = File("$path.after") + val conflictFile = File("$path.conflicts") myFixture.setTestDataPath("${JetTestCaseBuilder.getHomeDirectory()}/${mainFile.getParent()}") val file = myFixture.configureByFile(mainFile.getName()) as JetFile - val lastChild = file.getLastChild() - assert(lastChild != null) + try { + handler.invoke( + getProject(), + myFixture.getEditor(), + file, + DataManager.getInstance().getDataContext(myFixture.getEditor().getComponent()) + ) - val expectedResultText = - when (lastChild!!.getNode()!!.getElementType()) { - JetTokens.BLOCK_COMMENT -> { - val lastChildText = lastChild.getText() - lastChildText!!.substring(2, lastChildText.length() - 2).trim() - } - - JetTokens.EOL_COMMENT -> { - lastChild.getText()!!.substring(2).trim() - } - - else -> null - } - assert(expectedResultText != null) - - handler.invoke( - getProject(), myFixture.getEditor(), file, DataManager.getInstance().getDataContext(myFixture.getEditor().getComponent())) - - val endOffset = file.getLastChild()!!.getTextRange()!!.getStartOffset() - assertEquals(expectedResultText, file.getText()!!.substring(0, endOffset).trim()) + assert(!conflictFile.exists()) + JetTestUtils.assertEqualsToFile(afterFile, file.getText()!!) + } + catch(e: Exception) { + val message = if (e is ConflictsInTestsException) e.getMessages().sort().makeString(" ") else e.getMessage() + JetTestUtils.assertEqualsToFile(conflictFile, message?.replace("\n", " ") ?: e.javaClass.getName()) + } } }