Drop identityEquals from builtins, compiler and tests.

This commit is contained in:
Ilya Gorbunov
2016-01-21 19:40:46 +03:00
parent f5f5a2dcc1
commit 4d5ec9be3f
44 changed files with 66 additions and 185 deletions
@@ -2,7 +2,6 @@ class Test {
fun check(a: Any?): String {
if (this === a) return "Fail 1"
if (!(this !== a)) return "Fail 2"
if (this.identityEquals(a)) return "Fail 3"
return "OK"
}
}
+1 -1
View File
@@ -4,5 +4,5 @@ fun box(): String {
val r = object : Runnable {
override fun run() {}
}
return if (foo(r).identityEquals(r)) "OK" else "Fail"
return if (foo(r) === r) "OK" else "Fail"
}
+1 -1
View File
@@ -4,5 +4,5 @@ fun box(): String {
val r = object : Runnable {
override fun run() {}
}
return if (foo(r).identityEquals(r)) "OK" else "Fail"
return if (foo(r) === r) "OK" else "Fail"
}
+4 -4
View File
@@ -7,10 +7,10 @@ class Foo {
fun box() : String {
val a = Foo()
val b = Foo()
if (!a.identityEquals(a)) return "fail 1"
if (!b.identityEquals(b)) return "fail 2"
if (b.identityEquals(a)) return "fail 3"
if (a.identityEquals(b)) return "fail 4"
if (a !== a) return "fail 1"
if (b !== b) return "fail 2"
if (b === a) return "fail 3"
if (a === b) return "fail 4"
if( a !=b ) return "fail5"
return "OK"
}
@@ -6,6 +6,6 @@ fun box(): String {
val a = A(42)
val b = a.clone()
if (b != a) return "Fail equals"
if (b.identityEquals(a)) return "Fail identity"
if (b === a) return "Fail identity"
return "OK"
}
@@ -6,6 +6,6 @@ fun box(): String {
val a = A(42)
val b = a.clone()
if (a != b) return "Fail equals"
if (a.identityEquals(b)) return "Fail identity"
if (a === b) return "Fail identity"
return "OK"
}
@@ -10,7 +10,7 @@ fun box(): String {
val a = A(42)
val b = a.clone()
if (a == b) return "Fail: $a == $b"
if (a.identityEquals(b)) return "Fail: $a identityEquals $b"
if (a === b) return "Fail: $a === $b"
if (b.x != 239) return "Fail: b.x = ${b.x}"
return "OK"
}
@@ -7,6 +7,6 @@ fun box(): String {
a.add("prosper")
val b = a.clone()
if (a != b) return "Fail equals"
if (a.identityEquals(b)) return "Fail identity"
if (a === b) return "Fail identity"
return "OK"
}
@@ -25,8 +25,8 @@ fun box(): String {
if (c.s != d.s) return "Fail s: ${d.s}"
if (c.l != d.l) return "Fail l: ${d.l}"
if (c.l.identityEquals(d.l)) return "Fail list identity"
if (c.identityEquals(d)) return "Fail identity"
if (c.l === d.l) return "Fail list identity"
if (c === d) return "Fail identity"
return "OK"
}
@@ -6,6 +6,6 @@ fun box(): String {
val a = A("OK")
val b = a.externalClone()
if (a != b) return "Fail equals"
if (a.identityEquals(b)) return "Fail identity"
if (a === b) return "Fail identity"
return b.s
}
@@ -13,23 +13,23 @@ fun box(): String {
val a = original
a += 1
if (!(a.identityEquals(original))) return "Fail 1: $a !== $original"
if (a !== original) return "Fail 1: $a !== $original"
if (a.x != 1) return "Fail 2: ${a.x} != 1"
a -= 2
if (!(a.identityEquals(original))) return "Fail 3: $a !== $original"
if (a !== original) return "Fail 3: $a !== $original"
if (a.x != -1) return "Fail 4: ${a.x} != -1"
a *= -10
if (!(a.identityEquals(original))) return "Fail 5: $a !== $original"
if (a !== original) return "Fail 5: $a !== $original"
if (a.x != 10) return "Fail 6: ${a.x} != 10"
a /= 3
if (!(a.identityEquals(original))) return "Fail 7: $a !== $original"
if (a !== original) return "Fail 7: $a !== $original"
if (a.x != 3) return "Fail 8: ${a.x} != 3"
a %= 2
if (!(a.identityEquals(original))) return "Fail 9: $a !== $original"
if (a !== original) return "Fail 9: $a !== $original"
if (a.x != 1) return "Fail 10: ${a.x} != 1"
return "OK"
@@ -9,12 +9,5 @@ fun box(): String {
val x2 = l[0] === l[0]
if (!x2) return "Fail 2: $x"
val y = l[0].identityEquals(1000)
if (y) return "Fail (y): $y"
val y1 = l[0].identityEquals(1)
if (y1) return "Fail (y1): $y"
val y2 = l[0].identityEquals(l[0])
if (!y2) return "Fail (y2): $y"
return "OK"
}
+2 -2
View File
@@ -1,6 +1,6 @@
fun box() : String {
val a = "lala"
if(!a.identityEquals(a)) return "fail 1"
if(a.identityEquals(a)) return "OK"
if(a !== a) return "fail 1"
if(a === a) return "OK"
return "fail 2"
}
+1 -1
View File
@@ -1,7 +1,7 @@
val f : (Any) -> String = { it.toString() }
fun box() : String {
if(!(f.identityEquals(f))) return "fail 1"
if(!(f === f)) return "fail 1"
if(!(f == f)) return "fail 2"
if(!(f.equals(f))) return "fail 3"
return "OK"
@@ -1,5 +1,5 @@
package test
inline fun <T> doSmth(a: T) : Boolean {
return a.identityEquals(a)
return a === a
}
@@ -4,12 +4,12 @@ fun box(): String {
val s = arrayOf("live", "long")
val t: Array<String> = s.clone()
if (!equals(s, t)) return "Fail string"
if (s.identityEquals(t)) return "Fail string identity"
if (s === t) return "Fail string identity"
val ss = arrayOf(s, s)
val tt: Array<Array<String>> = ss.clone()
if (!equals(ss, tt)) return "Fail string[]"
if (ss.identityEquals(tt)) return "Fail string[] identity"
if (ss === tt) return "Fail string[] identity"
return "OK"
}
@@ -3,35 +3,35 @@ import java.util.Arrays.equals
fun box(): String {
val i = intArrayOf(1, 2)
if (!equals(i, i.clone())) return "Fail int"
if (i.clone().identityEquals(i)) return "Fail int identity"
if (i.clone() === i) return "Fail int identity"
val j = longArrayOf(1L, 2L)
if (!equals(j, j.clone())) return "Fail long"
if (j.clone().identityEquals(j)) return "Fail long identity"
if (j.clone() === j) return "Fail long identity"
val s = shortArrayOf(1.toShort(), 2.toShort())
if (!equals(s, s.clone())) return "Fail short"
if (s.clone().identityEquals(s)) return "Fail short identity"
if (s.clone() === s) return "Fail short identity"
val b = byteArrayOf(1.toByte(), 2.toByte())
if (!equals(b, b.clone())) return "Fail byte"
if (b.clone().identityEquals(b)) return "Fail byte identity"
if (b.clone() === b) return "Fail byte identity"
val c = charArrayOf('a', 'b')
if (!equals(c, c.clone())) return "Fail char"
if (c.clone().identityEquals(c)) return "Fail char identity"
if (c.clone() === c) return "Fail char identity"
val d = doubleArrayOf(1.0, -1.0)
if (!equals(d, d.clone())) return "Fail double"
if (d.clone().identityEquals(d)) return "Fail double identity"
if (d.clone() === d) return "Fail double identity"
val f = floatArrayOf(1f, -1f)
if (!equals(f, f.clone())) return "Fail float"
if (f.clone().identityEquals(f)) return "Fail float identity"
if (f.clone() === f) return "Fail float identity"
val z = booleanArrayOf(true, false)
if (!equals(z, z.clone())) return "Fail boolean"
if (z.clone().identityEquals(z)) return "Fail boolean identity"
if (z.clone() === z) return "Fail boolean identity"
return "OK"
}
@@ -23,7 +23,7 @@ fun box() : String {
val y: Int? = 1000
val z: Int? = 1000
val res = y.identityEquals(z)
val res = y === z
val c1: Any = if (1 == 1) 0 else "abc"
val c2: Any = if (1 != 1) 0 else "abc"
@@ -8,7 +8,7 @@ fun box(): String {
}
}
catch (caught: Throwable) {
if (!(caught.identityEquals(e))) return "Fail: $caught"
if (caught !== e) return "Fail: $caught"
}
return "OK"
@@ -8,7 +8,7 @@ fun box(): String {
}
}
catch (caught: Throwable) {
if (!(caught.identityEquals(e))) return "Fail: $caught"
if (caught !== e) return "Fail: $caught"
// If monitorexit didn't happen (a finally block failed), this assertion would fail
assertThatThreadDoesNotOwnMonitor(obj)
}
@@ -18,7 +18,7 @@ fun foo() {
val y: Int? = 7
val z: Int? = 8
val res = y.identityEquals(z)
val res = y === z
val c1: Any = if (1 == 1) 0 else "abc"
val c2: Any = if (1 != 1) 0 else "abc"