From 4d1b032c1f665ee9ca2f321c3b74b5b216561a35 Mon Sep 17 00:00:00 2001 From: Mikhail Glukhikh Date: Thu, 19 Dec 2019 12:43:21 +0300 Subject: [PATCH] Rename: FirSelfImportingScope -> FirPackageMemberScope --- .../src/org/jetbrains/kotlin/fir/scopes/Scopes.kt | 2 +- .../kotlin/fir/scopes/impl/FirMemberScopeProvider.kt | 12 ++++++------ ...elfImportingScope.kt => FirPackageMemberScope.kt} | 2 +- .../jetbrains/kotlin/idea/fir/FirResolutionApi.kt | 4 ++-- 4 files changed, 10 insertions(+), 10 deletions(-) rename compiler/fir/resolve/src/org/jetbrains/kotlin/fir/scopes/impl/{FirSelfImportingScope.kt => FirPackageMemberScope.kt} (97%) diff --git a/compiler/fir/resolve/src/org/jetbrains/kotlin/fir/scopes/Scopes.kt b/compiler/fir/resolve/src/org/jetbrains/kotlin/fir/scopes/Scopes.kt index 15b409b438c..78731bf664b 100644 --- a/compiler/fir/resolve/src/org/jetbrains/kotlin/fir/scopes/Scopes.kt +++ b/compiler/fir/resolve/src/org/jetbrains/kotlin/fir/scopes/Scopes.kt @@ -26,7 +26,7 @@ fun createImportingScopes( FirExplicitStarImportingScope(file.imports, session, scopeSession), FirDefaultSimpleImportingScope(session, scopeSession, priority = DefaultImportPriority.LOW), FirDefaultSimpleImportingScope(session, scopeSession, priority = DefaultImportPriority.HIGH), - selfImportingScope(file.packageFqName, session), + packageMemberScope(file.packageFqName, session), // TODO: explicit simple importing scope should have highest priority (higher than inner scopes added in process) FirExplicitSimpleImportingScope(file.imports, session, scopeSession) ) diff --git a/compiler/fir/resolve/src/org/jetbrains/kotlin/fir/scopes/impl/FirMemberScopeProvider.kt b/compiler/fir/resolve/src/org/jetbrains/kotlin/fir/scopes/impl/FirMemberScopeProvider.kt index 9a263633742..df1f2b984ef 100644 --- a/compiler/fir/resolve/src/org/jetbrains/kotlin/fir/scopes/impl/FirMemberScopeProvider.kt +++ b/compiler/fir/resolve/src/org/jetbrains/kotlin/fir/scopes/impl/FirMemberScopeProvider.kt @@ -19,7 +19,7 @@ class FirMemberScopeProvider : FirSessionComponent { private val declaredMemberCache = mutableMapOf, FirScope>() private val nestedClassifierCache = mutableMapOf, FirNestedClassifierScope>() - private val selfImportingCache = mutableMapOf() + private val packageMemberCache = mutableMapOf() fun declaredMemberScope( klass: FirClass<*>, @@ -39,9 +39,9 @@ class FirMemberScopeProvider : FirSessionComponent { } // TODO: it's better to cache this scope in ScopeSession - fun selfImportingScope(fqName: FqName, session: FirSession): FirSelfImportingScope { - return selfImportingCache.getOrPut(fqName) { - FirSelfImportingScope(fqName, session) + fun packageMemberScope(fqName: FqName, session: FirSession): FirPackageMemberScope { + return packageMemberCache.getOrPut(fqName) { + FirPackageMemberScope(fqName, session) } } } @@ -79,7 +79,7 @@ fun lazyNestedClassifierScope( return FirLazyNestedClassifierScope(classId, existingNames, symbolProvider) } -fun selfImportingScope(fqName: FqName, session: FirSession): FirSelfImportingScope { - return session.memberScopeProvider.selfImportingScope(fqName, session) +fun packageMemberScope(fqName: FqName, session: FirSession): FirPackageMemberScope { + return session.memberScopeProvider.packageMemberScope(fqName, session) } diff --git a/compiler/fir/resolve/src/org/jetbrains/kotlin/fir/scopes/impl/FirSelfImportingScope.kt b/compiler/fir/resolve/src/org/jetbrains/kotlin/fir/scopes/impl/FirPackageMemberScope.kt similarity index 97% rename from compiler/fir/resolve/src/org/jetbrains/kotlin/fir/scopes/impl/FirSelfImportingScope.kt rename to compiler/fir/resolve/src/org/jetbrains/kotlin/fir/scopes/impl/FirPackageMemberScope.kt index ed359bf45fe..7a63ca49e97 100644 --- a/compiler/fir/resolve/src/org/jetbrains/kotlin/fir/scopes/impl/FirSelfImportingScope.kt +++ b/compiler/fir/resolve/src/org/jetbrains/kotlin/fir/scopes/impl/FirPackageMemberScope.kt @@ -17,7 +17,7 @@ import org.jetbrains.kotlin.name.ClassId import org.jetbrains.kotlin.name.FqName import org.jetbrains.kotlin.name.Name -class FirSelfImportingScope(val fqName: FqName, val session: FirSession) : FirScope() { +class FirPackageMemberScope(val fqName: FqName, val session: FirSession) : FirScope() { private val symbolProvider = FirSymbolProvider.getInstance(session) diff --git a/idea/idea-analysis/src/org/jetbrains/kotlin/idea/fir/FirResolutionApi.kt b/idea/idea-analysis/src/org/jetbrains/kotlin/idea/fir/FirResolutionApi.kt index d93f832826d..3781e21cccb 100644 --- a/idea/idea-analysis/src/org/jetbrains/kotlin/idea/fir/FirResolutionApi.kt +++ b/idea/idea-analysis/src/org/jetbrains/kotlin/idea/fir/FirResolutionApi.kt @@ -18,7 +18,7 @@ import org.jetbrains.kotlin.fir.resolve.getClassDeclaredCallableSymbols import org.jetbrains.kotlin.fir.resolve.transformers.body.resolve.FirDesignatedBodyResolveTransformer import org.jetbrains.kotlin.fir.resolve.transformers.runResolve import org.jetbrains.kotlin.fir.scopes.ProcessorAction -import org.jetbrains.kotlin.fir.scopes.impl.FirSelfImportingScope +import org.jetbrains.kotlin.fir.scopes.impl.FirPackageMemberScope import org.jetbrains.kotlin.fir.symbols.CallableId import org.jetbrains.kotlin.fir.symbols.impl.FirCallableSymbol import org.jetbrains.kotlin.fir.types.FirErrorTypeRef @@ -51,7 +51,7 @@ private fun FirFile.findCallableMember( }?.fir ?: error("Cannot find FIR callable declaration ${CallableId(packageFqName, klassFqName, declName)}") } // NB: not sure it's correct to use member scope provider from here (because of possible changes) - val memberScope = FirSelfImportingScope(this.packageFqName, session) + val memberScope = FirPackageMemberScope(this.packageFqName, session) var result: FirCallableDeclaration<*>? = null val processor = { symbol: FirCallableSymbol<*> -> val fir = symbol.fir