Redundant semicolon: don't report when semicolon is between type and '!'

#KT-38240 Fixed

idea/src/org/jetbrains/kotlin/idea/inspections/RedundantSemicolonInspection.kt

@@ -90,9 +90,13 @@ class RedundantSemicolonInspection : AbstractKotlinInspection(), CleanupLocalIns
                 return false
             }
 
-            val prevNameReference = semicolon.getPrevSiblingIgnoringWhitespaceAndComments() as? KtNameReferenceExpression
+            val prevSibling = semicolon.getPrevSiblingIgnoringWhitespaceAndComments()
-            if (prevNameReference != null && prevNameReference.text in softModifierKeywords
+            val nextSibling = semicolon.getNextSiblingIgnoringWhitespaceAndComments()
-                && semicolon.getNextSiblingIgnoringWhitespaceAndComments() is KtDeclaration
+            if (prevSibling.safeAs<KtNameReferenceExpression>()?.text in softModifierKeywords &&
+                nextSibling is KtDeclaration
+            ) return false
+            if (nextSibling.safeAs<KtPrefixExpression>()?.operationToken == KtTokens.EXCL &&
+                semicolon.prevLeaf()?.getStrictParentOfType<KtTypeReference>() != null
             ) return false
 
             return true

idea/testData/inspectionsLocal/redundantSemicolon/betweenTypeAndNotOperator.kt

@@ -0,0 +1,9 @@
+// PROBLEM: none
+fun test(a: Any) {
+    foo {
+        val b = a as Boolean;<caret>
+        !b
+    }
+}
+
+fun foo(f: () -> Boolean) {}

idea/tests/org/jetbrains/kotlin/idea/inspections/LocalInspectionTestGenerated.java

@@ -8416,6 +8416,11 @@ public class LocalInspectionTestGenerated extends AbstractLocalInspectionTest {
             runTest("idea/testData/inspectionsLocal/redundantSemicolon/betweenSoftModifierKeywordAndDeclaration3.kt");
         }
 
+        @TestMetadata("betweenTypeAndNotOperator.kt")
+        public void testBetweenTypeAndNotOperator() throws Exception {
+            runTest("idea/testData/inspectionsLocal/redundantSemicolon/betweenTypeAndNotOperator.kt");
+        }
+
         @TestMetadata("companionBeforeFun.kt")
         public void testCompanionBeforeFun() throws Exception {
             runTest("idea/testData/inspectionsLocal/redundantSemicolon/companionBeforeFun.kt");