Minor: Pull up original property
This commit is contained in:
+7
-7
@@ -141,22 +141,22 @@ public class JetChangePropertySignatureDialog(
|
|||||||
}
|
}
|
||||||
|
|
||||||
override fun doAction() {
|
override fun doAction() {
|
||||||
val descriptor = (methodDescriptor as? JetMutableMethodDescriptor)?.original ?: methodDescriptor
|
val originalDescriptor = methodDescriptor.original
|
||||||
|
|
||||||
val receiver = if (receiverTypeCheckBox?.isSelected() ?: false) {
|
val receiver = if (receiverTypeCheckBox?.isSelected() ?: false) {
|
||||||
descriptor.receiver ?: JetParameterInfo(callableDescriptor = descriptor.baseDescriptor,
|
originalDescriptor.receiver ?: JetParameterInfo(callableDescriptor = originalDescriptor.baseDescriptor,
|
||||||
name = "receiver",
|
name = "receiver",
|
||||||
defaultValueForCall = getDefaultReceiverValue())
|
defaultValueForCall = getDefaultReceiverValue())
|
||||||
} else null
|
} else null
|
||||||
receiver?.currentTypeText = receiverTypeField.getText()
|
receiver?.currentTypeText = receiverTypeField.getText()
|
||||||
val changeInfo = JetChangeInfo(descriptor,
|
val changeInfo = JetChangeInfo(originalDescriptor,
|
||||||
nameField.getText(),
|
nameField.getText(),
|
||||||
null,
|
null,
|
||||||
returnTypeField.getText(),
|
returnTypeField.getText(),
|
||||||
visibilityCombo.getSelectedItem() as Visibility,
|
visibilityCombo.getSelectedItem() as Visibility,
|
||||||
emptyList(),
|
emptyList(),
|
||||||
receiver,
|
receiver,
|
||||||
descriptor.getMethod())
|
originalDescriptor.getMethod())
|
||||||
|
|
||||||
invokeRefactoring(JetChangeSignatureProcessor(myProject, changeInfo, commandName ?: getTitle()))
|
invokeRefactoring(JetChangeSignatureProcessor(myProject, changeInfo, commandName ?: getTitle()))
|
||||||
}
|
}
|
||||||
@@ -167,7 +167,7 @@ public class JetChangePropertySignatureDialog(
|
|||||||
commandName: String,
|
commandName: String,
|
||||||
descriptor: JetMethodDescriptor
|
descriptor: JetMethodDescriptor
|
||||||
): BaseRefactoringProcessor {
|
): BaseRefactoringProcessor {
|
||||||
val originalDescriptor = (descriptor as? JetMutableMethodDescriptor)?.original ?: descriptor
|
val originalDescriptor = descriptor.original
|
||||||
val changeInfo = JetChangeInfo(methodDescriptor = originalDescriptor, context = originalDescriptor.getMethod())
|
val changeInfo = JetChangeInfo(methodDescriptor = originalDescriptor, context = originalDescriptor.getMethod())
|
||||||
changeInfo.setNewName(descriptor.getName())
|
changeInfo.setNewName(descriptor.getName())
|
||||||
changeInfo.receiverParameterInfo = descriptor.receiver
|
changeInfo.receiverParameterInfo = descriptor.receiver
|
||||||
|
|||||||
+3
@@ -92,6 +92,9 @@ public class JetChangeSignatureData(
|
|||||||
return JetParameterInfo(callableDescriptor = baseDescriptor, name = receiverName, type = receiverType)
|
return JetParameterInfo(callableDescriptor = baseDescriptor, name = receiverName, type = receiverType)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
override val original: JetMethodDescriptor
|
||||||
|
get() = this
|
||||||
|
|
||||||
override val primaryCallables: Collection<JetCallableDefinitionUsage<PsiElement>> by Delegates.lazy {
|
override val primaryCallables: Collection<JetCallableDefinitionUsage<PsiElement>> by Delegates.lazy {
|
||||||
descriptorsForSignatureChange.map {
|
descriptorsForSignatureChange.map {
|
||||||
val declaration = DescriptorToSourceUtilsIde.getAnyDeclaration(baseDeclaration.getProject(), it)
|
val declaration = DescriptorToSourceUtilsIde.getAnyDeclaration(baseDeclaration.getProject(), it)
|
||||||
|
|||||||
+1
-4
@@ -520,11 +520,8 @@ public class JetChangeSignatureDialog extends ChangeSignatureDialogBase<
|
|||||||
}
|
}
|
||||||
|
|
||||||
String returnTypeText = returnTypeCodeFragment != null ? returnTypeCodeFragment.getText().trim() : "";
|
String returnTypeText = returnTypeCodeFragment != null ? returnTypeCodeFragment.getText().trim() : "";
|
||||||
JetMethodDescriptor descriptor = methodDescriptor instanceof JetMutableMethodDescriptor
|
|
||||||
? ((JetMutableMethodDescriptor) methodDescriptor).getOriginal()
|
|
||||||
: methodDescriptor;
|
|
||||||
JetType returnType = getType((JetTypeCodeFragment) returnTypeCodeFragment);
|
JetType returnType = getType((JetTypeCodeFragment) returnTypeCodeFragment);
|
||||||
return new JetChangeInfo(descriptor, methodName, returnType, returnTypeText,
|
return new JetChangeInfo(methodDescriptor.getOriginal(), methodName, returnType, returnTypeText,
|
||||||
visibility, parameters, parametersModel.getReceiver(), defaultValueContext);
|
visibility, parameters, parametersModel.getReceiver(), defaultValueContext);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -41,6 +41,8 @@ public trait JetMethodDescriptor : MethodDescriptor<JetParameterInfo, Visibility
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
val original: JetMethodDescriptor
|
||||||
|
|
||||||
val baseDeclaration: PsiElement
|
val baseDeclaration: PsiElement
|
||||||
val baseDescriptor: CallableDescriptor
|
val baseDescriptor: CallableDescriptor
|
||||||
|
|
||||||
|
|||||||
+1
-1
@@ -18,7 +18,7 @@ package org.jetbrains.kotlin.idea.refactoring.changeSignature
|
|||||||
|
|
||||||
import org.jetbrains.kotlin.descriptors.Visibility
|
import org.jetbrains.kotlin.descriptors.Visibility
|
||||||
|
|
||||||
public class JetMutableMethodDescriptor(val original: JetMethodDescriptor): JetMethodDescriptor by original {
|
public class JetMutableMethodDescriptor(override val original: JetMethodDescriptor): JetMethodDescriptor by original {
|
||||||
private val parameters: MutableList<JetParameterInfo> = original.getParameters()
|
private val parameters: MutableList<JetParameterInfo> = original.getParameters()
|
||||||
|
|
||||||
override var receiver: JetParameterInfo? = original.receiver
|
override var receiver: JetParameterInfo? = original.receiver
|
||||||
|
|||||||
Reference in New Issue
Block a user